Compare commits

..

729 Commits

Author SHA1 Message Date
Julien Fontanet
7e65a139ab fix(proxy/api): allow methods to not prevent proxy shutdown 2024-10-21 00:02:46 +02:00
Pierre Donias
78ae16b21e fix(xo-web/menu): handle null patches (#8060) 2024-10-18 17:30:59 +02:00
Pierre Donias
4102810be6 fix(xo-server): ability to remove blank tags (#8058)
See Zammad#30259
2024-10-18 16:51:50 +02:00
Pierre Donias
86883857d4 fix(xo-server-netbox): ignore empty tags (#8056)
See Zammad#30259
2024-10-18 16:31:19 +02:00
Julien Fontanet
79450a1c51 feat(xo-cli): new watch command 2024-10-18 15:14:23 +02:00
Pierre Donias
6495d563f5 fix(xo-web/createVm): fix typo error → err (#8052)
Introduced by #7122
2024-10-17 15:51:11 +02:00
mathieuRA
761c03e46c feat(xo-server/rest-api): implement getFromAsyncCache in the dashboard 2024-10-17 15:28:41 +02:00
mathieuRA
1eeff13de1 feat(xo-server/utils): creation of getFromAsyncCache 2024-10-17 15:28:41 +02:00
Pierre Donias
2027f8a282 fix(lite): handle IPv6 hosts (#8044)
See https://xcp-ng.org/forum/topic/9767/xo-lite-issue-8-3-ipv6

Add mandatory `[]` around IPv6 addresses when making requests.
2024-10-17 11:47:43 +02:00
Mathieu
2e8d398623 fix(xo-server,xo-web/SR/new): fix reattach button not displayed for HBA (#7986)
See zammad#26485
2024-10-16 11:15:03 +02:00
Florent BEAUCHAMP
fff3ec1f8b fix(backups): support system without cbt (XS< 7.3) (#8038) 2024-10-15 10:54:20 +02:00
Thierry Goettelmann
a7d7cf18c0 feat(web-core): new VtsLabel component (#7983) 2024-10-11 10:50:46 +02:00
Julien Fontanet
00d1792578 feat(xo-cli): 0.31.0 2024-10-10 15:20:05 +02:00
Julien Fontanet
8f6c087e3a feat(xo-cli rest patch): now behaves like post and put 2024-10-10 13:36:15 +02:00
Julien Fontanet
e886e91271 fix(xo-cli rest): correctly resolve server URLs
Previously it failed with a similar error:

```
✖ TypeError [ERR_INVALID_URL]: Invalid URL
    at new NodeError (node:internal/errors:405:5)
    at new URL (node:internal/url:676:13)
    at Object.exec (file:///usr/local/lib/node_modules/xo-cli/rest.mjs:188:21)
    at COMMANDS.<computed> (file:///usr/local/lib/node_modules/xo-cli/rest.mjs:151:29)
    at async main (file:///usr/local/lib/node_modules/xo-cli/index.mjs:434:14) {
  code: 'ERR_INVALID_URL',
  input: 'localhost'
}
```
2024-10-10 13:31:54 +02:00
Mathieu
3d054c8358 feat(xo-server/rest-api/dashboard): avoid iterating over all XAPI objects (#8008) 2024-10-09 14:38:25 +02:00
b-Nollet
a596702a96 feat: release 5.99.1 (#8036) 2024-10-04 14:45:47 +02:00
b-Nollet
bfb2ea6b17 feat: technical release (#8035) 2024-10-04 10:17:23 +02:00
Florent BEAUCHAMP
52c79caa45 fix(vdi): disconnect from dom0 succeed if disk is already destroyed 2024-10-04 09:00:50 +02:00
Florent BEAUCHAMP
8d48797639 feat(@xen-orchestra/xapi): try to disconnect vdi before retry destroy
can happens when a previous job failed with oom while
xapi-nbd kept disk attached to dom0

from https://help.vates.tech/#ticket/zoom/28709
2024-10-04 09:00:50 +02:00
Florent BEAUCHAMP
30172caa1f fix(task/combineEvents): remove ended tasks from map (#8030) 2024-10-03 14:35:10 +02:00
Julien Fontanet
a9b99a8b45 fix(xo-web/Tooltip): don't hide on changing children prop (#8031)
Due to the way React works, `props.children` always change even if it will
resolve to the same DOM node.
The implementation is therefore updated to check equality on DOM nodes directly.
2024-10-03 11:46:12 +02:00
Julien Fontanet
9321b04c5f feat(log): helper to capture logs in an async stack (#7975) 2024-10-02 15:14:32 +02:00
Julien Fontanet
6c258af43a feat(scripts/gen-deps-list.js): reject @xen-orchestra/lite 2024-10-01 11:26:29 +02:00
Stephane
0a28abaada feat(lite): 0.4.0 (#8028)
Co-authored-by: Stephane MEYER <stephane.meyer@vates.tech>
2024-09-30 18:18:18 +02:00
Stephane
a609e98c40 feat: release 5.99.0 (2024-09-30) (#8026) 2024-09-30 17:15:42 +02:00
Stephane
ac06a8ef49 feat: technical release (#8025) 2024-09-30 16:15:18 +02:00
Pierre Donias
2ea2f8040a fix(xo-web/render-xo-item/Schedule): handle undefined job/schedule name (#8024)
See https://xcp-ng.org/forum/topic/9690
Introduced by d520e53f9e
2024-09-30 14:52:40 +02:00
Julien Fontanet
f6e6e052ef feat(xo-web/tasks): ability to delete XO tasks' logs
Related to https://team.vates.fr/vates/pl/s7eb6mkpj7bzpqmwh89apu3eio
2024-09-30 11:33:52 +02:00
Julien Fontanet
748ed07241 chore(xo-web): format with Prettier 2024-09-30 11:30:00 +02:00
Stephane
e5b833dada feat: technical release (#8022) 2024-09-30 11:26:12 +02:00
Mathieu
68b1641e07 fix(xo-server/rest-api/dashboard): fix 'cannot get handler to proxy remote' (#8021) 2024-09-30 10:59:26 +02:00
Florent BEAUCHAMP
ad8cd3791b fix(xo-server): migration of vm with cbt enabled disk (#8017) 2024-09-30 09:04:33 +02:00
Julien Fontanet
030b3ad4d1 feat: move invalid response detection from xen-api to xapi
Introduced in ea5358e76

Fixes https://xcp-ng.org/forum/post/83157

The detection taints the stream and makes helpers like `body.text()` unusable.
2024-09-29 17:15:05 +02:00
Stephane
cfea2b3a2b feat: technical release (#8020) 2024-09-27 16:21:46 +02:00
OlivierFL
44e33666cf feat(xo-6/dashboard): add resources overview data (#8009)
Display resources overview data on XO 6 dashboard.
2024-09-27 14:20:06 +02:00
Stephane
939ab29d04 fix(xo-server/api): private data in api call (#8019) 2024-09-27 14:04:22 +02:00
MlssFrncJrg
cdfe0b0374 feat(xo-server,xo-web): display bond mode of a network (#8010) 2024-09-27 12:37:25 +02:00
Julien Fontanet
eb39e14972 fix(xo-server/rest-api): set apiContext
This makes the REST API more closely resemblethe JSON-RPC API and addresses
several issues such as the broken _Rolling Pool Update_ pool action.

Fixes https://xcp-ng.org/forum/post/82867
2024-09-27 12:15:42 +02:00
Pierre Donias
d520e53f9e feat(xo-web/backup): backup job sequences (#8014)
See #7985
2024-09-27 12:13:55 +02:00
Florent BEAUCHAMP
f7df1c4109 feat(xo-server/api): add a schedule.runSequence method (#7985) 2024-09-27 10:30:33 +02:00
Florent BEAUCHAMP
558ea84880 feat(backups): improve health check error messages (#8016)
- waitObjectState already throw if timeout is reached
- gives more details to help user understand the issue
  - timeout reached while waiting for  ${refOrUuid} to be running
  - timeout reached while waiting for  ${refOrUuid} to report the
    driver version through the xen tools.
2024-09-27 09:11:04 +02:00
Mathieu
0e9242be51 fix(xo-server/rest-api/dashboard): fix 'no such VM <uuid>' when calculating vms protection (#8013) 2024-09-27 09:07:22 +02:00
MlssFrncJrg
943ad781cc fix(xo-server/xo-web/mirrorBackup): correct new schedule property on edited mirror backup job (#8001)
Introduced by ee0adae
2024-09-26 17:18:56 +02:00
OlivierFL
6b21f08ab0 feat(xo-6/dashboard): add VMs protection data (#8007) 2024-09-26 17:10:51 +02:00
Julien Fontanet
ea5358e76b feat(xen-api/getResource): detect invalid XAPI response 2024-09-26 15:15:00 +02:00
Julien Fontanet
742109ccba fix(CHANGELOG.unreleased): add missing entry
Introduced by b47019e0e
2024-09-26 15:14:22 +02:00
Julien Fontanet
00f2f8c103 fix(xo-cli rest get): properly parse --output 2024-09-26 15:13:07 +02:00
Julien Fontanet
291c5a430d feat(xo-cli rest): post/put accept --input $file 2024-09-26 15:13:04 +02:00
Stephane
9ad13608eb feat: technical release (#8015) 2024-09-26 14:55:46 +02:00
OlivierFL
fc3e954d3e feat(xo-6/dashboard): add S3 backup repository data (#8006) 2024-09-26 14:40:59 +02:00
b-Nollet
cc3d5f2efc feat(xo-server, xo-web): warning for too small host TLS keys (#7995) 2024-09-26 11:58:59 +02:00
Julien Fontanet
090c4ecb23 docs(airgap): fix bad copy/paste 2024-09-25 22:00:20 +02:00
Olivier Lambert
b78c7d228d docs(airgap): add the full offline process via our deploy script (#8011) 2024-09-25 21:40:15 +02:00
Mathieu
13f2afb0d6 feat(web-core): new Info component (#7997) 2024-09-25 15:32:16 +02:00
Mathieu
f651943add feat(xo-server/rest-api/dashboard): add resources overview information (#8005) 2024-09-25 15:24:22 +02:00
Julien Fontanet
c0f1d61c01 feat(PULL_REQUEST_TEMPLATE): document review process 2024-09-25 10:55:02 +02:00
Stephane M.
e65823b4a5 fix(xo-server/api): undefined on connecting iscsi lun to xoa (#8004) 2024-09-25 10:41:25 +02:00
OlivierFL
75684cbe12 feat(xo-core): update UiIcon component (#8003) 2024-09-25 10:31:59 +02:00
Mathieu
971a561879 fix(xo-server/rest-api): remove alarms info from the dashboard and messages endpoint (#7959) 2024-09-25 10:20:58 +02:00
Mathieu
d6bba81d36 feat(xo-server/rest-api/dashboard): add vmsProtection information (#7964) 2024-09-24 17:33:25 +02:00
Stephane M.
206f59575a test(xo-collection): convert from Jest to node:test (#7987)
Co-authored-by: Stephane MEYER <stephane.meyer@vates.tech>
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
2024-09-24 17:04:22 +02:00
OlivierFL
dbf3d82a1b feat(xo-core): update VtsCounter component to v2 (#7994) 2024-09-24 16:00:16 +02:00
b-Nollet
d3414a94c6 feat(xo-web): display more notes on backup main page (#7977) 2024-09-24 14:31:23 +02:00
Mathieu
7e9b4447bf feat(xo-server/rest-api/dashboard): add S3 backup repositories information (#7978) 2024-09-24 12:22:25 +02:00
Pierre Donias
8a10070f4d feat(netbox): support Netbox v4.1 (#8002)
Fixes #7966
2024-09-24 11:21:19 +02:00
Stephane M.
b365e4aa25 test(defined): create tests for defined() (#7967)
Co-authored-by: Stephane MEYER <stephane.meyer@vates.tech>
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
2024-09-24 10:17:31 +02:00
Julien Fontanet
28709b660e fix(eslint): accept Node 16 ES sytaxes in tests 2024-09-23 18:03:06 +02:00
Julien Fontanet
19067f7f6c feat(xo-cli rest): post/put from file support params
Params are passed in the query string instead of the body.
2024-09-23 18:03:06 +02:00
Pierre Donias
a297160432 feat(netbox): check Netbox version down to minor + allow to bypass check (#7992) 2024-09-23 14:59:51 +02:00
Stephane M.
381c83d0b3 test(parse-duration): create unit tests (#7968) 2024-09-22 20:50:42 +02:00
Julien Fontanet
7e14152473 feat(xo-server/rest-api): expose VM controllers' VDIs 2024-09-20 14:15:48 +02:00
OlivierFL
21bd7394fa fix(xo-lite/stories): add missing required props for UiButton component configs (#7996) 2024-09-20 11:07:54 +02:00
Pizzosaure
89aa7df744 fix(xo-web/backup): fix normalizedSettings[''] is undefined when editing a backup job
Introduced by 8a9a67c
2024-09-20 10:22:01 +02:00
Pizzosaure
b62e8035fc fix(xo-web/backup): fix r[''] is undefined when creating a backup job
Introduced by 8a9a67c
Fixes #7990
2024-09-20 10:22:01 +02:00
Thierry Goettelmann
02ed1bcee2 docs(web-core): component variants guidelines + composable (#7743) 2024-09-20 10:17:55 +02:00
Julien Fontanet
63a88b1525 fix(xen-api): don't normalize/trim strings in XML-RPC
This applies to both XML-RPC transport and results of XAPI tasks.

Before this commit, all whitespaces (spaces, new lines, etc.) were reduces to
a single whitespaces and leading and trailing whitespaces where removed.

This led to malformed values such as the result of `host.get_server_certificate`.
2024-09-19 16:19:58 +02:00
Thierry Goettelmann
2b1d6f21a0 fix(lite,web,web-core): lock Vue version to 3.4 + ESLint error (#7998)
Prevent Vue upgrade to 3.5 and fix ESLint error in the demo story.

- The recent upgrade of XO Lite / 6 to Vue 3.5 broke the CI due to typing errors (778362d8db)
- Temporarily blocks Vue from upgrading beyond 3.4 to avoid CI failures
- Fixes an attribute case mismatch in the demo story that was causing an ESLint error
2024-09-19 15:38:25 +02:00
Thierry Goettelmann
e13c0789e8 docs(web-core): component guidelines (#7696) 2024-09-19 11:23:45 +02:00
Julien Fontanet
778362d8db chore: refresh yarn.lock 2024-09-19 10:58:41 +02:00
Julien Fontanet
530c30fd50 fix(xo-server/rest-api): handle missing content-length
Unconditional cast gave `NaN` instead of `undefined` which broke automatic
computation when using VHD.
2024-09-18 11:12:22 +02:00
Julien Fontanet
4debc0f893 chore(backups/importIncrementalVm): remove VHD stream length computation
It's now unnecessary thanks to 57a399c64.
2024-09-18 10:47:19 +02:00
Julien Fontanet
57a399c64d feat(xapi/VDI_importContent): compute VHD stream length if missing 2024-09-18 10:45:51 +02:00
Julien Fontanet
0acd7c3530 fix(xapi/SR_importVdi): use VDI_destroy on error
It retries on `VDI_IN_USE` error contrary to `VDI.destroy`.
2024-09-18 10:18:22 +02:00
Julien Fontanet
088bd7cfd3 feat(xo-cli rest): post/put from a file 2024-09-17 17:48:40 +02:00
Julien Fontanet
b47019e0e4 feat(xo-cli rest get): displays stats when using -o $file 2024-09-17 16:02:02 +02:00
Julien Fontanet
aa490dc066 fix(xo-server/rest-api): fix broken VDI export
Introduced by 7b256ab8e

Not completely fixed by 8eae8e7f4

See zammad#27167
2024-09-17 15:38:34 +02:00
Julien Fontanet
b8388bb255 fix(backups): error message typo 2024-09-17 15:21:57 +02:00
OlivierFL
f969056d02 feat(web-stack): update components to match new colors from design system (#7989) 2024-09-17 08:47:54 +02:00
OlivierFL
5e11547439 feat(web-stack): replace components CSS color variables with new ones (#7984)
Replace legacy CSS colors variables in components with new ones created by #7973
2024-09-17 08:39:52 +02:00
MlssFrncJrg
04f3a09ab0 fix(xo-web/host): fix "an error has occurred" in host Mode column (#7954) 2024-09-16 09:46:50 +02:00
MlssFrncJrg
385ff21f4a feat(xo-web/disks): add icon for empty metadata VDI snapshots (#7970) 2024-09-16 09:44:17 +02:00
b-Nollet
40f5f48f17 fix(xo-web/backup): avoid 0 value for backup speed limit (#7980)
Backup job's speed limit (`maxExportRate`) had values `0` and `undefined`
leading to the same behaviour, but the values were both accepted, which could be
confusing. 0 values are now replaced by `undefined` when creating or editing a
backup job.
2024-09-13 09:25:35 +02:00
Julien Fontanet
74e6fa26a6 chore: refresh yarn.lock 2024-09-11 11:58:00 +02:00
Julien Fontanet
e26e1a2f90 fix(xo-server/hub/recipes/kubernetes): sort versions in selector 2024-09-11 11:53:05 +02:00
Julien Fontanet
c7970b3809 feat(scripts/gen-deps-list.js): don't upgrade lite due to dependency
XO Lite has a separate release process.
2024-09-11 10:55:45 +02:00
Julien Fontanet
4c7acc1614 feat: release 5.98.1 2024-09-10 16:57:12 +02:00
Julien Fontanet
fd18bee62f feat(xo-web): 5.155.0 2024-09-10 14:50:47 +02:00
Julien Fontanet
a9ad679933 feat(xo-server-sdn-controller): 1.0.10 2024-09-10 14:50:37 +02:00
Julien Fontanet
cd2b7a2553 feat(xo-server-perf-alert): 0.5.0 2024-09-10 14:50:15 +02:00
Julien Fontanet
b061ff63e7 feat(xo-server): 5.154.0 2024-09-10 14:49:13 +02:00
Julien Fontanet
28d1d8b473 feat(@xen-orchestra/proxy): 0.28.14 2024-09-10 14:45:06 +02:00
Julien Fontanet
8f5c4f336d feat(@xen-orchestra/backups): 0.53.1 2024-09-10 14:44:15 +02:00
Julien Fontanet
3c5ad184b5 feat(@xen-orchestra/xapi): 7.4.0 2024-09-10 14:43:12 +02:00
Mathieu
3ced19b4dc fix(xo-web/dashboard/health): alarms value can be Infinity, -Infinity or NaN (#7965)
See zammad#28645
2024-09-10 14:15:39 +02:00
Florent BEAUCHAMP
9504132585 feat(backups/CBT): retry data_destroy when error is VDI_IN USE (#7960)
Fixes #7826

Sometimes XAPI takes too long to detach the VDI,
in this case, the timeout is fixed at 4s, non modifiable
when the timeout is reached the xapi raise a VDI_IN_USE error

This commit adds a retry on XO side to give more room for XAPI
to work through this process, as XO already does it on VDI destroy
2024-09-10 12:19:13 +02:00
Pierre Donias
fc67abd25b chore(xo-web/i18n): update Japanese locale file 2024-09-10 10:49:02 +02:00
Yasushi Taki
72d0866174 feat(xo-web/i18n): add additional Japanese translations 2024-09-10 10:49:02 +02:00
Thierry Goettelmann
073b15ed07 feat(web-core): new useTable composable (#7936) 2024-09-10 10:14:37 +02:00
Thierry Goettelmann
7c31b44bb0 fix(web-core/useRouteQuery): URL not updating immediately in some cases (#7935)
Introduced by 290b5df
2024-09-10 09:11:43 +02:00
Thierry Goettelmann
e830bf0f0c fix(web-core): tooltip position does not update when content changes (#7979) 2024-09-10 09:06:24 +02:00
Thierry Goettelmann
790ba9bdd1 feat(web-core): new color scheme + naming from design system (#7973) 2024-09-10 08:35:35 +02:00
OlivierFL
6c8d41db00 feat(xo-6/dashboard): add backup issues data (#7974) 2024-09-09 15:44:15 +02:00
Thierry Goettelmann
576a3aa007 fix(web6): record can be undefined in single record context (#7976) 2024-09-09 14:48:15 +02:00
Julien Fontanet
af17f4a28a fix(xo-server-sdn-controller): don't try to install certs on ro pools 2024-09-09 10:33:18 +02:00
Florent BEAUCHAMP
2f7e0d0963 fix(v2v): computation of memory_static_max (#7971)
Introduced by ad1bf3b348

The max memory that can be assigned to a VM is not correctly passed by the v2v import
2024-09-09 09:26:53 +02:00
Julien Fontanet
01c71414ae fix(xo-server/xen-servers): don't try to mark read-only pool
This led to many warnings in the log.
2024-09-06 15:49:37 +02:00
Pierre Donias
1ca468064f fix(xo-web/host/PCI): "Enabled" → "Passthrough enabled" (#7961)
See https://team.vates.fr/vates/pl/p66inuymi3gm7cxf9tgkx3aa8c
2024-09-05 10:13:10 +02:00
MlssFrncJrg
69ffac65f0 feat(xo-server-perf-alert): don't compute RAM usage when no tools (#7886)
See https://kanban.vates.fr/b/jnfjuip4eBARBNuv9/xo-releases/jHtPoS4TKqZB7QL7Z
See #7831
2024-09-05 09:21:34 +02:00
MlssFrncJrg
f38b449624 feat(xo-server/rest-api/dashboard): add backup name and type (#7958) 2024-09-05 09:09:27 +02:00
Julien Fontanet
07cd06c245 feat(xo-server/rest-api): expose PIFs and VM controllers 2024-09-05 08:47:20 +02:00
Julien Fontanet
813ca246c4 feat(xo-web/pool/networks): searchable VLANs
See zammad#28710
2024-09-05 08:42:09 +02:00
Julien Fontanet
3b217ea975 feat(xo-web/pool/networks): sortable VLANs
See zammad#28710
2024-09-05 08:41:56 +02:00
Julien Fontanet
2151450584 chore(xo-web/pool/networks): inject default PIF directly into networks 2024-09-04 17:19:13 +02:00
Julien Fontanet
7cebe46e86 fix(log): revert incorrect change
Introduced by 974668587
2024-09-02 17:26:40 +02:00
Julien Fontanet
89b9a1f4b7 fix: revert to rimraf@5 to keep Node 18 support 2024-09-02 17:19:06 +02:00
Julien Fontanet
974668587d chore: update dev deps 2024-09-02 17:08:05 +02:00
Julien Fontanet
dfe6911aba chore: update dev deps 2024-09-02 13:49:50 +02:00
Mathieu
f1780b7b0f feat: release 5.98.0 (#7952) 2024-08-30 14:41:47 +02:00
Julien Fontanet
20c88b4e90 feat(xo-server-backup-reports): 1.4.1 2024-08-30 11:21:21 +02:00
b-Nollet
aa9c49ce6a fix(xo-server-backup-report): replacing partial symlinks by shared partials
Symlinks are not packed by npm which led to a broken package.
2024-08-30 11:19:22 +02:00
Julien Fontanet
951de95e4b chore(xo-server-backup-reports): shared partials 2024-08-30 11:19:22 +02:00
Mathieu
385b6b2fee feat: technical release (#7951) 2024-08-30 11:13:49 +02:00
mathieuRA
a976a5a3b3 fix(xo-server/rest-api/dashboard): catch error if getSchedule throw 2024-08-30 10:24:32 +02:00
mathieuRA
e8b32fef81 fix(xo-server/rest-api/dashboard): remoteInfo can be undefined 2024-08-30 10:24:32 +02:00
Julien Fontanet
edb021e40e fix(xo-server): fix mirror backup filter schema
Introduced by 259beead8
2024-08-29 17:40:07 +02:00
Mathieu
ae2e9e1a58 feat: technical release (#7948) 2024-08-29 17:33:01 +02:00
Florent BEAUCHAMP
83a8f295c7 fix(xo-server/migration): don't loop if VM failed to migrate with CBT enabled (#7940)
bug not reproducted on our lab
apply the same patch as commit d2a897c3b88d478a04fef0fb75b809cacc80b97a

The disk attached to dom0 is a xapi internal process, this commit ensure
it is not taken into account when choosing a stratrgey to disable CBT

this commit also ensure the process is not stuck in infinite loop if the
xapi fail to disable CBT
2024-08-29 16:54:28 +02:00
MlssFrncJrg
bddfb21e2d fix(xo-web/disks): error not displayed when toggling CBT (#7947)
Fixes https://kanban.vates.fr/b/jnfjuip4eBARBNuv9/xo-releases/YbkpWEJPpQgz7GTsx
2024-08-29 16:36:30 +02:00
Mathieu
cf7dbd1c36 fix(xo-server/rest-api/dashboard): exclude disabled and S3 from backupRepositoriesSize (#7945)
introduced by 4dfd77b
2024-08-29 16:29:01 +02:00
Florent BEAUCHAMP
204cb25d2b feat(backups): replication failing with snapshot attached to dom0 (#7920)
disks could still be attached to dom0 after the transfers given the caches and the asynchronous nature of the operation.

This PR ensure the cache are fully up to date before running the destroy code and also will let the XAPI handle the disk attached to dom0, as it was before the refactoring
2024-08-29 15:53:07 +02:00
Mathieu
5656ab1d48 feat(xo-web/mirror): add the possibility to select vm backups (#7941)
* feat(xo-web/mirror): add the UI to select vm backups to transfer

following 259beead81
2024-08-29 15:48:32 +02:00
b-Nollet
99ffefae10 feat(xo-web,xo-server-backup-reports): smaller backup reports option 2024-08-29 15:20:31 +02:00
b-Nollet
a78e1346f6 feat(xo-server-backup-reports): adding compact templates for Slack and XMPP 2024-08-29 15:20:31 +02:00
MlssFrncJrg
0d5f86620d fix(xo-server-perf-alert): CPU usage alert email displays NaN (#7925) 2024-08-29 15:01:40 +02:00
Florent Beauchamp
18bea75d28 refactor(backup/mirror): compute filter predicate only once 2024-08-29 14:53:43 +02:00
Florent Beauchamp
5e6bb22025 feat(backup/mirror): better full backup filtering
If the user defined a filter and the filter only match part of the full
backups, then we'll only transfer the matched backups

If the user is using incremental backup, then we'll trnsfer the full chain
if at least only one match
2024-08-29 14:53:43 +02:00
Florent Beauchamp
091da7b913 fix(backups): mirror from multiple jobs
the algorithm sorting the backup to transfer do not take into account multiple
job writing to the same remote
It can lead to additional VM being transferred
2024-08-29 14:53:43 +02:00
Florent Beauchamp
ec3fe212e1 feat: gives more information to the user 2024-08-29 14:53:43 +02:00
Florent Beauchamp
259beead81 feat(backups/mirror): filter backup to be transfered 2024-08-29 14:53:43 +02:00
Mathieu
b1ce62f23a feat(xo-server-perf-alert): add a toggle to exclude items (#7911) 2024-08-29 14:42:37 +02:00
OlivierFL
cd25873182 fix(xo-core/StackedBar): division by 0 in some cases (#7944)
Introduced by 14da422
2024-08-29 10:49:06 +02:00
OlivierFL
a7165da4a0 fix(xo-core/CardNumbers): division by 0 in some cases (#7946)
Introduced by dc7fd78
2024-08-29 10:43:11 +02:00
Julien Fontanet
95f0ef504d feat(xo-web): show copiable when activating OTP
Requested by an IRC user to make it easier to use with Bitwarden.
2024-08-29 09:25:29 +02:00
MlssFrncJrg
732cab3ac0 fix(xo-web/vm/general): fix 'an error as occured' (#7928) 2024-08-28 18:58:18 +02:00
MlssFrncJrg
fb01d20c2e fix(xo-web/new/sr): fix an error as occured when host is missing (#7931) 2024-08-28 18:42:24 +02:00
Julien Fontanet
034d4faa6a feat: release 5.95.2 2024-08-28 15:45:03 +02:00
Mathieu
beb93cf66f feat: technical release (#7943) 2024-08-28 15:03:36 +02:00
Florent BEAUCHAMP
ad1bf3b348 fix(xo-server/v2v): use the template method for static_memory_min (#7923) 2024-08-28 14:33:14 +02:00
OlivierFL
43c3a82800 fix(CHANGELOG.unreleased): add missing entries (#7942) 2024-08-28 14:05:15 +02:00
OlivierFL
7fc5b850ca feat(xo-6/tree-view): display running VMs count (#7873) 2024-08-28 12:11:58 +02:00
Julien Fontanet
916c15d8c7 chore(xo-server-backup-reports): unify templates compilation (#7939)
It will make adding new templates easier.

Co-authored-by: b-Nollet <bastien.nollet@vates.tech>
2024-08-27 15:28:59 +02:00
MlssFrncJrg
4b47bf9220 feat(xo-web/home): sort VMs by install time (#7910)
Fixes #7902
2024-08-27 15:11:19 +02:00
Julien Fontanet
877fe9a663 fix(CHANGELOG.unreleased): add missing entries
Introduced by 8eae8e7f4
2024-08-27 14:56:14 +02:00
OlivierFL
88c7c8d3ae feat(xo-core): add BackupItem component (#7934) 2024-08-26 14:52:31 +02:00
OlivierFL
23720dd05f feat(xo-core/ButtonIcon): add prop to change the click target size (#7922) 2024-08-26 13:57:43 +02:00
OlivierFL
d796e37df5 feat(xo-core): update SearchBar component's name -> QuerySearchBar (#7933) 2024-08-26 11:10:32 +02:00
Mathieu
9734410833 feat(xo-server/rest-api/dashboard): add backup issues information (#7919) 2024-08-26 10:39:11 +02:00
OlivierFL
aa7ff37b94 feat(xo-6/vm): use HeadBar component instead of custom integration (#7858) 2024-08-26 10:33:49 +02:00
OlivierFL
0eaa6a93a3 feat(xo-6/dashboard): add patches data (#7930) 2024-08-26 10:22:09 +02:00
OlivierFL
b33a84e5c7 feat(xo-6/dashboard): add backups jobs data (#7929) 2024-08-26 10:08:39 +02:00
OlivierFL
e65c5d02f3 feat(xo-6/dashboard): add storage repository data (#7927) 2024-08-26 09:00:12 +02:00
OlivierFL
dc7fd78b4a feat(xo-6/dashboard): add backup repository data (#7926) 2024-08-26 08:46:24 +02:00
Julien Fontanet
8eae8e7f46 fix(xapi/VDI_exportContent): return stream in raw mode
Introduced by 7b256ab8e

See zammad#27167
2024-08-23 10:49:25 +02:00
Julien Fontanet
da84ab1590 feat(xo-server/vif.set): returns VIF id because it might change
Fixes https://team.vates.fr/vates/pl/j1cxbejxkfdwud1qw8qwgog8oa
2024-08-22 10:40:39 +02:00
Thierry Goettelmann
290b5df27c feat(web-core): new useRouteQuery composable (#7906) 2024-08-20 17:52:58 +02:00
b-Nollet
72592a54d2 fix(backups): correctly update allowed_operations - temporary fix (#7924)
Fixes https://xcp-ng.org/forum/post/81327

`allowed_operations` are currently not updated correctly when `blocked_operations` are modified, which causes backup jobs to remove `migrate_send` and `pool_migrate` from VM's `allowed_operations`. This commit fixes that, until `allowed_operations` updates correctly again.
2024-08-20 11:11:48 +02:00
Mathieu
e5c53dfa52 feat(xo-server/rest-api/dashboard): add backupJobs info (#7908) 2024-08-19 11:20:24 +02:00
Mathieu
9d196c4211 feat(xo-server/rest-api/dashboard): add alarms info (#7914) 2024-08-19 11:06:03 +02:00
Thierry Goettelmann
e15f2a1428 feat(web-core): replace no-use-before-define ESLint rule with its TS-compliant version (#7916) 2024-08-16 16:07:55 +02:00
Thierry Goettelmann
f78a140fbb feat(web): new REST API and XO objects configuration system (#7918)
Major revamp of the REST API configuration to get a single source of truth + stronger typing + support for single objects.
2024-08-16 15:03:49 +02:00
MlssFrncJrg
79ce97b3fd fix(xo-web/import): properly filter selectors with selected pool (#7905) 2024-08-14 17:23:51 +02:00
OlivierFL
1e7d02603b fix(xo-6): rollup error when building with npm (#7891)
Add `overrides` section in XO6 `package.json` to fix
`Error: Cannot find module @rollup/rollup-linux-x64-gnu` rollup error when
building with npm.
2024-08-14 11:52:53 +02:00
MlssFrncJrg
59bf23a41a feat(xo-web/sr/disks): duplicate CBT state to storage view (#7888)
Fixes #7786
2024-08-14 11:28:09 +02:00
Thierry Goettelmann
39e34eede7 feat(web-core): add Branded TS utility type (#7917) 2024-08-14 10:02:08 +02:00
Julien Fontanet
32228e8c6a fix(xo-web/Home/VM): sort by start time move halted VMs at the end
Fixes https://team.vates.fr/vates/pl/kyxx4qgq5fn58fs7odia7zca8w
2024-08-13 11:45:47 +02:00
Julien Fontanet
7163002c51 feat(xo-web/Home): sortByFn to use a function instead of a property 2024-08-13 11:43:51 +02:00
OlivierFL
700149dabe chore(xo-core): update NoVnc typescript type (#7900)
Use type definitions from DefinitelyTyped instead of using custom declaration
2024-08-09 15:56:44 +02:00
OlivierFL
06af045dac fix(xo-core): wrong CSS lang in StackedBarWithLegend component (#7907) 2024-08-09 15:26:37 +02:00
OlivierFL
b6ccb72e43 chore(web stack): add ESLint rule to check style and script tags "lang" attribute (#7898) 2024-08-09 14:44:56 +02:00
Paloma
14da422b8b feat(xo-web): add stacked bar with legend component (#7819) 2024-08-09 14:38:46 +02:00
Mathieu
5dd305228b feat(xo-server/rest-api/dashboard): add storage repositories info (#7904)
Add storage repository info in the dashboard endpoint for the XO6 dashboard
replications and other data will be calculated in another PR as there is no trivial way to do it

```ts
{
 // ...
  "storageRepositories": {
    "size": {
      "available": number,
      "other": 0,
      "replicated": 0,
      "total": number,
      "used": number
    }
  }
}
 ```
2024-08-08 15:44:12 +02:00
Julien Fontanet
e75cccf1be feat(web-core/stores/ui): default theme is now _auto_
Introduced by 7f4f86073
2024-08-08 13:47:52 +02:00
Julien Fontanet
0e6bc063db fix(xo-server/isHyperThreadingEnabled): better XCP-ng>=8.3 support 2024-08-07 16:02:12 +02:00
Julien Fontanet
0291d42af7 fix(xo-web/home/sr): fix shared sort
It was not working at all because current system only accepts strings for `sortBy` property.
2024-08-07 15:00:40 +02:00
Julien Fontanet
656786eb86 fix(proxy/authentication): keep token synced with config 2024-08-07 14:56:10 +02:00
Mathieu
4dfd77b2d2 feat(xo-server/rest-api/dashboard): add backup repositories info (#7882) 2024-08-06 17:51:20 +02:00
Mathieu
895a551c7b fix(xo-server/rest-api/dashboard): ignore EOL hosts if getHVSupportedVersions unavailable (#7901)
Introduced by ddfdce9
2024-08-06 16:51:58 +02:00
Pierre Donias
e750a66c02 fix(xo-web/self): remove unit in CPU usage total count (#7894)
Introduced by #7353
2024-08-06 09:33:40 +02:00
Julien Fontanet
4d768252f0 feat(@vates/json-hash): 0.2.0 2024-08-05 17:56:58 +02:00
Dan Pollak
f0f5cdba72 fix(docs,xo-web): trials are now 30 days (#7896) 2024-08-05 17:38:55 +02:00
Julien Fontanet
8cc3d0cbaf feat(json-hash): use base64url instead of base64 2024-08-05 17:12:09 +02:00
Julien Fontanet
3284021964 fix(json-hash): strict mode and Node version
Introduced by 14325fe99
2024-08-05 14:43:28 +02:00
Julien Fontanet
e333332131 feat(@vates/json-hash): 0.1.0 2024-08-05 14:38:36 +02:00
Julien Fontanet
14325fe992 feat(json-hash): extract into own package 2024-08-05 14:37:33 +02:00
Mathieu
ddfdce9da5 feat(rest-api): add number of EOL hosts in the dashboard endpoint (#7895) 2024-08-05 10:14:01 +02:00
Dan Pollak
a2c62117a1 fix(xo-server,xo-web): optionnal → optional (#7897)
Signed-off-by: Dan Pollak <danpollak2@gmail.com>
2024-08-05 08:12:02 +02:00
Olivier Lambert
cb6cfc3a74 docs(airgap): improve the air gap doc and add our fully offline XOA s… (#7863)
docs(airgap): improve the air gap doc and add our fully offline XOA solution

Signed-off-by: Olivier Lambert <olivier.lambert@vates.fr>
2024-08-01 09:17:48 +02:00
Mathieu
9d61e0232d feat(xo-web): create a backup job schedule selector (#7804)
New UI component `SelectSchedule` that will be used for chaining backup jobs.
2024-07-31 17:31:42 +02:00
b-Nollet
fedab820f1 chore(xo-lite): updating package.json (#7892)
Introduced by #7890
2024-07-31 15:54:15 +02:00
OlivierFL
7eac1d1c5a fix(xo-6/css): wrong lang in components style tags (#7880)
The wrong CSS lang (`scss` instead of `postcss`) was used in some components.
2024-07-31 14:24:57 +02:00
b-Nollet
06a9ab6718 feat(lite): 0.2.7 (#7890) 2024-07-31 12:24:17 +02:00
b-Nollet
d0bd6562d0 feat: release 5.97.0 (#7889) 2024-07-31 11:21:44 +02:00
b-Nollet
7b60fab7ea feat: technical release (#7887) 2024-07-31 10:12:03 +02:00
Pierre Donias
045cae24fb fix(xo-web/VM/Stats): do not show guest tools warning when VM is offline (#7883)
Introduced by #7831
2024-07-31 09:51:41 +02:00
Olivier Lambert
bd7e82cb6b docs(supported hosts): update to add support on XS 8 and XCP-ng 8.3 (#7885) 2024-07-31 09:13:52 +02:00
b-Nollet
307179b142 feat: technical release (#7879) 2024-07-30 16:10:41 +02:00
b-Nollet
0a3c32f9d2 feat(backups): add reportWhen 'skipped and failure' (#7869)
Replace the "don't send reports for skipped backups" toggle by an option in "Report when"
2024-07-30 15:01:25 +02:00
OlivierFL
124d96f31a fix(xo-6): add comments in host and pool pages to fix Vite build (#7878)
The components `/host/[id]/index.vue` and `pool/[id]/index.vue` only use
`definePage()` macro.
The macro is removed during the build, leaving an empty script tag that causes
the build to fail.
This PR addresses this issue by adding a comment in the components to avoid
empty content in `<script>` tags at build time.
2024-07-30 14:57:27 +02:00
Pierre Donias
916418b6cf feat(lite): local XO Lite will try to load app from lite.xen-orchestra.com first (#7870) 2024-07-30 11:13:05 +02:00
MlssFrncJrg
7592734c9a feat(xo-web/VM/Stats): warning when guest tools are not installed (#7831)
Memory usage is not collected without guest tools. That means that the stats
graph shown in the VM page is pointless.
2024-07-30 10:20:41 +02:00
b-Nollet
b1088e2a5b fix(xo-web/backup): replace reportWhen raw value with message (#7876)
Replace `reportWhen`'s raw value by a message (e.g. *never* is replaced by the
`reportWhenNever` message, which is *Never*)
2024-07-30 09:49:53 +02:00
Mathieu
83715bedc6 fix(xo-web/VM/new): use new secureboot API (#7874)
Fixes #7500
2024-07-29 17:48:41 +02:00
Mathieu
e30f289073 feat(xo-server/xo-web/host): display 2CRSi informations in general tab (#7838) 2024-07-29 17:33:32 +02:00
OlivierFL
0977542dbd fix(web-core/novnc): add custom declaration file to fix type-check error (#7875)
See #7824
See 287f38cfd2/types/novnc-core
See https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70022

The types definitions in DefinitelyTyped/NoVnc are outdated and don’t reflect
the changes made in the NoVnc package.
This causes an error when running `yarn type-check`.

While waiting for https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70022
to be merged, a temporary workaround is to add a custom `novnc.d.ts` (moved from
`lite/src/types/novnc.d.ts`) declaration file in `web-core` to fix the
`type-check` error.
2024-07-29 16:49:37 +02:00
MlssFrncJrg
c9699c8f02 feat(xo-web/VM): display accurate Secure Boot status (#7751) 2024-07-29 14:12:27 +02:00
Thierry Goettelmann
636c88539f feat(web-core): new useItemCounter composable (#7868) 2024-07-26 13:51:01 +02:00
Paloma
333012bd29 feat(xo-web): add host status to xo6 dashboard (#7799) 2024-07-26 11:09:15 +02:00
OlivierFL
8fd516040b feat(xo-6/host): add VMs table list view (#7851) 2024-07-26 10:49:45 +02:00
Paloma
2017ec26ad feat(xo-web): add vms status for xo6 dashboard (#7795) 2024-07-26 10:33:39 +02:00
Thierry Goettelmann
72d6da38c5 feat(web-core): update heroes + add stories (#7866)
- `StateHero`, `LoadingHero` and `ComingSoonHero` can now be used inside a card by passing `type="card"` or inside a page by passing `type="page"`
- `LoadingHero` has now a `disabled?: boolean` prop and can now take a slot which will be displayed when `disabled` is `true`
- Added stories for `StateHero`, `ComingSoonHero`, `ObjectNotFoundHero` and `LoadingHero`
2024-07-26 10:01:20 +02:00
Paloma
59784315a8 feat(xo-core): add donut with legends ui component (#7829) 2024-07-26 09:00:29 +02:00
Mathieu
c5f6bf574f fix(xo-web/SR): remove newSrExistingSr modal for NFS SR (#7865)
Introduced by 659c735
See https://xcp-ng.org/forum/topic/9425
2024-07-25 17:45:50 +02:00
Jonas
991b4641ae docs(installation): add systemd service (#7848) 2024-07-25 15:53:07 +02:00
b-Nollet
0fee31b345 feat: technical release (#7864) 2024-07-25 15:35:03 +02:00
ventra007
d58ee9611f docs(backups): grammar fixes in the Concurrency section (#7859) 2024-07-25 15:08:27 +02:00
Julien Fontanet
da9d796d3f Revert "fix(xo-web/host/advanced): fix netdata link"
This reverts commit b393d72eb9.
2024-07-25 14:31:15 +02:00
Pierre Donias
e4c66bc0e8 fix(CHANGELOG): missing package to release (#7862)
Introduced by #7776
2024-07-25 14:09:29 +02:00
mathieu
d61429852d fix(xo-server-backup-reports/metadata): fix task.tasks is not iterable 2024-07-25 13:59:27 +02:00
Pizzosaure
a06e78c77c feat(xo-web/backup): add 'report recipients' when creating a metadata backup 2024-07-25 13:59:27 +02:00
Julien Fontanet
e66bdda6a1 feat(mixins/Tasks): buffer task events (#7841)
Fixes zammad#26718
Fixes zammad#26778
Fixes zammad#26865
Fixes zammad#26885
Fixes zammad#26980
Fixes zammad#27205
Fixes https://xcp-ng.org/forum/post/79281
Fixes https://xcp-ng.org/forum/post/80010
2024-07-25 12:41:41 +02:00
Mathieu
659c735b70 feat(xo-web/SR): add confirmation modal before SR creation (#7845) 2024-07-25 11:25:06 +02:00
OlivierFL
35c6248251 feat(xo-6/tree-view): improve indentation of empty items (#7861) 2024-07-25 10:46:03 +02:00
Thierry Goettelmann
4344e1567c fix(web-6/tree-view): issue with item without children (#7860)
- Remove the responsibility to exclude branches with no children from `branch.ts`
- `PoolTreeItem` and `HostTreeItem` no longer create a sublist if they have no children
2024-07-25 09:59:25 +02:00
Florent Beauchamp
2291505865 test(nbd-client): testing half succeeding multi nbd 2024-07-24 17:23:47 +02:00
Florent Beauchamp
92acd16779 feat(backups): improve error message when CBT backups aren't possible 2024-07-24 17:23:47 +02:00
Florent Beauchamp
3c5307cd64 feat(nbd-client): filter out unreachable hosts 2024-07-24 17:23:47 +02:00
Florent Beauchamp
f55ffc7d06 fix(backups): NBD backups must respect default backup network 2024-07-24 17:23:47 +02:00
Florent Beauchamp
6c118e6af5 fix(backups): incorrect assert check 2024-07-24 16:50:57 +02:00
Florent Beauchamp
d0984a7cb4 fix(backups): remove snapshot data only after the transfer is finished
* _removeUnusedSnapshots is called before and after the backup
* in some case it can delete the snapshot data before the transfer is done
2024-07-24 16:50:57 +02:00
Florent BEAUCHAMP
76336fa422 fix(xo-server): VHD is a disposable (#7856)
Introduced by 24d584e905
2024-07-24 16:44:14 +02:00
Julien Fontanet
2a9f5bcf53 fix(CHANGELOG.unreleased): add missing xen-api
Introduced by 79690fcdf
2024-07-24 16:39:31 +02:00
Julien Fontanet
9d3ec46086 feat(xo-server/self service): admins alway bypass quotas (#7855)
Fixes Zammad#27050
Fixes https://team.vates.fr/vates/pl/jb5xsh3bijf17fjokq3uczg4bo
2024-07-24 16:21:33 +02:00
Julien Fontanet
79690fcdfa feat(xen-api): cache support for call & callAsync (#7853)
* cache support for call & callAsync
* composite key is based on hashed JSON of function call arguments
2024-07-24 15:56:53 +02:00
b-Nollet
23e42c1764 feat: technical release (#7857) 2024-07-24 15:05:17 +02:00
Julien Fontanet
4b8f7146f6 feat: use new deploy page URL 2024-07-24 10:48:16 +02:00
Julien Fontanet
8172a327e4 fix(xo-web/HomeTags): strict tag filtering
Fixes https://team.vates.fr/vates/pl/776boet4qty55jkt4srabaz4hc

Exact match and respect letter case.
2024-07-23 22:28:41 +02:00
Pierre Donias
919d215b64 fix(xo-web/VM): properly identify self user to hide unauthorized actions (#7854) 2024-07-23 17:07:07 +02:00
b-Nollet
161169f295 feat(backups): option to not send reports for skipped runs (#7832) 2024-07-23 14:45:11 +02:00
b-Nollet
e91b7f8571 feat(xo-server-backup-reports): include info (#7815)
Show info of backup tasks in MJML template, for example show when NBD is used.

Currently it only displays a the message associated with the info, not its data (unlike e44933e2f7/packages/xo-web/src/xo-app/logs/backup-ng/log-alert-body.js (L131-L159)). It would be possible to display the info data, but it would probably not be done in a clean way in the current template (and I'm not sure it would be that useful).

From https://xcp-ng.org/forum/post/79833
2024-07-23 12:06:22 +02:00
OlivierFL
60291e317c feat(xo-6/pool): add hosts and VMs table list views (#7842) 2024-07-22 17:46:45 +02:00
OlivierFL
c704f156fc fix(xo-6/xo-lite): tree-view vertical line display (#7847)
Introduced by fe1f5cb

The `TreeItemLabel` component `expanded` property wasn’t handled correctly when displaying the last item of a sublist.
2024-07-22 17:42:41 +02:00
Thierry Goettelmann
9a811d7f1e feat(web-stack): upgrade Vue Router to 4.4 (#7850)
- Upgrade `vue-router` to `4.4` and `unplugin-vue-router` to `0.10`
- Disable `no-undef` ESLint rule since it's already handled by TypeScript ESLint
2024-07-22 17:01:04 +02:00
OlivierFL
a97d55c53c feat(xo-stack): add text-ellipsis utility class (#7843) 2024-07-22 16:31:44 +02:00
Julien Fontanet
8542b83f7c fix(xen-api/cli): use @xen-orchestra/log
Follows 0702454fa
2024-07-22 15:12:47 +02:00
Pierre Donias
73755c0e8c feat(lite/XoaButton): support xo-server's setting http.publicUrl (#7849)
See https://xcp-ng.org/forum/topic/9392

`xo-server` has a config setting `http.publicUrl` that allows the user to force
XO to report a custom URL in the pool's other_config (along with the
`networkInterfaces` fallback). With this change, the "Access XOA" button in
XO Lite will open that URL if it exists and fallback to `networkInterfaces`
otherwise.
2024-07-22 11:10:34 +02:00
Julien Fontanet
0702454fa8 feat(xen-api): use @xen-orchestra/log 2024-07-19 16:05:16 +02:00
Jonas
a0c3920d00 docs(users): SAML instructions for use with Google Workspace (#7846)
This shows a working example of how to connect XO SAML-plugin with Google Workspace SAML.

It's a rough example, with simple screenshots. And I've mentioned the caveat that a successfull authentication points the user to the login screen. Needing to browse into the bare URL, for access into the dahsboard. But at least it works!
2024-07-19 09:55:59 +02:00
Florent BEAUCHAMP
d4637e3335 fix(vmware-explorer): handling disks without storage (#7840)
Some VM may have disks without any storage declared. Since we
didn't find the cause, this PR ensure we don't break the VM listing.

Fixes zammad#26677
2024-07-18 16:35:06 +02:00
Jonas
6fcb838b70 feat(xo-web/i18n): add Swedish translation (#7844) 2024-07-18 10:17:30 +02:00
Julien Fontanet
065c44cc92 feat(xapi/parseDateTime): support timezones
Fixes https://team.vates.fr/vates/pl/ifht7eyhiffhtyxwywxsqwonma

`host.get_server_localtime` will include timezones in the near future.
2024-07-17 11:45:42 +02:00
Mathieu
b539b5f5e3 fix(xo-web/VM/Advanced): fix 'not enough permission' error for super admins when attaching PCIs (#7793) 2024-07-16 17:11:50 +02:00
Thierry Goettelmann
d1ce35f20a feat(web): add task store + tasks quick view (#7813) 2024-07-16 16:45:08 +02:00
Thierry Goettelmann
3f754fdc05 feat(web-core): tasks quick view (#7812) 2024-07-16 16:41:27 +02:00
Thierry Goettelmann
57d2d301ae feat(web): add polling option to xo store config builder (#7809)
This is a temporary solution. A better implementation will follow.
2024-07-16 11:12:51 +02:00
OlivierFL
d2507025a9 feat(xo-core): add HeadBar component (#7806) 2024-07-16 10:43:45 +02:00
OlivierFL
de934ec609 feat(xo-core): add CellText component (#7801) 2024-07-15 16:24:12 +02:00
OlivierFL
6894841038 feat(xo-core): add CellObject component (#7798) 2024-07-15 16:05:27 +02:00
John P. Cooper
c5e4f05d3b feat(xo-6): Initial PWA manifest for Xen Orchestra 6 (#7445)
* Update index.html

Rebased on latest commits.

* Create manifest.webmanifest

The initial PWA web manifest but rebased for latest commits.

* Update CHANGELOG.unreleased.md

Rebased on the latest commits as the conflicts were too major.

* Update CHANGELOG.unreleased.md

* Update CHANGELOG.unreleased.md

* Make URLs relative and remove changelog entry

---------

Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
2024-07-15 15:28:33 +02:00
OlivierFL
dad3dc5926 feat(xo-core): add ObjectLink component (#7794) 2024-07-15 15:24:24 +02:00
Thierry Goettelmann
3fe46cae64 feat(web): fix dev token (#7779) 2024-07-15 14:58:41 +02:00
OlivierFL
14c5d2c4ec feat(xo-core): add SearchBar component (#7726) 2024-07-15 14:57:23 +02:00
Mathieu
4a4122b9a6 feat(xo-server/xo-web/VM_coalesceLeaf): implement Coalesce Leaf (#7810) 2024-07-15 11:26:34 +02:00
Dan Pollak
acffdbec8f fix(xo-server/rest-api): add dashboard endpoint to index (#7835)
Signed-off-by: Dan Pollak <danpollak2@gmail.com>
2024-07-15 11:11:28 +02:00
OlivierFL
f9220cd272 fix(xo-core/eslint/i18n): add "fa" to the list of excluded locales for missing keys checks (#7833)
Introduced by 28f94b3

Fix ESLint errors for missing `fa` locale translation keys.
2024-07-12 14:33:53 +02:00
Julien Fontanet
518b0f77bd fix(eslint): restrict require-atomic-updates to limit number of warnings 2024-07-12 12:07:40 +02:00
Mathieu
b35a5cffa6 feat(xo-server/rest-api): implement dashboard endpoint (#7823) 2024-07-11 10:30:49 +02:00
OlivierFL
bb88834fcd fix(xo-core/xo-lite): update NoVncClient import (#7824)
Introduced by e44933e

b35cf6dd12 has resulted in a change to the import path of `NoVncClient` in `web-core` and `XO Lite` console components.
2024-07-10 15:16:42 +02:00
Julien Fontanet
e492be3a67 feat(CHANGELOG.unreleased): add Security section for future releases
Related to zammad#26875
2024-07-09 18:00:27 +02:00
Julien Fontanet
a223207ff3 docs(configuration/redis): replace incorrect info
Fixes zammad#26893
2024-07-09 17:26:06 +02:00
OlivierFL
4d42f86b2c fix(xo-6/header): make XO5 link work (#7719) 2024-07-09 14:56:43 +02:00
Julien Fontanet
da3aa59781 docs(xoa): extraneous → secondary 2024-07-09 13:22:43 +02:00
Julien Fontanet
2b46e6cf30 docs(xoa): extraneous IP addresses 2024-07-09 13:12:13 +02:00
Julien Fontanet
9406d20672 docs(xoa): show CIDR syntax for xoa network static 2024-07-09 13:12:13 +02:00
Pierre Donias
0e6d3ae27a chore(xo-web/i18n): update russian locale 2024-07-09 11:01:53 +02:00
a.anushko@spbu.ru
ee3bc185da fix(xo-web/i18n/ru): fix typos, remove wrong translations, add translations 2024-07-09 11:01:53 +02:00
Jokar-xen
28f94b3888 feat(xo-web,web-core,lite/i18n): add Persian (#7775) 2024-07-09 10:27:57 +02:00
Julien Fontanet
e44933e2f7 chore: update dev deps 2024-07-08 14:41:20 +02:00
MlssFrncJrg
30dd89243f feat(XO6): create link reusable helper (#7681)
Add helper to handle external links
2024-07-08 11:25:02 +02:00
Julien Fontanet
96b7673e27 feat: release 5.96.0 2024-07-05 17:28:52 +02:00
Julien Fontanet
69a312a0c4 feat(xo-server): 5.148.2 2024-07-05 16:57:19 +02:00
Julien Fontanet
a0e6c8b115 feat(@xen-orchestra/proxy): 0.28.8 2024-07-05 16:57:14 +02:00
Julien Fontanet
dc047d47ea feat(@xen-orchestra/xapi): 7.1.1 2024-07-05 16:56:55 +02:00
Julien Fontanet
a00b24f6b8 fix(xapi/VM_snapshot): destroy snapshot VDIs instead of original ones
Fixes https://xcp-ng.org/forum/post/79769

This code, only used for running VMs, triggered `VDI_IN_USE` errors and left the
created VM snapshot with all the VDIs.
2024-07-05 16:44:58 +02:00
Julien Fontanet
7601dee7f2 fix(xapi/VM_snapshot): log original error when failing to destroy a ignored VDI 2024-07-05 16:41:42 +02:00
Julien Fontanet
1ace3cbbe8 feat(@xen-orchestra/proxy): 0.28.7 2024-07-05 11:16:32 +02:00
Julien Fontanet
8651e61210 feat(xo-server): 5.148.1 2024-07-05 10:46:58 +02:00
Julien Fontanet
6c6b6b9fa1 feat(@xen-orchestra/backups): 0.52.1 2024-07-05 10:46:49 +02:00
Julien Fontanet
6374e0d3f5 feat(@xen-orchestra/xapi): 7.1.0 2024-07-05 10:38:02 +02:00
Julien Fontanet
664d4b1af6 feat(backups/worker): forced exit after 30s 2024-07-05 10:32:08 +02:00
Julien Fontanet
0117e9dbc8 chore(mixins/Tasks): don't duplicate log deletion logic 2024-07-04 17:44:39 +02:00
Julien Fontanet
174e32173f fix(xo-server/sr.getAllUnhealthyVdiChainsLength): lodash.throttle instead of debounceWithKey
`debounceWithKey` should not be used because the API method will always be called with a different
empty object as param which will render the cache useless.

Fortunately `lodash.throttle` can be used here as `sr.getAllUnhealthyVdiChainsLength` is synchronous
and has no meaningful parameter.
2024-07-04 17:43:07 +02:00
Mathieu
0e4a300058 feat: technical release (#7808) 2024-07-04 16:42:52 +02:00
Florent Beauchamp
76b54ec579 feat(backups): expose setting to purge snapshot data
* when using CBT backup, no rolling snapshot and NBD
* this will delete the snapshot data , thus limiting the pressure on the SR
* snapshot won't be listed in the UI
* snapshot won't be usable to revert a VM
2024-07-04 16:24:25 +02:00
Florent BEAUCHAMP
7b256ab8ee feat(backups): enable Change Block Tracking Backups (#7750)
Enable CBT for all backups

* enable cbt each time a VM should be backuped by nbd
* if there are no rolling snapshot on a job =>
the snapshots data are only kept during the transfer.
Snapshot data deletion is behing a config flag 'purgeSnapshotData' (default false )

adverse effect:

* rolling back to previous XO version will make full backups
* removed read ahead in nbd , performance gain was low with concurrency
and it make code more complex
2024-07-04 16:24:25 +02:00
Florent Beauchamp
7a2bb5104c fix(backups): Cannot destructure property 'other_config' of 'undefined'
introduced by a85f44d699
2024-07-04 16:24:25 +02:00
Florent Beauchamp
56c881fd2a fix(backups): ensure vhd stream are exactly the right length 2024-07-04 16:24:25 +02:00
Florent Beauchamp
db89485efe fix(backups): fix a off by one error on delta chain length 2024-07-04 16:24:25 +02:00
Julien Fontanet
3c6a7a9575 feat(xo-server/rest-api): expose servers 2024-07-04 15:52:48 +02:00
Julien Fontanet
992d636bcd feat(xo-server/rest-api): expose a VM's VDIs 2024-07-03 15:41:59 +02:00
Mathieu
253aac4eaa feat(xo-web/SR/XOSTOR): add state column to the resource list table (#7784) 2024-06-28 16:25:56 +02:00
Mathieu
ea551a5175 chore(xo-web/SR/XOSTOR): remove unused import (#7785)
Introduced by 1ab62d4
2024-06-28 16:19:47 +02:00
OlivierFL
fe1f5cbad7 feat(xo-6/tree-view): add simple search (#7780) 2024-06-28 15:05:56 +02:00
OlivierFL
ce4c2e17af feat(xo-core): add UiInput component (#7724) 2024-06-28 14:52:29 +02:00
Mathieu
e5608680ec feat: technical release (#7787) 2024-06-28 09:49:00 +02:00
Julien Fontanet
6ee7a274d9 Revert "feat(backups): enable Change Block Tracking Backups (#7750)"
This reverts commit 2db21d3086.
2024-06-27 23:00:22 +02:00
b-Nollet
ffc93250f0 feat(xo-server): add progress to RPU and RPR XO-task (#7768) 2024-06-27 22:01:41 +02:00
b-Nollet
52b27ae884 fix(backups): fix delete first on incremental replication (#7739) 2024-06-27 21:39:20 +02:00
b-Nollet
f5cee45c02 feat(backup-reports): mjml template (#7747) 2024-06-27 21:36:59 +02:00
Julien Fontanet
818a5b7f5b fix(xapi/VM_snapshot): sets ignoreVbds to undefined
Introduced by 37a0d9da7

Fixes https://xcp-ng.org/forum/post/79317
2024-06-27 18:23:40 +02:00
Julien Fontanet
19a2f4e002 fix(xapi/VDI_export): destroy NBD task after export
Introduced by 2db21d308

Fixes https://xcp-ng.org/forum/post/79129
2024-06-27 18:20:42 +02:00
Mathieu
83920589db fix(xo-server-sdn-controller): install CA certificate on pools after plugin config update (#7755) 2024-06-27 17:25:48 +02:00
MlssFrncJrg
bc1db9960a fix(xo-web): correct link for the pool secure boot setup (#7783) 2024-06-27 16:54:56 +02:00
Julien Fontanet
5bf1aea761 fix(xo-server/test.createTask): various fixes
Initialize progress and correctly update name
2024-06-27 16:20:26 +02:00
Julien Fontanet
dcf6885dfa feat(xo-server): support [NOSNAP] tag on disks
Fixes https://xcp-ng.org/forum/post/79179
2024-06-27 15:37:56 +02:00
Julien Fontanet
37a0d9da7c feat(xapi/VM_snapshot): ignoredNoBakVdis → ignoredVdisTag
This new param is more flexible and permits the use of other tags.
2024-06-27 15:24:19 +02:00
Mathieu
abcbeb8719 feat: technical release (#7781) 2024-06-27 10:01:22 +02:00
Thierry Goettelmann
8db808a415 feat(web-stack): better layout system (#7777)
- `[core]` Created a StateHero component
  - `[core]` Created a `ComingSoonHero` component
  - `[core]` Created a `LoadingHero` component
  - `[core]` Created an `ObjectNotFound` component
- `[core;lite]` Moved `object-not-found` translation from Lite to Core
- `[core]` Updated `CoreLayout` to remove panel-related code
- `[web]` Renamed `DefaultLayout` to `AppLayout`
- `[web]` Wrap `RouterView` with `AppLayout` in `App.vue`
- `[web]` Removed all slots from `App.vue` but `default` one
- `[web]` Created `web/pages/vm/[id].vue` which handle layout around all `/vm/*` pages
2024-06-27 09:22:22 +02:00
Julien Fontanet
9383306231 fix(xo-server/rest-api): remove incorrect comma operator
Introduced by 800655a9a

Fortunately this did not have any impact.
2024-06-26 14:07:54 +02:00
Julien Fontanet
3235963cfb fix(xo-web/host/advanced): use relative path
This is required to avoid breaking reverse proxies with a preppended path.
2024-06-25 16:40:33 +02:00
Julien Fontanet
b393d72eb9 fix(xo-web/host/advanced): fix netdata link
Fixes #7702
2024-06-25 16:14:35 +02:00
Julien Fontanet
cd2942af71 chore(xo-server-netbox): unify unload handling 2024-06-25 09:03:26 +02:00
Julien Fontanet
e92cb66954 chore(xo-server-netbox/configure): use state.loaded 2024-06-25 09:03:26 +02:00
Pierre Donias
dac0b20a19 fix(xo-server-auth-ldap): do not use syntax "key=value" when key is "DN" (#7759)
See Zammad#25659
2024-06-24 17:19:29 +02:00
Julien Fontanet
0fc5d60791 feat(scripts/normalize-packages): licenses default to ISC for @vates/ 2024-06-24 17:12:17 +02:00
Julien Fontanet
2df144d43d feat(scripts/new-pkg): create a new package in the monorepo 2024-06-24 17:12:17 +02:00
Mathieu
758e3c47b8 fix(xo-web/VM/advanced): fix 'firmware not supported' for UEFI (#7767)
Introduced by 68e99a2
See https://xcp-ng.org/forum/topic/8878/uefi-firmware-not-supported
2024-06-24 14:58:23 +02:00
Mathieu
cfcc78b6d8 feat(xo-web/XOSTOR): column that links to SR (#7764) 2024-06-24 14:38:11 +02:00
Julien Fontanet
5f5580925d docs(xen-api): more CLI examples 2024-06-24 11:29:38 +02:00
Mathieu
a667e7cdbd fix(xo-web/XOSTOR): fix approximate SR capacity (#7765)
Introduced by 038d230
2024-06-24 10:53:45 +02:00
b-Nollet
a14c4bbb1c feat(xo-server/rest-api): add rolling pool reboot action (#7761) 2024-06-21 15:46:37 +02:00
Florent BEAUCHAMP
2db21d3086 feat(backups): enable Change Block Tracking Backups (#7750)
Enable CBT for all backups

* enable cbt each time a VM should be backuped by nbd
* if there are no rolling snapshot on a job => the snapshots data are only kept during the transfer. Snapshot data deletion is behing a config flag 'purgeSnapshotData' (default false )

adverse effect:

* rolling back to previous XO version will make full backups
* removed read ahead in nbd , performance gain was low with concurrency and it make code more complex
2024-06-21 11:32:37 +02:00
MlssFrncJrg
6b1036f5ce feat(xo-web): display SCSI id during creation of SR (#7742) 2024-06-21 10:59:31 +02:00
Florent BEAUCHAMP
5cc6b4fe70 feat(xo-web): add CBT to the disk tab (#7732)
show a toggle to enable CBT from the VM disk tab 

---------

Co-authored-by: Mathieu <70369997+MathieuRA@users.noreply.github.com>
2024-06-21 10:36:20 +02:00
Florent BEAUCHAMP
442dd16813 feat(xo-server): disable cbt on vdi/VM/host migration (#7756)
Change Block Tracking (CBT) is blocking VDI migration from one storage to another
The migration errror is computed at the VM level on the xapi, that mean that we need to disable CBT for any disk of the VM that use a VDI
We don't enable CBT after the migration : any client / backup software that need this will need to enable it on demand, and a migration force a full transfer
 host.evacuate don't move the vdi ,it can't generate a VDI_CBT_ENABLED error
2024-06-21 10:23:41 +02:00
Mathieu
6e000af7cb fix(xo-server/XOSTOR): remove callAsync workaround (#7723) 2024-06-21 09:50:17 +02:00
Julien Fontanet
3c13e0ab43 fix(CHANGELOG): move latest badge
Introduced by 7b8a4e720
2024-06-20 17:18:03 +02:00
Julien Fontanet
7b8a4e7209 feat: release 5.95.1 2024-06-20 17:16:26 +02:00
Pierre Donias
c63d2ab00b fix(netbox): force xo-server to use at least http-request-plus@1.0.3 (#7758)
See Zammad#24458

`xo-server-netbox` uses `response.text` which has been added in
http-request-plus@1.0.3. Therefore, the dependency version in `xo-server` needs
to be `^1.0.3` to ensure that `response.text` can be used.
2024-06-20 17:02:20 +02:00
Florent BEAUCHAMP
ba7a29eb5e docs(backups): nbd concurrency and full on migrate (#7741) 2024-06-20 15:36:23 +02:00
Paloma
304b06ca97 feat(xo-core): add card subtitle ui component (#7731) 2024-06-20 15:13:04 +02:00
Julien Fontanet
0661fbae78 feat(xo-server): 5.145.0 2024-06-20 15:08:00 +02:00
Julien Fontanet
16ae1c0d4b fix(lite/stories/card-title): fix imports order
Introduced by 9c29046a8
2024-06-20 14:38:46 +02:00
Paloma
9c29046a88 feat(xo-core): add card title component to web core (#7721) 2024-06-20 11:41:20 +02:00
Julien Fontanet
bb0fd2898e fix(xo-server/rest-api): handle collection without getObject
For instance `/backup/vms` would trigger an *Internal Error*, now it correctly returns 404.
2024-06-20 11:27:14 +02:00
Thierry Goettelmann
276d920cca feat(web-stack): add new i18n guidelines + ESLint + update and fixes (#7753)
- Add new i18n guidelines
- Remove nested keys: `"foo": { "bar": "..." }` ➡️ `"foo.bar": "..."`
  This makes code cleaner (and as a side-effect, it now allows to use `foo` + `foo.bar` keys)
- Lite/6 shared translations are no longer prefixed with `core.`
- Duplicated keys across translation files are no longer accepted.
  This will prevent accidental overwrite of missing common translations
- `fr.json` and `en.json` now required to contains the same keys
- Raw text is no longer accepted in template to prevent forgetting a translation
  Raw text is still accepted in dev-related files (stories, dev pages...)
- Remove useless `alt` on `img`
- Display of percentage now uses `$n(value, 'percent')`
- Removed legacy `lite/src/i18n.ts`
- Add missing translations
- Added visual indicator for missing translations while in dev env: `🌎❗⟨i-am-missing⟩`
2024-06-20 09:35:36 +02:00
Thierry Goettelmann
dd8ad3f274 chore(web stack): add new ESLint Vue rules #6 (#7738)
Enforces import order via the `import/order` ESLint rule
2024-06-20 09:18:15 +02:00
Florent BEAUCHAMP
7ddd579818 fix(backups): EEXIST error when restarting mirror backup (#7694)
feat(backup): remove temporary VHD before backups run

- cleanVm can only delete files when backup job is successful
- an interrupted transfer leave the temp file in place
- the temp file don't change name in a mirror backup since we transfer exactly the same file
- outputStream method use, by default, a flag that create the file if not exists and fail otherwise
    => EEXIST error

- This PR change the behaviour of cleanVM to delete temporary files on the pass before the transfer, thus removing any dot file

---------

Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
2024-06-20 08:24:48 +02:00
Paloma
290f510843 feat(xo-core): add card ui component (#7710)
This component can contain other components and manage their layout.
It can align elements vertically or horizontally.
2024-06-19 11:47:34 +02:00
OlivierFL
c134bbaee3 fix(lite/Dashboard): add missing translations and remove hardcoded values (#7744) 2024-06-18 09:42:27 +02:00
Thierry Goettelmann
e1dd5354a1 chore(web stack): add new ESLint Vue rules #5 (#7736) 2024-06-17 16:56:47 +02:00
Thierry Goettelmann
070258d0e3 chore(web stack): add new ESLint Vue rules #4 (#7734) 2024-06-17 16:48:06 +02:00
Julien Fontanet
f5a49b6da3 fix(xo-server/_xcpUpdate): callAsync result is already parsed
Fixes zammad#26054

Introduced by 08dc33bc9
2024-06-17 10:55:39 +02:00
Florent BEAUCHAMP
a85f44d699 Refactor(backups): move metadata to VDI (#7648)
Preparing for CBT backup that will only keep a part of the VDI snapshot, and remove the VM

* extract most of the other_config operation to a file as constants/methods
* name the constants
* set the relevant metadata values to the vm AND all its attached VDIs
* use the VDI as the base to search and update snapshots/replica/backup
2024-06-17 09:19:46 +02:00
Julien Fontanet
31461118e0 chore: update to turbo@2 2024-06-14 11:43:38 +02:00
Thierry Goettelmann
306a58e412 fix: missing routes in typed-router.d.ts + ignore it from Prettier (#7746) 2024-06-14 10:10:33 +02:00
Julien Fontanet
32448cfa1b feat(task): info, set and warning are now instance methods
Info, properties and warnings should be set on a specific/known task instead of relying on the async context.

For instance, this permits updating the progress of a task from the code on one of its subtasks.
2024-06-13 17:34:34 +02:00
Julien Fontanet
3dde723e31 feat(xo-server/api): no tasks for ignored methods
Follows 33a388193
2024-06-13 16:21:17 +02:00
Julien Fontanet
be5a523b95 feat(xo-server-transport-email): sendEmail() now accepts HTML 2024-06-13 14:56:28 +02:00
Thierry Goettelmann
ad18a860f3 chore(web stack): add new ESLint Vue rules #3 (#7729)
Add `vue/define-macros-order` ESLint rules to ensure consistency across components.

Macros will require to be defined in the following order:
1. `defineOptions`
2. `defineProps`
3. `defineEmits`
4. `defineModel`
5. `defineSlots`

Also ensures `defineExpose` to be the last statement of `<script setup>`
2024-06-13 14:06:26 +02:00
Julien Fontanet
be2efce595 fix(xo-server-transport-email): set text to markdown even if html is defined 2024-06-13 11:23:08 +02:00
Pierre Donias
4295dad3ac fix(web-core): devDependencies → dependencies + peerDependencies (#7707)
web-core is published as a library so its dependencies need to be installed
when web installs its own dependencies

- packages that are (or will be) used by lite and web are declared as
  dependencies in lite and web and as peerDependencies in web-core
- other packages that are only used in web-core are declared as dependencies in
  web-core
2024-06-13 10:42:24 +02:00
Julien Fontanet
cdf902bdf3 chore(.prettierignore): explain why Handlebar is ignored
Introduced by 3f4ca1b32
2024-06-12 15:45:00 +02:00
Thierry Goettelmann
97dd211d0f fix: prettify script must respect .prettierignore (#7745)
Specifying `--ignore-path` option overrides the default value of `[.gitignore, .prettierignore]`.
2024-06-12 15:43:54 +02:00
Paloma
0f11e4c4c4 feat(web-core): add UI separator component (#7722)
This component is a grey line (hr). When its parent is a flexbox with
`flex-direction: column`, it is horizontal, and with `flex-direction: row`,  it
is vertical.
2024-06-12 09:49:55 +02:00
Julien Fontanet
33a388193c feat(xo-server/api): pending/failed calls have an associated tasks 2024-06-11 10:36:29 +02:00
MlssFrncJrg
bed18fc954 feat: open external links in a new tab (#7695) 2024-06-11 10:20:46 +02:00
Thierry Goettelmann
1d8385e1f0 chore(web stack): add new ESLint Vue rules #2 (#7728)
Add `vue/define-emits-declaration` ESLint rule to ensure consistency in `defineEmits` syntax across the components.

It uses the new Vue 3.3+ more succinct syntax.
2024-06-11 09:12:41 +02:00
Thierry Goettelmann
11fbbf5158 chore(web stack): add new ESLint Vue rules (#7727) 2024-06-10 16:54:23 +02:00
Olivier Lambert
209dddda2b docs(roadmap): update our roadmap page (#7709) 2024-06-10 12:54:51 +02:00
Julien Fontanet
7f0984aff0 feat(xo-server/proxy.updateApplianceSettings): support for register and xoaPassword 2024-06-10 10:56:04 +02:00
Julien Fontanet
3f32f9981e chore(xo-server/updateProxyAppliance): simplify code 2024-06-10 10:56:04 +02:00
OlivierFL
faf54e18a8 feat(lite/web-core): add examples for tree-view components stories (#7532) 2024-06-10 09:56:45 +02:00
Pierre Donias
f70f4ea0e6 feat(netbox): support both content_type (Netbox <4) and object_type (Netbox 4) fields
Fixes #7645
See Zammad#24458
See Zammad#25690
See Zammad#24821
See #7733
2024-06-10 09:50:38 +02:00
Pierre Donias
c346cadf24 feat(netbox): explicit supported Netbox versions 2024-06-10 09:50:38 +02:00
Dan Pollak
00c8f37e73 docs: Storage Management (#7674) 2024-06-10 09:02:27 +02:00
Dan Pollak
ee6fa67246 docs: continous → continuous (#7466) 2024-06-07 13:10:25 +02:00
Julien Fontanet
691f36a223 fix(proxy-cli): timeout with long calls
Similar to 29d39a576
2024-06-06 16:38:55 +02:00
Julien Fontanet
3c41d612d0 feat(xo-web/proxies): refresh upgrade status every 30s 2024-06-06 13:58:09 +02:00
Julien Fontanet
0294c3dd68 fix(xo-web/proxies): fetch upgrades even if fetching licenses failed 2024-06-06 13:57:30 +02:00
Dan Pollak
6c25d9e147 docs(incremental_backups): fix XO 5.81 blogpost link (#7725) 2024-06-05 23:07:45 +02:00
Florent BEAUCHAMP
58cc1de804 fix(vmxware-explorer): vsan detection (#7717)
Fixes zammad#25110

Introduced by 2d07fdcd02
2024-06-05 16:37:35 +02:00
b-Nollet
3f4ca1b322 feat(backup-reports): rewrite with Handlebars (#7543) 2024-06-05 15:47:06 +02:00
Julien Fontanet
99e44fe139 chore(xo-web): rename proxyApplianceUpdaterState
The subscription is for a single proxy, not all of them.
2024-06-05 09:22:53 +02:00
Julien Fontanet
b87bc29f0e fix(fuse-vhd): handle readRawData failure (#7718)
The bug may leads to blocked mount.
2024-06-04 16:33:36 +02:00
Mathieu
f6672a643f feat(XO6/core): creation of the interactive UiTable (#7677) 2024-06-03 15:53:47 +02:00
OlivierFL
2a2fe93476 fix(xo-6/tree-view): show halted VMs attached to a pool (#7683)
Introduced by 796bb60
2024-06-03 15:19:00 +02:00
Paloma
93303ca7ac feat(xo-core): add stacked bar UI component (#7676) 2024-06-03 14:28:38 +02:00
Julien Fontanet
3a211524cb docs(installation): request Node LTS
XO is no longer stuck on Node 18.
2024-06-03 10:50:40 +02:00
Paloma
1bba37adb1 feat(xo-core): add card number ui component (#7666) 2024-06-03 09:34:43 +02:00
Paloma
8c4fcc43d2 feat(xo-core): add legend UI component (#7675) 2024-06-03 09:22:56 +02:00
Paloma
e20e3526a5 feat(xo-core): add Legend title UI component (#7678) 2024-06-03 09:17:14 +02:00
Paloma
17fec5876c feat(xo-core): add multi color donut chart ui component (#7661)
SVG based donut chart
2024-06-03 09:16:47 +02:00
Pierre Donias
4cf03cf0a2 feat(lite): 0.2.3 (#7715) 2024-05-31 17:51:06 +02:00
Pierre Donias
57e44734e2 feat: release 5.95.0 (#7714) 2024-05-31 17:39:15 +02:00
Pierre Donias
3075ce9232 feat: technical release (#7713) 2024-05-31 17:22:13 +02:00
Florent BEAUCHAMP
196f3969eb fix(xo-server,vmware-explorer): template is not defined (#7712) 2024-05-31 17:09:49 +02:00
Julien Fontanet
d635de0a96 fix(scripts/gen-deps-list.js): handle dev dependencies 2024-05-31 15:59:52 +02:00
Julien Fontanet
d1e3d79bf8 feat(scripts/gen-deps-list.js): add web & lite
They are applications and must be bumped if any of their deps is bumped.
2024-05-31 15:59:52 +02:00
Pierre Donias
5adec6b2ef feat: technical release (#7708) 2024-05-31 15:59:20 +02:00
MlssFrncJrg
b2b6262aea fix(xo-server,xo-web/pci): allow force reboot host after enabling/disabling PCI passthrough (#7687)
See https://xcp-ng.org/forum/topic/9043/xo-enable-pci-devices-for-pass-through-should-it-work-already-or-not-yet/14
2024-05-31 15:16:47 +02:00
Florent BEAUCHAMP
82d3ec6033 fix(xo-server-perf-alert): improve performances and reliability (#7692)
* make one query per host instead of one per object (VM or host ) per counter ( Memory/CPU)
* fix(xo-server-perf-alert): handle VM without guest tools that does not have memory used metrics
---------

Co-authored-by: b-Nollet <150058367+b-Nollet@users.noreply.github.com>
2024-05-31 14:52:34 +02:00
OlivierFL
3dd5a6ba13 feat(xo-6/vm): add console view (#7693) 2024-05-31 14:23:24 +02:00
Pierre Donias
0215ac2491 fix(yarn.lock): after adding dependency (#7706)
Introduced by 3044a42
2024-05-31 13:43:31 +02:00
Pierre Donias
3044a429cc fix(web-core): missing dependency @fontsource/poppins (#7705) 2024-05-31 11:02:32 +02:00
Florent BEAUCHAMP
53ee6988db feat(xo-server): improve error handling in v2v (#7654)
* use one defer per Vm import
*  improve error lisibility by extracting relevant values
2024-05-31 10:05:01 +02:00
b-Nollet
89950e77f4 fix(xo-server): handle unknown ref in task.other_config.applies_to (#7685) 2024-05-31 09:20:38 +02:00
Julien Fontanet
800655a9a3 fix(xo-server/rest-api): host logs are in tar+gzip
Fixes #7703
2024-05-31 09:12:30 +02:00
Florent BEAUCHAMP
59fbb3ef48 feat(v2v): select template before import (#7566)
Ask user for the base template to use when importing VM
2024-05-31 09:06:17 +02:00
Florent BEAUCHAMP
9133e32dd0 fix(backups/forkStreamUnpipe): unpause stream after unpipe (#7669)
when a backup job does delta replication + backup and the replication
fails to find the base VM, the backup job does not proceed

This commit force the stream to continue to flow after unpiping a
descendant stream
2024-05-31 08:45:33 +02:00
b-Nollet
cb6df6d155 fix(xo-server): don't use stats that were cached exactly one step ago (#7697)
Update stats instead of using cache when cache is exactly one step old. It avoids the stats to be twice the same in a row when fetching it every step.

Introduced by 8347ac6ed8
2024-05-31 08:37:40 +02:00
b-Nollet
20f398398f feat(xo-server-load-balancer): adding option to balance hosts before CPU reaches threshold 2024-05-31 08:36:43 +02:00
b-Nollet
c4d1dee6fd fix(xo-server-load-balancer): execute vCPU-prepositionning separately for each pool 2024-05-31 08:36:43 +02:00
b-Nollet
93627a794c fix(xo-server-load-balancer): don't do vCPU-prepositionning when one host is overloaded 2024-05-31 08:36:43 +02:00
b-Nollet
bfb2442df1 fix(xo-server-load-balancer): some migrations were not awaited 2024-05-31 08:36:43 +02:00
Florent BEAUCHAMP
24d584e905 fix(xo-server): dispose stream properly after v2v import (#7655) 2024-05-31 08:18:10 +02:00
MlssFrncJrg
882facd246 feat: technical release (#7704) 2024-05-30 17:41:04 +02:00
Pierre Donias
4c37be5b31 fix(web): missing prepublishOnly script (#7701) 2024-05-30 16:04:16 +02:00
Pierre Donias
5811a2ede2 chore(web-core): configure package to be published on NPM (#7700) 2024-05-30 14:50:28 +02:00
MlssFrncJrg
8fb918a64d feat: technical release (#7699) 2024-05-30 13:15:38 +02:00
MlssFrncJrg
682198df42 feat(xo-server,xo-web/pool): add migration compression (#7642) 2024-05-29 17:27:00 +02:00
Julien Fontanet
de9288b432 docs(xo-server/REST API): ova extension for VM OVA export
Introduced by acc44f0ce
2024-05-29 17:20:04 +02:00
Julien Fontanet
42d58e9dbf feat(obfuscate): new lib to obfuscate sensitive data
Code was extracted from xo-server and xen-api.
2024-05-29 16:58:54 +02:00
Julien Fontanet
d55f614540 fix(backups): handle migration blocked by a previous run
Fixes https://xcp-ng.org/forum/post/77857
Fixes zammad#25131
Fixes zammad#25443
2024-05-29 16:54:27 +02:00
Julien Fontanet
61ecc85beb feat(xapi): no longer export extractOpaqueRef()
BREAKING CHANGE

It's no longer necessary now that task results are properly parsed.
2024-05-28 11:42:57 +02:00
Julien Fontanet
08dc33bc9d feat(xen-api/watchTask): returned parsed result instead of XML-RPC
BREAKING CHANGE

Also impacts `getResource()` and `putResource()`.
2024-05-28 11:42:57 +02:00
Pierre Donias
e23f649e74 feat(xo-web/tasks): wait 10 seconds before estimating end of task (#7691)
Fixes #7689
2024-05-28 10:27:42 +02:00
OlivierFL
f0cd83e3c4 feat(xo-6/account-menu): add menu items (links to doc and support) (#7662) 2024-05-28 09:13:23 +02:00
OlivierFL
136ea23199 feat(xo-lite): add german translation (#7686)
See #7284
2024-05-28 09:11:17 +02:00
b-Nollet
73ea4fa6b4 fix(fs,xo-server): remote encryption algorithm was private (#7638)
Encryption was not showing up in remote page because the remote mixin was using an attribute that was private. See https://help.vates.tech/#ticket/zoom/24076

Introduced by 86ddb8f2d9
2024-05-27 09:18:51 +02:00
Pierre Donias
990c23b8f5 feat(xo-web/render-xo-item/Vm): yellow icon next to VM name when VM is busy (#7680)
Fixes #7593
2024-05-23 14:24:24 +02:00
Pierre Donias
5fca2f0c74 feat(lite/header): add a link to XOA when detected on the pool (#7679)
When XOA is connected to a pool, it adds information about itself on the pool's
other_config. We can use that in XO Lite to find the XOA's IP address and add a
link to open Xen Orchestra.
2024-05-23 13:32:24 +02:00
Thierry Goettelmann
5cd9e50fa3 feat(web-core/tree): tree filter composable (#7536) 2024-05-23 09:44:00 +02:00
Paloma
18a2b5b549 feat(xo-core): add status pill UI component for backup issues (#7631) 2024-05-23 09:15:30 +02:00
Thierry Goettelmann
da9b9419ae feat(web-core/tree): enhance tree library (#7534)
- Context now stores the selected/expanded/active IDs instead of the `TreeNode` to allow easy manipulation and initial hydration.
- Rename `activable` option to `selectable`
- Rename `labelClasses` to `statuses`
- Add `hasChildren` on `Branch`
- `predicate` now takes the `TreeNode` as argument instead of `TData`
- Add a `meta` option, to pass additional arbitrary data
2024-05-22 17:07:44 +02:00
Olivier Lambert
8c599b0bad docs(advanced): fix old Terraform provider links (#7673) 2024-05-22 15:47:11 +02:00
Julien Fontanet
1ded79169b chore: format with Prettier 2024-05-22 15:42:14 +02:00
Thierry Goettelmann
bea123f347 feat(lite): update stores to use new core subscribable stores (#7602)
Update XO Lite stores to use the new subscribable store system from Web Core
2024-05-22 15:08:55 +02:00
Julien Fontanet
88fb977db9 feat(xo-cli): --url allows bypassing registration
Related to zammad#25158
2024-05-22 12:11:06 +02:00
Julien Fontanet
b48e16c316 feat(xo-cli): use subcommand syntax
This change allows to properly separate options and subcommands,
which opens the door to global options.

Previous syntax is still supported for now but will show a deprecation
message.

```sh
xo-cli --register
xo-cli --createToken

xo-cli register
xo-cli create-token
```
2024-05-22 12:10:37 +02:00
Julien Fontanet
a8ffa91d41 docs(infrastructure): update xo-cli usage 2024-05-22 12:10:16 +02:00
Mathieu
6a67944112 feat(xo-web/XOA/licenses): handle new XOSTOR licenses (#7573) 2024-05-22 11:17:43 +02:00
Mathieu
4908982263 feat(lite/pool/dashboard): remove DVDs from the Storage usage card (#7670) 2024-05-17 14:28:08 +02:00
b-Nollet
6444f88662 chore(xo-server-backup-reports): remove unused legacy handler (#7665) 2024-05-16 16:16:31 +02:00
Pierre Donias
644654c7eb feat(lite/release): add CHANGELOG.md to GitHub release (#7667) 2024-05-16 15:21:00 +02:00
Thierry Goettelmann
5629bbef05 fix(xo-6): rename dynamic pages (#7668)
Fix dynamic pages name: `/:id.vue` => `/[id].vue`
2024-05-16 14:52:52 +02:00
Mathieu
a627fe31e2 fix(XO6/LogoTextOnly): fix color (#7664) 2024-05-16 11:53:54 +02:00
Julien Fontanet
2534d9ff38 chore: update deps 2024-05-16 11:16:18 +02:00
Julien Fontanet
13863beed8 chore: update dev deps 2024-05-16 10:48:44 +02:00
Thierry Goettelmann
796bb60b62 feat(web6): subscribable stores, REST API fetching, infra tree view (#7600)
- Implement subscribable store on XO 6
- Fetch data from REST API
- Display infrastructure tree view
- Updated README
- Added dev pages:
  - **index.vue**: empty page for component development
  - **token.vue**: form to register or clear a token cookie
2024-05-16 09:57:17 +02:00
b-Nollet
7882debe7a feat: release 5.94.2 (#7660) 2024-05-15 11:07:44 +02:00
b-Nollet
548a2e8141 feat: technical release (#7659) 2024-05-15 10:15:11 +02:00
Mathieu
63f89bb6af fix(xo-server/XOSTOR): license.tags can be undefined (#7657)
Co-authored-by: mathieu <mathieura@vates-mathieu.home>
2024-05-15 09:15:46 +02:00
b-Nollet
ae1043a89a feat: technical release (#7656) 2024-05-14 16:58:52 +02:00
Julien Fontanet
c272c9ef2d fix(CHANGELOG.unreleased): add missing backups
Introduced in 7513b90c5
2024-05-14 16:42:02 +02:00
Julien Fontanet
7513b90c5c fix(backups): block migration of whole VM during backup
Related to zammad#16108

Introduced by b00cf1302
2024-05-14 15:57:27 +02:00
Julien Fontanet
ef3ade72e4 fix(xo-server/rest-api): wait for task change when wait is NOT undefined
Introduced by 6c1a1307c
2024-05-14 15:24:28 +02:00
Florent Beauchamp
152c4e69c8 changelog 2024-05-14 15:10:46 +02:00
Florent Beauchamp
60286ba0d8 fix(vmware-explorer): handle new lines in fetchProperty 2024-05-14 15:10:46 +02:00
Thierry Goettelmann
f7664b317e feat(web-core): add helper to create subscribable stores (#7599)
Add a helper which allow to easily create a subscribable store (store that return its context only after calling a subscribe method and handle what happen on subscribe/unsubscribe)

App-agnostic, to be used with XO Lite and XO 6.
2024-05-14 14:42:44 +02:00
Mathieu
89ea175de1 fix(xo-server/XOSTOR): throw clearer error if attempt to create multiple trials (#7649) 2024-05-14 14:18:15 +02:00
OlivierFL
adbae95027 feat(xo-6): handle logout (#7635) 2024-05-14 11:13:43 +02:00
OlivierFL
ffeca2a621 feat(xo-core): add design system version info in components (#7633) 2024-05-14 10:31:46 +02:00
Julien Fontanet
9d122f9e9a fix(CHANGELOG.unreleased): add missing xen-api
Introduced in 859920e6d
2024-05-13 14:58:34 +02:00
Julien Fontanet
859920e6d7 fix(xen-api/{get,put}Resource): avoid unhandled rejection on task result 2024-05-13 14:45:26 +02:00
Julien Fontanet
703d32ce7c chore(xen-api/_sessionCall): remove unused timeout param 2024-05-13 11:05:42 +02:00
Julien Fontanet
acc44f0cea feat(xo-server/rest-api): OVA support for VM export 2024-05-13 09:01:37 +02:00
b-Nollet
9b9c71a80f fix(xo-server): RPU failed to install host patches (#7640) 2024-05-09 13:04:38 +02:00
Julien Fontanet
902f0b1957 fix(xo-server/proxy-console): falling back to legacy is not a debug 2024-05-07 17:12:40 +02:00
Julien Fontanet
29f6f92ad3 fix(xo-server): console support via HTTP proxy
Introduced by e8c9e620c

Fixes https://xcp-ng.org/forum/post/76935
2024-05-07 17:12:01 +02:00
Pierre Donias
771b04acc4 fix(CHANGELOG): packages versions (#7639)
Introduced by 5d5dc9891f
2024-05-06 17:18:07 +02:00
MlssFrncJrg
d3ab7927af feat: release 5.94.1 (#7637) 2024-05-06 15:42:04 +02:00
MlssFrncJrg
5d5dc9891f feat: technical release (#7636) 2024-05-06 14:40:27 +02:00
MlssFrncJrg
1ab62d4762 feat(xo-web/xostor): ability to copy VDI UUID in the resources table (#7629) 2024-05-06 14:10:43 +02:00
MlssFrncJrg
b9a6651f88 feat(xo-web/XOSTOR): warn if replication count is higher than number of hosts with disks (#7625) 2024-05-06 11:39:25 +02:00
OlivierFL
960cf6632d feat(xo6/core): update chip component to v1.1.0 (#7632)
Update the `ChipRemoveIcon` component by replacing the `faCircleXmark` icon with
the `faXmark` icon to match version 1.1.0 from the design system.
2024-05-06 11:23:59 +02:00
Mathieu
da48a396ff fix(xo-server,xo-web/XOSTOR): do not require XCP-ng licenses (#7628) 2024-05-06 10:34:51 +02:00
Mathieu
ed66635b89 fix(xo-web/XOSTOR): handle older versions of linstor plugin (#7630)
Fixes "an error has occurred" in XOSTOR resource list
2024-05-06 10:07:10 +02:00
Pierre Donias
e3d718f1f7 fix(xo-web/pool): only show pool SRs in default SR selector (#7626)
Introduced by #7451
2024-05-06 09:20:51 +02:00
Pierre Donias
3a44b6d777 feat(lite): 0.2.2 (#7624) 2024-04-30 17:05:32 +02:00
Julien Fontanet
6870e067a0 fix(xo-server): use callAsync to install XCP-ng updates
Fixes https://team.vates.fr/vates/pl/bkqyatm7w3yquyw1o9watx3c1o
2024-04-30 16:26:42 +02:00
MlssFrncJrg
507949330f feat: release 5.93.1 (#7623) 2024-04-30 16:17:21 +02:00
OlivierFL
a6a63325cc feat(lite): update tree-view with new components (#7531) 2024-04-30 15:24:56 +02:00
MlssFrncJrg
22bd7ce8d4 feat: technical release (#7620) 2024-04-30 15:07:02 +02:00
Mathieu
dad34e9027 fix(xo-server/XOSTOR): fix install dependencies (#7619) 2024-04-30 14:46:08 +02:00
MlssFrncJrg
c280aecd33 feat: technical release (#7618) 2024-04-30 13:07:18 +02:00
Julien Fontanet
dd0afe3b02 feat(bump-pkg): prevent bump if package.json has modifications 2024-04-30 11:51:30 +02:00
b-Nollet
a8118ec7dd feat(xo-server): implement XO tasks for RPR and RPU (#7578) 2024-04-30 10:33:25 +02:00
MlssFrncJrg
63ebfce3f2 feat(xo-web/new VM): warn if pool is not setup for secure boot (#7562)
Fixes #7500
2024-04-30 10:08:12 +02:00
Pierre Donias
2e9c1d7c11 fix(xo-web/pool/advanced): handle undefined default SR (#7616)
Introduced by #7451
2024-04-30 09:56:17 +02:00
Florent BEAUCHAMP
3a68a61d7e fix(vmware-explorer/esxi): extent chain computation (#7617)
Introduced by bb47dafbf9

This is used to show the UI for the import using  exportVm instead of datastore access
2024-04-30 09:51:05 +02:00
Florent BEAUCHAMP
195a3f6220 fix(xo-server/vm.importFromEsxi): workDirRemote is optional even for single import (#7615)
introduced by 2d07fdcd02
2024-04-30 09:46:03 +02:00
Manon Mercier
8ed24899f5 docs: add example to the Cloud Init section (#7575) 2024-04-29 17:31:23 +02:00
Mathieu
6a31acd28b fix(xo-web/SR/XOSTOR): block access to XOSTOR tab for source users (#7611) 2024-04-29 17:02:50 +02:00
Julien Fontanet
b2e807b309 feat(xo-server/rest-api): actions can be listed without an existing object 2024-04-29 16:50:57 +02:00
Julien Fontanet
d64f5f8ab4 feat(xo-server/rest-api): GET endpoint for single action 2024-04-29 16:50:57 +02:00
Pierre Donias
264eb8166a fix(lite/release): pass "duplex: 'half'" option to tarball request (#7612) 2024-04-29 16:40:35 +02:00
Florent Beauchamp
bb47dafbf9 feat(xo-web): implement vsan import ui 2024-04-29 16:27:55 +02:00
Florent Beauchamp
2d07fdcd02 feat(xo-server): use ExportVM to import disks from vsan
must use a remote to store the temporary vmdks during imports
since they can't be parsed on the fly nor accessed by range
2024-04-29 16:27:55 +02:00
Florent Beauchamp
71e269eeb2 feat(vmware-explorer): implement VHD adapter for stream optimzed vmdk 2024-04-29 16:27:55 +02:00
Florent Beauchamp
5b0105690f feat(vmware-explorer): implement exportVm method
this method internally calls the web service method ExportVM :
 https://developer.vmware.com/apis/196/vim.VirtualMachine.html#exportVm

which can export all the disk of a stopped VM, regardless of the
datastore used,  including VSAN
The disks are exported in stream optimized VMDK , with their
grain directory ( level 1 adressing table) at the end, and
all the data are stored in comrpessed grains with markers
2024-04-29 16:27:55 +02:00
Florent Beauchamp
ed62f738ce refactor(vmware-explorer): extract fetch method 2024-04-29 16:27:55 +02:00
Florent Beauchamp
f0c92c6ed1 fix(vmware-explorer): use fetchProperty instead of search 2024-04-29 16:27:55 +02:00
Mathieu
75d37a52a1 feat(xo-web/XOSTOR): remove beta banner (#7609) 2024-04-29 16:26:57 +02:00
Mathieu
d1318e72c5 fix(xo-server): handle new XOSTOR licenses (#7558) 2024-04-29 15:45:12 +02:00
Mathieu
50938a3c23 feat(xo-web/xo-server/VM): ability to attach PCIs to a VM (#7464)
See #7432
2024-04-29 15:21:52 +02:00
Mathieu
e2a49605f1 feat(xo-web/host/advanced): list PCIs known by the XAPI (#7455)
See #7432
2024-04-29 15:06:15 +02:00
Mathieu
c32ca3d944 feat(xo-server/api): implement PCI API (#7444)
See #7432 
xen-api PR https://github.com/xapi-project/xen-api/pull/5542
2024-04-29 14:52:32 +02:00
Mathieu
08d31051de feat(xo-web/home/SR): display pro support status for XOSTOR SR (#7601) 2024-04-29 14:39:52 +02:00
Julien Fontanet
0c67610cb6 docs(troubleshooting): document stats and backup network 2024-04-29 13:55:06 +02:00
MlssFrncJrg
8946d5c149 fix(xo-server/XOSTOR): fix LVM_ERROR(5) during formatDisks (#7598) 2024-04-29 11:21:58 +02:00
MlssFrncJrg
a321398f43 fix(xo-server/XOSTOR): install or update packages on all pool hosts (#7597) 2024-04-29 11:13:45 +02:00
Florent BEAUCHAMP
da1b452540 fix(CHANGELOG.unreleased): package name (#7610)
Introduced by d64c1b8c3c
2024-04-29 11:10:00 +02:00
MlssFrncJrg
038d230d63 fix(xo-web/xostor/create): don't ignore hosts without disks when checking consistency (#7572) 2024-04-29 10:39:44 +02:00
Florent BEAUCHAMP
d64c1b8c3c fix(vmxware-explorer): handle multiple datacenter (#7553)
When downloading from the http browsing api, we need to pass the datacenter corresponding
to the datastore used
2024-04-29 10:36:38 +02:00
Florent BEAUCHAMP
2427f48618 feat(xva): improve compatibility with xenserver (#7563)
feat(xva): improve import compatibility with xenserver

* from ticket 23636
* fix error (Failure "Field last_boot_CPU_flags not present in rpc")
* fix error (Failure "(Failure "Field suspend_VDI not present in rpc"")
* fix error (Failure "(Failure "Field suspend_SR not present in rpc"")
2024-04-29 10:32:41 +02:00
MlssFrncJrg
81a125846f feat(xo-web, xo-server/XOSTOR): changes before XOSTOR official release (#7568) 2024-04-29 10:29:20 +02:00
Florent BEAUCHAMP
90eccf02e5 fix(vmware-explorer): harden vmx parsing (#7583)
from https://xcp-ng.org/forum/topic/8864/cannot-create-property-ctkenabled-on-string-true-on-trying-to-import-from-esxi/9
2024-04-29 10:27:56 +02:00
Julien Fontanet
7b7a46902e chore(mixins/Tasks): only check clearLogOnSuccess for root tasks 2024-04-26 16:56:00 +02:00
Julien Fontanet
91429406a8 feat(xo-web/subscribeXoTasks): use REST API watch mode 2024-04-26 16:56:00 +02:00
Julien Fontanet
29d39a5764 fix(xo-cli rest): remove HTTP timeout
Default 5s timeout is problematic with new tasks collection watch mode.
2024-04-26 16:56:00 +02:00
Julien Fontanet
6c1a1307c8 feat(xo-server/rest-api): watch mode for tasks
`/rest/v0/tasks?ndjson&watch`:
```
["remove",{"id":"0lv13orww","href":"/rest/v0/tasks/0lv13orww"}]
["update",{"id":"0lv13otzz","properties":{"method":"acl.getCurrentPermissions","params":{},"name":"API call: acl.getCurrentPermissions","userId":"287d34e8-e5ca-48b3-bf32-8499fa167211","type":"api.call"},"start":1713194362080,"status":"pending","updatedAt":1713194362080,"href":"/rest/v0/tasks/0lv13otzz"}]
```
2024-04-26 16:56:00 +02:00
Pierre Donias
1fa9b31076 feat(xo-web): japanese translation (#7605)
See #7582
2024-04-26 16:12:10 +02:00
Pierre Donias
f72de22d44 docs(RPU): document restartHostTimeout config (#7606)
See https://xcp-ng.org/forum/topic/8842
2024-04-26 16:02:02 +02:00
Julien Fontanet
5b41fe0842 chore(xen-api/transports): use @vates/xml{,-rpc}
Fixes #7556
2024-04-26 16:01:28 +02:00
Julien Fontanet
f8fc4aa551 feat(xml-rpc): new lib to parse/format XML-RPC 2024-04-26 16:01:28 +02:00
Julien Fontanet
798049c20e feat(xml): new lib to parse/format XML 2024-04-26 16:01:28 +02:00
MlssFrncJrg
db3c51d55e feat: technical release (#7603) 2024-04-26 11:03:01 +02:00
MlssFrncJrg
2833885638 feat(xo-web/XOSTOR): add confirmation modal informing hosts toolstack may restart (#7570) 2024-04-26 10:35:01 +02:00
Julien Fontanet
dfd58cd2e8 fix(xo-web/vm/backups): handle xo:no-bak tags
Fixes #7527
2024-04-25 15:14:09 +02:00
Mathieu
170537bd16 feat(xo-web/XOSTOR): manage XOSTOR interfaces (#7547) 2024-04-25 13:53:14 +02:00
Mathieu
a15f2ec760 feat(xo-web, xo-server/SR): list resources in a XOSTOR tab (#7542) 2024-04-25 11:23:39 +02:00
MlssFrncJrg
6dc18164d5 fix(xo-web/VM/advanced): fix error when pool is not visible by user (#7580) 2024-04-25 10:12:51 +02:00
Thierry Goettelmann
b3ea140ac0 feat(web6): new default layout (#7591) 2024-04-24 17:04:43 +02:00
OlivierFL
e5b5714f5a feat(web-core): add new ObjectIcon component (#7564) 2024-04-24 17:02:00 +02:00
OlivierFL
2b7b385da6 feat(web-core): add new ComplexIcon component (#7555) 2024-04-24 17:01:25 +02:00
Thierry Goettelmann
8229769f0d feat(web-core): new layout system (#7589)
New layout system with a default `CoreLayout` component which handle header +
resizable sidebar + content header + content + right panel header/content.
2024-04-24 10:23:04 +02:00
Thierry Goettelmann
8eb4dbb683 feat(web-stack): add i18n + keyboard shortcuts (#7590)
- Move i18n configuration from Lite to Core
- Add keyboard shortcuts (toggle lang / theme) to XO 6
- Add locales to Core
- Import Core locales into Lite and XO 6
2024-04-23 16:41:54 +02:00
Thierry Goettelmann
ed128e9b4b feat(web-core/tooltip): update TooltipItem to match design system (#7588) 2024-04-23 15:25:04 +02:00
Thierry Goettelmann
a4f7711554 feat(web-core/if-else): accept array of functions (#7586)
`ifElse` now accepts an array of functions for `onTrue` and `onFalse`
2024-04-23 15:17:25 +02:00
Thierry Goettelmann
7801c61394 feat(web6): new LogoTextOnly component (#7584) 2024-04-23 15:12:18 +02:00
Thierry Goettelmann
694b0389f3 feat(web-core): add MaybeArray and toArray (#7585)
- Add `MaybeArray` utility type
- Add `toArray` utility function
2024-04-23 14:58:15 +02:00
Florent Beauchamp
78fc882c89 fix(xo-server): really stop vm when importing
introduced by acc7b3a5a0
2024-04-23 10:18:42 +02:00
Florent Beauchamp
5e7590852f fix(vmware-explorer): wait for power off to finish
the power off call return a task, this commit wait for this task to end
2024-04-23 10:18:42 +02:00
Florent Beauchamp
a1886b466a fix(xo-server): nfs remote mount while importing from vmware
use the currently mounted and enabled remote instead of mounting them
also this respect the mount point defined in config ( /run/xo-server/mount for xoa)
introduced by bb8c3c18e6
2024-04-23 10:18:42 +02:00
Dan Pollak
3736b699ff docs(airgap): fix deployement→ deployment (#7581)
deployement >> deployment

Signed-off-by: Dan Pollak <danpollak2@gmail.com>
2024-04-23 09:11:29 +02:00
Florent BEAUCHAMP
587da7b133 fix(proxy): xapi watch VM_guest_metrics (#7574)
From zammad#21282
Introduced by 231f09de12

Health check is dependent on the updates on guest metrics to ensure VM is correctly booted
2024-04-22 11:08:00 +02:00
Dan Pollak
7b084fe0fa docs(restapi): fix dislayed → displayed (#7577) 2024-04-20 21:26:23 +02:00
John Impallomeni
b154d09a9c docs(README): use HTTPS for vates.tech link (#7576) 2024-04-20 14:00:06 +02:00
Julien Fontanet
05d975a63a feat(xo-server-audit): expose records in REST API 2024-04-19 11:45:50 +02:00
Julien Fontanet
55b28fdb77 fix(CHANGELOG.unreleased): package order
Introduced by 66915ebc5
2024-04-19 11:29:57 +02:00
Julien Fontanet
6b76a5780b feat(gen-deps-list): better order message
New message says explicitely where the incorrect package should be.
2024-04-19 11:29:57 +02:00
Julien Fontanet
54446cad3f feat(ci): ensure pkgs order in CHANGELOG.unreleased.md 2024-04-19 11:29:28 +02:00
Florent BEAUCHAMP
cc049d336e feat(vmware-explorer): trim hostname (#7560) 2024-04-18 17:23:16 +02:00
Florent BEAUCHAMP
66915ebc54 fix(@vates/node-vsphere-soap): don't use default proxy (#7551) 2024-04-18 11:29:15 +02:00
Florent BEAUCHAMP
aa6b23c06c fix(backups): use the right settings in writers (#7567)
Fixes https://xcp-ng.org/forum/post/75762
Introduced by 42dc75e739

Fix error `Error: val is not a non-empty string or a valid number. val=undefined`
2024-04-18 10:21:44 +02:00
Florent Beauchamp
164985a753 fix(xo-server): use the right limit for vdi size during import 2024-04-17 15:31:37 +02:00
Florent Beauchamp
acc7b3a5a0 refactor(xo-server): extract vmware import method to its own mixin 2024-04-17 15:31:37 +02:00
Florent BEAUCHAMP
2de0a2b32a Update @xen-orchestra/vmware-explorer/esxi.mjs
Co-authored-by: Julien Fontanet <julien.fontanet@isonoe.net>
2024-04-17 15:15:57 +02:00
Florent Beauchamp
0a7ae633e1 fix yarn.lock 2024-04-17 15:15:57 +02:00
Florent BEAUCHAMP
14d1ba5996 Apply suggestions from code review
Co-authored-by: b-Nollet <150058367+b-Nollet@users.noreply.github.com>
2024-04-17 15:15:57 +02:00
Florent Beauchamp
39bbd1a058 feat(vmware-explorer): implement fetchProperty 2024-04-17 15:15:57 +02:00
b-Nollet
4326f50121 docs(load_balancing.md): adding paragraph on vCPU balancing 2024-04-17 14:37:58 +02:00
b-Nollet
15177ace5b fix(xo-server-load-balancer): correct values of CPU and memory thresholds (density plan)
`undefined` CPU and memory thresholds were used in density plan to decide if a host can receive a VM or not, which made the host always accept it.

Introduced by 5a825bd459
2024-04-17 14:37:58 +02:00
Florent BEAUCHAMP
42dc75e739 feat(backups): make health check timeout configurable (#7561) 2024-04-16 18:15:40 +02:00
Julien Fontanet
2b73482f9e docs(airgap): deploy/upgrade processes (#7550) 2024-04-16 14:51:42 +02:00
Florent BEAUCHAMP
d217c7ba61 fix(vmware-explorer): undefined deviceType (#7545)
Introduced by 60488e6f0c

From zammad#23798
2024-04-15 17:32:12 +02:00
Thierry Goettelmann
bd7e566193 feat(web6): add missing deps and config (#7548)
Add missing dependencies and PostCSS configuration
2024-04-15 09:19:47 +02:00
Julien Fontanet
54b473c7b1 feat(xo-proxy/api): log call errors as tasks
This gives more detailed information (start, end, errors) and also adds support for subtasks.

Before:

```
2024-04-14T13:50:16.749Z xo:proxy:api WARN call error {
  method: 'test.throw',
  params: { message: 'foo' },
  error: Error: foo
      at Api.addMethods.test.throw.params.message.type (file://<...>/@xen-orchestra/proxy/app/mixins/api.mjs:227:19)
      at m (file://<...>/@xen-orchestra/proxy/app/mixins/api.mjs:253:28)
      at Api._call (file://<...>/@xen-orchestra/proxy/app/mixins/api.mjs:310:12)
      at file://<...>/@xen-orchestra/proxy/app/mixins/api.mjs:90:44
      at Zone.run (<...>/node_modules/node-zone/index.js:80:23)
      at file://<...>/@xen-orchestra/proxy/app/mixins/api.mjs:90:29
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at compressMiddleware (<...>/node_modules/koa-compress/lib/index.js:56:5)
}
```

After:

```
2024-04-14T13:49:17.102Z xo:proxy:api WARN call error {
  id: 'qxhdytrtmvk',
  properties: [Object: null prototype] {
    method: 'test.throw',
    params: { message: 'foo' }
  },
  start: 1713102557102,
  status: 'failure',
  end: 1713102557102,
  result: Error: foo
      at Api.addMethods.test.throw.params.message.type (file://<...>/@xen-orchestra/proxy/app/mixins/api.mjs:227:19)
      at file://<...>/@xen-orchestra/proxy/app/mixins/api.mjs:264:39
      at AsyncLocalStorage.run (node:async_hooks:346:14)
      at Task.runInside (<...>/@vates/task/index.js:175:41)
      at Task.run (<...>/@vates/task/index.js:158:31)
      at m (file://<...>/@xen-orchestra/proxy/app/mixins/api.mjs:264:29)
      at Api._call (file://<...>/@xen-orchestra/proxy/app/mixins/api.mjs:327:12)
      at file://<...>/@xen-orchestra/proxy/app/mixins/api.mjs:92:44
      at Zone.run (<...>/node_modules/node-zone/index.js:80:23)
      at file://<...>/@xen-orchestra/proxy/app/mixins/api.mjs:92:29
      at processTicksAndRejections (node:internal/process/task_queues:95:5)
      at compressMiddleware (<...>/node_modules/koa-compress/lib/index.js:56:5)
}
```
2024-04-14 15:55:50 +02:00
Julien Fontanet
5e94c5ad8d feat(proxy/api): add test.throw method 2024-04-14 15:55:50 +02:00
Julien Fontanet
9e2ccc6ea3 feat(task/Task.run): optional opts, context and args can be passed
The goal is to make subtasks creation as easy as possible.
2024-04-14 15:12:05 +02:00
mathieu
2f962dd2e0 feat(xo-web/xostor): possibility to set preferred interface at creation 2024-04-12 10:00:20 +02:00
mathieu
e3f31cc141 feat(xo-server/xostor): possibility to set preferred interface at creation 2024-04-12 10:00:20 +02:00
mathieu
bfbb758341 feat(xapi/xostor): implement network API 2024-04-12 10:00:20 +02:00
mathieu
5f103e631b fix(xo-web): fix Prettier formatting issues
Introduced by c96c253568, a4c775d4ef & 44f6d2f0e3
2024-04-11 11:34:54 +02:00
Thierry Goettelmann
c0eb26fdf0 feat(web-core/utils): new ifElse utility (#7546)
Small utility that mimics VueUse's `whenever` but watches a `boolean` and
accepts a second callback to be run whenever the source is `false`.
2024-04-10 16:53:45 +02:00
Julien Fontanet
8aa421a7a6 feat: release 5.93.1 2024-04-10 12:05:46 +02:00
Julien Fontanet
919e33a4e1 fix(xo-server/upgradeProxyAppliance): clear cache at the end
Previously the cache was not clear in case of quick API upgrade.
2024-04-10 09:43:19 +02:00
Julien Fontanet
5b85a01d83 docs: adapt logs access to new appliance 2024-04-09 12:50:44 +02:00
Julien Fontanet
f8a67744a3 feat(xo-web): 5.142.1 2024-04-08 15:16:42 +02:00
Julien Fontanet
501da8b176 feat(xo-server-perf-alert): 0.3.7 2024-04-08 15:16:21 +02:00
Julien Fontanet
07019d7117 feat(xo-server): 5.140.1 2024-04-08 15:11:12 +02:00
Julien Fontanet
02971173c9 feat(@xen-orchestra/vmware-explorer): 0.6.1 2024-04-08 15:02:03 +02:00
Julien Fontanet
53dadee014 feat(@xen-orchestra/proxy): 0.27.2 2024-04-08 15:00:01 +02:00
Julien Fontanet
9517cda78f feat(@xen-orchestra/immutable-backups): 1.0.4 2024-04-08 14:59:18 +02:00
Julien Fontanet
53626c2d88 feat(@xen-orchestra/backups-cli): 1.0.17 2024-04-08 14:58:01 +02:00
Julien Fontanet
122a7d6a34 feat(@xen-orchestra/backups): 0.47.0 2024-04-08 14:56:24 +02:00
Mathieu
a4c775d4ef feat(xo-web,xo-server/RPU): RPU disabled if XOSTOR in pool (#7540) 2024-04-08 14:38:43 +02:00
Olivier Lambert
45516f7b57 docs(SECURITY.md): update with a new email domain (#7541) 2024-04-08 11:56:22 +02:00
Julien Fontanet
009c0ea6b5 fix(xo-server/vm): expose if VTPM is needed
Introduced by 8834af65f7

Introduced by 2e002de774

Fixes https://github.com/vatesfr/xen-orchestra/pull/7436#discussion_r1534257272
2024-04-08 10:08:28 +02:00
Julien Fontanet
06e9bab0dc fix(CHANGELOG.unreleased): add missing xo-server-perf-alert
Introduced in bfb8d3b29
2024-04-08 09:27:55 +02:00
Julien Fontanet
f8db103074 fix(xo-web): don't ignore case matching tags 2024-04-08 09:25:02 +02:00
Thierry Goettelmann
8013fca7e8 refactor(web-core/collection): rename collection to tree (#7533) 2024-04-08 09:23:23 +02:00
Julien Fontanet
7d849650cf fix(CHANGELOG.unreleased): fix style 2024-04-08 09:21:13 +02:00
b-Nollet
6bf7ffe356 docs: correcting load balancer docs (#7537) 2024-04-08 08:20:41 +02:00
Florent Beauchamp
74fc4dcaca refactor(xo-server/importFromEsxi): don't duplicate code 2024-04-05 16:42:18 +02:00
Florent Beauchamp
ef72eccf3e fix(vmware-explorer): ignore VM without storage
intead of stopping the VM listing if even one VM is broken
2024-04-05 16:42:18 +02:00
Florent Beauchamp
b954e42bd9 fix(xo-server/import): handle VM running without snapshot 2024-04-05 16:42:18 +02:00
Florent Beauchamp
bb8c3c18e6 fix(xo-server/import): use nfs remote also for import multiple
nfs import was only plugged on simple import, used from cli
2024-04-05 16:42:18 +02:00
Mathieu
79c9ef0f09 fix(xo-web/host/advanced): handle getSmartctlHealth error (#7525)
Fixes https://xcp-ng.org/forum/post/74221
2024-04-03 15:32:04 +02:00
Julien Fontanet
3971a9813b feat(backups/worker): log duration/CPU/memory usage 2024-04-03 14:55:24 +02:00
Julien Fontanet
0794a63b51 fix(xo-server/vm.export): body does not have a headers prop
Introduced by bfb8d3b29

Fixes https://xcp-ng.org/forum/post/74554
2024-04-02 16:44:44 +02:00
Florent BEAUCHAMP
f9ca9e7c96 feat(lite): 0.2.1 (#7526) 2024-04-02 15:57:27 +02:00
Julien Fontanet
17ed63fd58 fix(xo-server/rest-api): fix host's logs URL
Introduced by 0815d546a
2024-04-02 14:03:22 +02:00
Julien Fontanet
0815d546a2 fix(xo-server/rest-api): getResource() returns a response not a stream
Introduced by bfb8d3b29

Fixes https://xcp-ng.org/forum/post/74499
2024-04-02 12:02:19 +02:00
Florent BEAUCHAMP
8b7e1b3d7c feat: release 5.93.0 (#7521) 2024-03-29 14:02:38 +01:00
Florent BEAUCHAMP
45d068e89d feat: technical release (#7520) 2024-03-28 14:32:56 +01:00
b-Nollet
a9692cd8bc feat(xo-web, xo-server): HA setup in pool advanced tab (#7503)
Fixes #4731
2024-03-28 13:48:06 +01:00
Florent Beauchamp
88c643f0ff fix(Replication/Healthcheck): use the right xapi to start healthcheck 2024-03-28 13:39:03 +01:00
Florent Beauchamp
be426a3a67 fix(Backup/Mirror): task has already ended when running a health check 2024-03-28 13:39:03 +01:00
Florent Beauchamp
da8e98dd52 fix(backup/healthcheck): handle the case where the baseVM is not in XO cache
this can happens when the xo-server is slow to update a faster XO
xapi.getObject throw a  " no object with UUID or opaque " error during healtcheck phase
2024-03-28 13:39:03 +01:00
Julien Fontanet
7c2735c410 feat(xo-server,xo-web): split XO Proxy upgrade and force upgrade workflow
The normal upgrade is using the API call, the force upgrade is using the reboot workflow.

Also, we should not fallback to the reboot workflow automatically on API call failure
because it can be normal due to xoa-updater and/or XO Proxy being rebooted and rebooting
the VM may break the current upgrade and leave npm in an broken state.
2024-03-28 12:06:10 +01:00
Julien Fontanet
701c51faab fix(xo-server/getProxyApplianceUpdaterState): don't ignore missing API method
This error should be log as well.

It does not break anything because it does prevent from fetching the state.

It should not happen a lot because the version of XO Proxy released alongside
this version of xo-server does provide this method.
2024-03-28 12:06:10 +01:00
Julien Fontanet
62cf60a858 fix(xo-server/getProxyApplianceUpdaterState): don't debounce failures
This permits retrying getting the state ASAP.
2024-03-28 12:06:10 +01:00
MlssFrncJrg
c96c253568 feat(xo-web/templates): allow bypassing blocked operation when deleting protected template (#7493)
See Zammad#21638
2024-03-28 11:13:58 +01:00
Florent BEAUCHAMP
f26cbf4c73 feat(xo-server): s3 and encryption at rest are production ready (#7515) 2024-03-28 10:47:08 +01:00
Mathieu
707f86bbe2 feat(xo-acl-resolver): implement ACLs for PCI and USB (#7478) 2024-03-28 10:40:15 +01:00
Florent BEAUCHAMP
68f5db5804 feat(vmware-explorer): log datastore used 2024-03-28 10:10:31 +01:00
Florent Beauchamp
a1a8b5aad1 fix(xo-server): dispose remotes correctly after VMWare migration, code cleanup 2024-03-28 10:10:31 +01:00
Florent Beauchamp
3939c4f021 feat(vmware-explorer): Use NFS datastore from XO Remote to bypass VMFS6 lock
- Migrate VM to NFS on VMWare side
- mount NFS in XO , named [VMWARE]{datastoreName}
- launch import and it will read through the direct NFS instead of using the soap access layer
2024-03-28 10:10:31 +01:00
Florent Beauchamp
599dc76edb feat(vmware-explorer): one pass XVA for raw and cold deltas
Instead of doing XVA import for raw and one VHD import per delta per disk
2024-03-28 10:10:31 +01:00
Florent Beauchamp
817ae46bc5 fix(vmware-explorer): disk alignment on delta of older ESXi 2024-03-28 10:10:31 +01:00
Florent BEAUCHAMP
5d1800a4ee fix(vhd-lib): clean stream destroying (#7518) 2024-03-28 10:00:12 +01:00
Florent BEAUCHAMP
a548a95e6d feat: technical release (#7517) 2024-03-27 15:35:03 +01:00
Julien Fontanet
88dd987e09 feat(lint-staged): varlidate packages order in CHANGELOG.unreleased.md 2024-03-27 13:38:07 +01:00
Samori Gorse
44f6d2f0e3 fix(xo-web/hub/recipes/kubernetes): remove -00 suffix on version (#7492)
### Description

To merge alongside https://git.vates.tech/vates/xoa/pulls/196

This is a change to remove the addition of `-00` that was used to reference packages installed via APT. 

1.  The [new apt repository](https://kubernetes.io/blog/2023/08/15/pkgs-k8s-io-introduction/) version number do not even match this convention anymore
2. We do not install Kubernetes packages with apt anymore, we install the binaries directly. The package versions number listed in GitHub are an exact match of the various binaries version we want to install
2024-03-27 11:39:15 +01:00
Julien Fontanet
7fb1682347 fix(xen-api): move HTTP timeout to undici dispatcher
This makes all transports respecting it.
2024-03-27 11:34:57 +01:00
OlivierFL
20f06f7ce0 feat(web-core): add UserLink component (#7513) 2024-03-27 11:28:29 +01:00
Julien Fontanet
65be1adadb fix(xo-server/vm.create): fix timeout when copying template
Fixes https://xcp-ng.org/forum/post/74162
2024-03-27 11:24:26 +01:00
MlssFrncJrg
68e99a27a0 feat(xo-web/VM/advanced): add warning when selected firmware is not supported (#7442) 2024-03-27 11:06:42 +01:00
Mathieu
1be7e2acbc fix(xo-server/xostor.create): restart toolstack after installing dependencies (#7437)
Related to zammad#21209
2024-03-27 10:58:17 +01:00
Julien Fontanet
61d167a432 feat(xo-web): add OTP requires validation (#7480)
This prevents users from forgetting to add OTP account in their application and
thus being locked out from XO.
2024-03-27 10:53:07 +01:00
MlssFrncJrg
776d21bd69 feat(xo-web/console): display zoom percentage (#7452)
Fixes zammad#22418

Display zoom percentage in an editable input.
2024-03-27 10:42:51 +01:00
OlivierFL
46d74ad6a0 feat(xo6/core): update tree-view ui (#7385)
- add vertical and horizontal lines between elements
- move dropdown menu components to `web-core`
- update tree-view VM power state icon
2024-03-27 10:29:04 +01:00
Florent BEAUCHAMP
2bc69b5ec7 fix(vwmare-explorer): handle raw cdrom (#7504)
Fixes zammad#23268
2024-03-27 10:25:22 +01:00
Florent BEAUCHAMP
ed4e080b04 fix(xo-server/warmMigration): feature is for sources and premium (#7514)
Introduced by #6549 

See https://team.vates.fr/vates/pl/745krdomtff99rf8951p65rkxh

In the feature matrix of XO, warm migration is for premium (and sources) users
2024-03-27 10:21:46 +01:00
Julien Fontanet
f68e58ad53 feat(xo-web): replace numeric dates by ISO 8601 (#7484)
- international standard intended to be unambiguous and universal
- more compact than previous implementation
- alphabetic order is the same as temporal order
- easier to compare lines in a table
- uncoupled from the language selection: English speaking users are not forced to use US format
2024-03-27 09:58:17 +01:00
OlivierFL
ae780c9bb5 feat(lite): disable navigation to WiP views via tabs (#7482) 2024-03-27 09:42:27 +01:00
OlivierFL
8614add711 feat(lite/web-core): update tab component (#7481)
Update Tab component to match design system:
- use new styles from design system
- move components into `web-core`
2024-03-27 09:17:01 +01:00
Julien Fontanet
1221b23edf fix(xo-server): USB_group has multiple PSUBs/VUSBs (#7483)
Multiple objects, the fields name should be plural.

Introduced by 73ad9c1e7
2024-03-26 14:58:58 +01:00
Julien Fontanet
5da9593ce0 fix(fs/local#getInfo): fix size for huge remote
Fixes zammad#23139

Implement own parsing instead of `@sindresorhus/df` which breaks when headers
and values are not correctly aligned (i.e. big sizes).

This simple parsing should be good enough.

See @sindresorhus/df#13
2024-03-26 11:18:27 +01:00
Julien Fontanet
583c728095 fix(xen-api/putResource): fix proxy and HTTPS support (#7508)
Fixes #7477 #7490 #7496 #7499 #7502

Introduced by 6c16055a1

`putResource()` is not using `undici` for the moment because it needs
work to make it work with the work-around for chunked encoding not
supported in XAPI.
2024-03-25 16:29:36 +01:00
Julien Fontanet
7564bdb402 feat(xo-web/user): show user auth tokens last use
More important than when a token has been created is when and by how it was used last.
2024-03-25 14:50:25 +01:00
Julien Fontanet
1267112272 feat(xo-server/authentication): save token last use info 2024-03-25 14:50:25 +01:00
Pierre Donias
2692a2d3f3 fix(lite/console): prevent duplicate consoles on error (#7505)
When a console connection fails, we wait before trying again. While waiting,
the user may open another console, which creates a new VNC Client, and renders
the console. Therefore, when we're done waiting, we must first check that
`vncClient` is `undefined` so that we don't create 2 instances of `VncClient`.
2024-03-25 14:10:57 +01:00
Julien Fontanet
2fc393b907 fix(xen-api/examples/export-vdi): proxy variable 2024-03-25 13:26:34 +01:00
Julien Fontanet
69060e8af9 feat(xen-api/examples/{ex,im}port-vdi): support HTTP proxy 2024-03-25 10:23:22 +01:00
Julien Fontanet
07a4f5a535 chore(xen-api): make examples deps dev deps 2024-03-25 10:23:22 +01:00
Thierry Goettelmann
a48fc72570 feat(web-core): enhance tooltip directive (#7491) 2024-03-25 10:22:13 +01:00
OlivierFL
7c73e80591 feat(lite/core): update UiButton component (#7450) 2024-03-25 10:14:40 +01:00
OlivierFL
7f2c84d88e feat(web-core): add new chip component (#7485) 2024-03-25 10:04:22 +01:00
OlivierFL
a7f56a125c feat(web-core): move UiStore into web-core (#7486) 2024-03-25 10:03:43 +01:00
OlivierFL
42e3067f7f feat(web-core): add new tag component (#7488) 2024-03-25 09:54:28 +01:00
OlivierFL
f4a1395581 feat(web-core): move menu components to web-core (#7489) 2024-03-25 09:54:02 +01:00
Mathieu
214b8ce19e feat(xo-web/license): ability to rebind licenses (#7390) 2024-03-22 10:02:00 +01:00
b-Nollet
1b5157e9a7 feat(xo-web): edit default SR in pool advanced tab (#7451)
Fixes #7414
2024-03-21 16:30:48 +01:00
Mathieu
0c4275df48 fix(xo-server/xostor): fix group-name for thick provisioning (#7494)
For thick provisioning, group-name must be `linstor_group`

Introduced by 2ff45c6
2024-03-21 15:41:34 +01:00
Florent BEAUCHAMP
98eb9aa8e8 feat(xo-web): implement manifest for XO5 (#7462) 2024-03-21 11:45:38 +01:00
b-Nollet
cf5db2de8f feat(xo-server): replug VIFs and PIFs when MTU is modified (#7443)
Unplug and replug VIFs and PIFs when network MTU is modified, to update their MTU value.

See https://xcp-ng.org/forum/post/72431
2024-03-21 10:02:16 +01:00
b-Nollet
b8177a7bad feat(xo-server-load-balancer): balance vCPUs option (#7333)
Adding an option for performance mode to balance VMs on hosts depending on their number of vCPUs and the number of CPUs of the host. See #5389
2024-03-20 17:11:36 +01:00
Julien Fontanet
a4465c389c fix(xo-server/deployProxy): let consumers remove XenStore entries
This will fix some issues, like xoa-updater registration when the
XO Proxy Appliance do not have Internet access on first boot.
2024-03-20 15:25:44 +01:00
Julien Fontanet
32836cb09e fix(xo-server/getProxyApplianceUpdaterState): ignore configure error
Log the error instead of throwing to keep things working as much as possible.
2024-03-20 10:48:20 +01:00
OlivierFL
e52b18f4e3 feat(lite/web-core): update UiCounter component (#7438)
- move component into `web-core`
- add size `large`
- add `suffix` prop to add text information after the value
2024-03-19 10:04:50 +01:00
OlivierFL
c0a576bc95 feat(lite): use redesigned typography (#7474) 2024-03-19 09:30:07 +01:00
Julien Fontanet
1d912bddab fix(xo-server): pass user IP to authenticateUser 2024-03-18 14:15:34 +01:00
Florent BEAUCHAMP
856961221f test(xo-vmdk-to-vhd): fix reference file path (#7402)
the xsd is not bundled in dist, the tests are run from the dist folder
2024-03-18 10:30:02 +01:00
Julien Fontanet
ac9461be21 fix(xo-server/getProxyApplianceUpdaterState): ignore missing appliance.updater.configure
Introduced by 215577b31
2024-03-18 09:22:03 +01:00
Julien Fontanet
e8c9e620ca fix(xo-server): HTTP proxy support for consoles
Introduced by 6c16055a1

Fixes #7476
2024-03-18 09:13:44 +01:00
Julien Fontanet
215577b313 feat(xo-server/upgradeProxyAppliance): try via API first
It's faster than rebooting the VM.

Attempting this method before falling back to the other one is more robust in
case one of the methods do not work.
2024-03-15 17:40:09 +01:00
Julien Fontanet
8e5d94dd31 fix(xo-web/proxies): can upgrade without vmUuid
Since 572359892
2024-03-15 17:38:15 +01:00
Julien Fontanet
92a3236d59 feat(xo-server/getProxyApplianceUpdaterState): set channel 2024-03-15 17:06:36 +01:00
Julien Fontanet
505aa9278a feat(proxy/api): new method appliance.updater.configure
Allows configuring the updater channel.
2024-03-15 17:06:36 +01:00
Dan Pollak
e8c6f5bad0 docs: add mirror backup to side menu (#7457)
Fixes #7416
2024-03-15 12:55:09 +01:00
Julien Fontanet
6c16055a18 fix(xen-api): various undici fixes (#7472)
* fix(xen-api): various undici fixes

Fixes #7465

Introduced by bfb8d3b29

- don't use single Client as it allows a single parallel request by default
- fix HTTP proxy support (for all methods but `putResource()`
- follow redirects
- `getResource` respect configured protocol
- properly throws on non 2xx responses
2024-03-15 11:06:24 +01:00
Julien Fontanet
c6451cfa35 feat(xo-cli): support OTP 2024-03-14 16:59:46 +01:00
Julien Fontanet
4b59ef5414 fix(xo-server/authenticateUser): check OTP
Fixes zammad#22688
2024-03-14 16:59:46 +01:00
Julien Fontanet
0ccfd4b681 fix(self-signed): do not log private key 2024-03-14 13:51:31 +01:00
MlssFrncJrg
66ee45f52a feat(xo-web/tag): show current tags in Advanced tag creation (#7434)
Fixes #7351
2024-03-14 11:22:29 +01:00
Dan Pollak
54dc3fe9bd fix(xo-web/log-alert-body): fix 'an error has occurred' (#7458) 2024-03-12 16:48:23 +01:00
b-Nollet
bfb8d3b29e chore(xen-api): http-request-plus → undici (except putResource) (#7177) 2024-03-12 11:22:12 +01:00
Thierry Goettelmann
51f95b3c85 feat(web-core): new ButtonIcon component (#7447) 2024-03-12 11:18:20 +01:00
Thierry Goettelmann
8381dba0f0 feat(web-core): new collection management (#7400)
New way to manage collections and sub-collections of items.
It handles different informations (id, label, depth, css classes etc.), status
(active, selected, expanded, etc.), filtering, actions (activate, select, select
children etc.), optional multi-select and generation of selection label (`Foo`,
`Foo, Bar, Baz`, `5 items selected`)
2024-03-12 11:02:25 +01:00
Thierry Goettelmann
a1def028f0 feat(web-core): new dropdown components (#7420)
New `DropdownList`, `DropdownTitle` and `DropdownItem` components, based on Design System.
2024-03-12 10:54:39 +01:00
Thierry Goettelmann
334bad8f27 feat(lite/stories): add web-core + enhancements (#7446)
- Rework story generator to include Web Core + better prop typing
- Replace existing icons with ones more suited to the project (Pool, Host, VM, etc.)
2024-03-12 10:51:07 +01:00
Thierry Goettelmann
acb890c779 docs(web-core): add CSS guidelines (#7454)
Add CSS guidelines for:
- Interactive elements
- Variants
2024-03-12 10:48:04 +01:00
Thierry Goettelmann
c10e3fd48f feat(web-core): redesigned typography (#7460) 2024-03-11 16:34:49 +01:00
Julien Fontanet
6848e34701 fix(CHANGELOG): add missing released packages 2024-03-11 14:54:00 +01:00
Julien Fontanet
58739d7fd2 feat(otp): ignore whitespaces
Some OTP applications (e.g. Authy) add them for nicer display.
2024-03-11 12:39:04 +01:00
Dan Pollak
7e66a4cb06 docs: xoa is default SSH account (#7456)
Fixes zammad#22547
2024-03-11 11:13:25 +01:00
Julien Fontanet
5a63b8dc78 chore: update dev deps 2024-03-11 11:05:06 +01:00
Thierry Goettelmann
6056a618c3 fix(web): add missing vue-router dependency (#7453) 2024-03-08 10:33:07 +01:00
Julien Fontanet
553605343c chore: update dev deps 2024-03-07 15:17:50 +01:00
Julien Fontanet
e14ce2215d docs: XOA default iface is now called enX0 (#7448) 2024-03-07 09:30:31 +01:00
Julien Fontanet
2e002de774 feat(xo-server/createVm): create VTPM if template requests it (#7436)
See https://team.vates.fr/vates/pl/d3mb7wb5fiy57pmp44wnusatce (private page)

Should fix https://www.youtube.com/watch?v=MqHuNu4hjJo
2024-03-06 11:52:51 +01:00
mathieuRA
1ae7b1d500 fix(xo-web/VM): SR no longer required if a migration network is selected 2024-03-06 11:23:50 +01:00
mathieuRA
6625d8f7af fix(xo-web/home/VM): do not migrate_send during VM migration if not needed
Fixes [Forum#8279](https://xcp-ng.org/forum/topic/8279/getting-errors-when-migrating-4-out-5-vmguest/18?_=1707234126297)
2024-03-06 11:23:50 +01:00
mathieuRA
7cfce7b1b6 fix(xo-server/xapi_migrateVm): use correct SR during VDI migration 2024-03-06 11:23:50 +01:00
Mathieu
e52a0bd3df fix(xo-web/SR): destination SRs are ISOs if we are migrating ISOs (#7431)
Fixes #7392
2024-03-06 11:05:55 +01:00
Julien Fontanet
48e6d582a7 feat: release 5.92.1 2024-03-06 10:18:55 +01:00
Mathieu
37c2cfd99e feat(xo-server/XOSTOR): add error case for 'LVM_ERROR(5) (#7428) 2024-03-05 17:50:39 +01:00
Julien Fontanet
50991582ef feat(xo-web): 5.140.0 2024-03-05 17:37:04 +01:00
Julien Fontanet
85a1d539d7 feat(xo-server): 5.138.1 2024-03-05 17:13:18 +01:00
Mathieu
0b00c1a654 fix(xo-server/xostore.create): remove linstor_group on failure (#7426)
Related to zammad#21209
2024-03-04 14:42:06 +01:00
Julien Fontanet
da51b1649c fix(xo-server/robots.txt): must not require authentication
Introduced by a2c36c083

This file is intended for search engines, which, by definition are not signed in.
2024-03-04 11:48:34 +01:00
Dan Pollak
8ad83f0e97 docs(backup): fix link to file level restore (#7421) 2024-03-04 11:15:31 +01:00
Mathieu
54f9be5b2c fix(xo-web/XOSTOR): move 'ignore file sytems' outside of advanced settings (#7429)
Move the toggle outside of advanced settings as its use is very common.
2024-03-04 10:45:53 +01:00
Mathieu
c8778fe2ab feat(xo-web/about): github links opens in a new tab (#7430)
Fixes #7427
2024-03-04 10:40:09 +01:00
Pierre Donias
dcdf2880aa fix(lite): missing color for logo (#7423)
Introduced by 5242affdc1
2024-03-01 11:39:49 +01:00
Julien Fontanet
6e4f79ce33 fix(xo-web/jobs): handle undefined refs.params
Fixes zammad#22196

Introduced by be452a5d6
2024-03-01 11:09:13 +01:00
952 changed files with 57643 additions and 16163 deletions

View File

@@ -39,6 +39,12 @@ module.exports = {
version: '>=16',
},
],
'n/no-unsupported-features/es-builtins': [
'error',
{
version: '>=16',
},
],
'n/no-unsupported-features/es-syntax': [
'error',
{
@@ -49,16 +55,17 @@ module.exports = {
},
{
files: ['@xen-orchestra/{web-core,lite,web}/**/*.{vue,ts}'],
parser: 'vue-eslint-parser',
parserOptions: {
sourceType: 'module',
parser: '@typescript-eslint/parser',
},
plugins: ['import'],
extends: [
'plugin:import/recommended',
'plugin:import/typescript',
'plugin:vue/vue3-recommended',
'@vue/eslint-config-typescript/recommended',
'@vue/eslint-config-prettier',
'plugin:@typescript-eslint/recommended',
'plugin:vue/vue3-essential',
],
settings: {
'import/resolver': {
@@ -73,11 +80,164 @@ module.exports = {
},
},
},
globals: {
XO_LITE_VERSION: true,
XO_LITE_GIT_HEAD: true,
},
rules: {
'no-void': 'off',
'n/no-missing-import': 'off', // using 'import' plugin instead to support TS aliases
'import/order': [
'error',
{
groups: ['builtin', 'object', 'internal', ['type', 'external']],
alphabetize: {
order: 'asc',
caseInsensitive: true,
},
pathGroups: [
{
pattern: '@/**',
group: 'internal',
},
{
pattern: '@core/**',
group: 'internal',
},
],
},
],
'no-void': ['error', { allowAsStatement: true }],
'n/no-missing-import': 'off', // using 'import' plugin instead, to support TS aliases
'no-redeclare': 'off', // automatically checked by the TypeScript compiler
'no-dupe-class-members': 'off', // automatically checked by the TypeScript compiler
'no-undef': 'off', // automatically checked by the TypeScript compiler
'no-use-before-define': 'off', // replaced with the rule below
'@typescript-eslint/no-use-before-define': ['error', { functions: false }],
'@typescript-eslint/no-explicit-any': 'off',
'vue/multi-word-component-names': 'off',
// Vue 3 - Strongly Recommended
'vue/attribute-hyphenation': 'error',
'vue/component-definition-name-casing': 'error',
'vue/first-attribute-linebreak': 'error',
'vue/html-closing-bracket-newline': 'off', // Conflicts with Prettier
'vue/html-closing-bracket-spacing': 'error',
'vue/html-end-tags': 'error',
'vue/html-indent': 'off', // Conflicts with Prettier
'vue/html-quotes': 'error',
'vue/html-self-closing': ['error', { html: { void: 'always', normal: 'always', component: 'always' } }],
'vue/max-attributes-per-line': 'off', // Conflicts with Prettier
'vue/multiline-html-element-content-newline': 'error',
'vue/mustache-interpolation-spacing': 'error',
'vue/no-multi-spaces': 'error',
'vue/no-spaces-around-equal-signs-in-attribute': 'error',
'vue/no-template-shadow': 'error',
'vue/prop-name-casing': 'error',
'vue/require-default-prop': 'off', // https://github.com/vuejs/eslint-plugin-vue/issues/2051
'vue/require-explicit-emits': 'error',
'vue/require-prop-types': 'error',
'vue/singleline-html-element-content-newline': 'off',
'vue/v-bind-style': 'error',
'vue/v-on-event-hyphenation': ['error', 'always', { autofix: true }],
'vue/v-on-style': 'error',
'vue/v-slot-style': 'error',
// Vue 3 - Recommended
'vue/attributes-order': 'error',
'vue/no-lone-template': 'error',
'vue/no-multiple-slot-args': 'error',
'vue/no-v-html': 'error',
'vue/this-in-template': 'error',
// Vue 3 - Uncategorized
'vue/block-lang': ['error', { script: { lang: 'ts' }, style: { lang: 'postcss' } }],
'vue/block-order': ['error', { order: ['template', 'script', 'style'] }],
'vue/block-tag-newline': ['error', { singleline: 'consistent', multiline: 'always', maxEmptyLines: 0 }],
'vue/component-api-style': ['error', ['script-setup']],
'vue/component-name-in-template-casing': ['error', 'PascalCase', { registeredComponentsOnly: false }],
'vue/custom-event-name-casing': ['error', 'camelCase'],
'vue/define-emits-declaration': ['error', 'type-literal'],
'vue/define-macros-order': [
'error',
{
order: ['defineOptions', 'defineProps', 'defineEmits', 'defineModel', 'defineSlots'],
defineExposeLast: true,
},
],
'vue/define-props-declaration': ['error', 'type-based'],
'vue/enforce-style-attribute': ['error', { allow: ['scoped', 'module'] }],
'vue/html-button-has-type': 'error',
'vue/html-comment-content-newline': ['error', { singleline: 'never', multiline: 'always' }],
'vue/html-comment-content-spacing': ['error', 'always'],
'vue/no-duplicate-attr-inheritance': 'error',
'vue/no-empty-component-block': 'error',
'vue/no-multiple-objects-in-class': 'error',
'vue/no-ref-object-reactivity-loss': 'error',
'vue/no-required-prop-with-default': 'error',
'vue/no-static-inline-styles': 'error',
'vue/no-template-target-blank': 'error',
'vue/no-undef-components': ['error', { ignorePatterns: ['RouterLink', 'RouterView', 'I18nT'] }],
'vue/no-undef-properties': 'error',
'vue/no-unused-refs': 'error',
'vue/no-use-v-else-with-v-for': 'error',
'vue/no-useless-mustaches': 'error',
'vue/no-useless-v-bind': 'error',
'vue/no-v-text': 'error',
'vue/padding-line-between-blocks': 'error',
'vue/prefer-define-options': 'error',
'vue/prefer-separate-static-class': 'error',
'vue/prefer-true-attribute-shorthand': 'error',
'vue/require-macro-variable-name': 'error',
'vue/valid-define-options': 'error',
},
},
// Specific rules for XO i18n-related files
{
files: [
'@xen-orchestra/lite/**/*.{vue,ts,json}',
'@xen-orchestra/web/**/*.{vue,ts,json}',
'@xen-orchestra/web-core/**/*.{vue,ts,json}',
],
extends: ['plugin:@intlify/vue-i18n/base'],
settings: {
'vue-i18n': {
localeDir: [
'@xen-orchestra/lite/src/locales/*.json',
'@xen-orchestra/web/src/locales/*.json',
'@xen-orchestra/web-core/lib/locales/*.json',
],
messageSyntaxVersion: '^9.9.0',
},
},
rules: {
strict: 'off',
'no-irregular-whitespace': 'off',
'@intlify/vue-i18n/no-deprecated-i18n-component': 'error',
'@intlify/vue-i18n/no-deprecated-i18n-place-attr': 'error',
'@intlify/vue-i18n/no-deprecated-i18n-places-prop': 'error',
'@intlify/vue-i18n/no-deprecated-modulo-syntax': 'error',
'@intlify/vue-i18n/no-deprecated-tc': 'error',
'@intlify/vue-i18n/no-html-messages': 'error',
'@intlify/vue-i18n/no-i18n-t-path-prop': 'error',
'@intlify/vue-i18n/no-missing-keys': 'error',
'@intlify/vue-i18n/no-raw-text': [
'error',
{
ignoreText: ['Xen Orchestra Lite', 'Xen Orchestra', 'XO Lite', 'XCP-ng', 'XO 5', '404', '⚠️'],
},
],
'@intlify/vue-i18n/no-v-html': 'error',
'@intlify/vue-i18n/valid-message-syntax': 'error',
'@intlify/vue-i18n/no-duplicate-keys-in-locale': 'error',
'@intlify/vue-i18n/no-missing-keys-in-other-locales': ['error', { ignoreLocales: ['de', 'fa'] }],
},
},
// Specific rules for XO dev-related files
{
files: [
'@xen-orchestra/lite/src/stories/**/*',
'@xen-orchestra/lite/src/components/component-story/**/*',
'@xen-orchestra/web/src/pages/dev/**/*',
'@xen-orchestra/lite/src/views/story/**/*',
],
rules: {
'@intlify/vue-i18n/no-raw-text': 'off',
},
},
{
@@ -124,7 +284,7 @@ module.exports = {
// this rule can prevent race condition bugs like parallel `a += await foo()`
//
// as it has a lots of false positive, it is only enabled as a warning for now
'require-atomic-updates': 'warn',
'require-atomic-updates': ['warn', { allowProperties: true }],
strict: 'error',
},

View File

@@ -24,6 +24,8 @@ jobs:
cache: 'yarn'
- name: Install project dependencies
run: yarn
- name: Ensure packages are sorted in CHANGELOG.unreleased.md
run: ./scripts/gen-deps-list.js --check-order > /dev/null
- name: Ensure yarn.lock is up-to-date
run: git diff --exit-code yarn.lock
- name: Build the project

6
.prettierignore Normal file
View File

@@ -0,0 +1,6 @@
# Ignore Handlebars files because partials are not currently supported
# https://github.com/prettier/prettier/issues/11834
**/*.hbs
# Generated files
/@xen-orchestra/web/typed-router.d.ts

View File

@@ -33,7 +33,7 @@
"test": "node--test"
},
"devDependencies": {
"sinon": "^17.0.1",
"sinon": "^18.0.0",
"test": "^3.2.1"
}
}

View File

@@ -29,7 +29,7 @@
"ensure-array": "^1.0.0"
},
"devDependencies": {
"sinon": "^17.0.1",
"sinon": "^18.0.0",
"test": "^3.2.1"
}
}

View File

@@ -1,8 +1,11 @@
import LRU from 'lru-cache'
import Fuse from 'fuse-native'
import { createLogger } from '@xen-orchestra/log'
import { VhdSynthetic } from 'vhd-lib'
import { Disposable, fromCallback } from 'promise-toolbox'
const { warn } = createLogger('vates:fuse-vhd')
// build a s stat object from https://github.com/fuse-friends/fuse-native/blob/master/test/fixtures/stat.js
const stat = st => ({
mtime: st.mtime || new Date(),
@@ -52,7 +55,10 @@ export const mount = Disposable.factory(async function* mount(handler, diskPath,
},
read(path, fd, buf, len, pos, cb) {
if (path === '/vhd0') {
return vhd.readRawData(pos, len, cache, buf).then(cb)
return vhd.readRawData(pos, len, cache, buf).then(cb, error => {
warn('read error', { path, len, pos, error })
cb(Fuse.EIO)
})
}
throw new Error(`read file ${path} not exists`)
},

View File

@@ -1,6 +1,6 @@
{
"name": "@vates/fuse-vhd",
"version": "2.1.0",
"version": "2.1.1",
"license": "ISC",
"private": false,
"homepage": "https://github.com/vatesfr/xen-orchestra/tree/master/@vates/fuse-vhd",
@@ -19,11 +19,12 @@
},
"main": "./index.mjs",
"dependencies": {
"@xen-orchestra/fs": "^4.1.5",
"@xen-orchestra/fs": "^4.1.7",
"@xen-orchestra/log": "^0.6.0",
"fuse-native": "^2.2.6",
"lru-cache": "^7.14.0",
"promise-toolbox": "^0.21.0",
"vhd-lib": "^4.9.1"
"vhd-lib": "^4.11.0"
},
"bin": {
"xo-fuse-vhd": "./cli.mjs"

View File

@@ -0,0 +1,18 @@
The use for this librariy is to create a composite key from a JSON value, ignoring objects identity and properties order.
The hash algorithm used is intended to be fast and with low collisions and is not guaranteed to be be secure.
The hash is encoded using [Base64 URL](https://en.wikipedia.org/wiki/Base64#URL_applications) to make it easy to use in URLs and filenames.
```js
import { jsonHash } from '@vates/json-hash'
console.log(jsonHash('foo'))
// → "siEyldVkkW-JpqQkVVZ8h8P0gPzXocFeIg8X1xaaeQs"
// order of properties is ignored
console.log(jsonHash({ foo: 0, bar: 1 }))
// → "JckoRSMIBjNlgEWIXhgpBOuyLQYqABZqvf1ccb3BPg0"
console.log(jsonHash({ bar: 1, foo: 0 }))
// → "JckoRSMIBjNlgEWIXhgpBOuyLQYqABZqvf1ccb3BPg0"
```

1
@vates/json-hash/.npmignore Symbolic link
View File

@@ -0,0 +1 @@
../../scripts/npmignore

View File

@@ -0,0 +1,51 @@
<!-- DO NOT EDIT MANUALLY, THIS FILE HAS BEEN GENERATED -->
# @vates/json-hash
[![Package Version](https://badgen.net/npm/v/@vates/json-hash)](https://npmjs.org/package/@vates/json-hash) ![License](https://badgen.net/npm/license/@vates/json-hash) [![PackagePhobia](https://badgen.net/bundlephobia/minzip/@vates/json-hash)](https://bundlephobia.com/result?p=@vates/json-hash) [![Node compatibility](https://badgen.net/npm/node/@vates/json-hash)](https://npmjs.org/package/@vates/json-hash)
> Compute a stable hash from a JSON-ifiable value
## Install
Installation of the [npm package](https://npmjs.org/package/@vates/json-hash):
```sh
npm install --save @vates/json-hash
```
## Usage
The use for this librariy is to create a composite key from a JSON value, ignoring objects identity and properties order.
The hash algorithm used is intended to be fast and with low collisions and is not guaranteed to be be secure.
The hash is encoded using [Base64 URL](https://en.wikipedia.org/wiki/Base64#URL_applications) to make it easy to use in URLs and filenames.
```js
import { jsonHash } from '@vates/json-hash'
console.log(jsonHash('foo'))
// → "siEyldVkkW-JpqQkVVZ8h8P0gPzXocFeIg8X1xaaeQs"
// order of properties is ignored
console.log(jsonHash({ foo: 0, bar: 1 }))
// → "JckoRSMIBjNlgEWIXhgpBOuyLQYqABZqvf1ccb3BPg0"
console.log(jsonHash({ bar: 1, foo: 0 }))
// → "JckoRSMIBjNlgEWIXhgpBOuyLQYqABZqvf1ccb3BPg0"
```
## Contributions
Contributions are _very_ welcomed, either on the documentation or on
the code.
You may:
- report any [issue](https://github.com/vatesfr/xen-orchestra/issues)
you've encountered;
- fork and create a pull request.
## License
[ISC](https://spdx.org/licenses/ISC) © [Vates SAS](https://vates.fr)

38
@vates/json-hash/index.js Normal file
View File

@@ -0,0 +1,38 @@
'use strict'
const { createHash } = require('node:crypto')
function updateJsonHash(value, hash) {
if (value !== null && typeof value === 'object') {
if (Array.isArray(value)) {
hash.update('[')
for (const item of value) {
updateJsonHash(item, hash)
// trailing is not a big deal because it does not need to be valid JSON
hash.update(',')
}
hash.update(']')
} else {
hash.update('{')
for (const key of Object.keys(value).sort()) {
updateJsonHash(key, hash)
hash.update(':')
updateJsonHash(value[key], hash)
// trailing is not a big deal because it does not need to be valid JSON
hash.update(',')
}
hash.update('}')
}
} else {
hash.update(JSON.stringify(value))
}
}
exports.jsonHash = function jsonHash(value) {
// this hash does not need to be secure, it just needs to be fast and with low collisions
const hash = createHash('sha256')
updateJsonHash(value, hash)
return hash.digest('base64url')
}

View File

@@ -0,0 +1,21 @@
'use strict'
const { jsonHash } = require('@vates/json-hash')
const assert = require('node:assert/strict')
const test = require('test')
const cases = [
[null, 'dCNOmK_nSY-12vHzasLXiswzlGT5UHA7jAGYkvmCuQs'],
[42, 'c0dctApWjo2ooEXO0RATfhWfiQrE2og7axfcZRs6gEk'],
['foo', 'siEyldVkkW-JpqQkVVZ8h8P0gPzXocFeIg8X1xaaeQs'],
[[], 'T1PNoYwrqgwDVLtfmj7L5e0Sq02OEbqHPC8RFhICuUU'],
[{}, 'RBNvo1WzZ4oRRq0W9-hknpT7T8If536DEMBg9hyq_4o'],
[{ a: 1, b: 2 }, 'LMjVxyj2vtMZ3W1cZ2cJrQij5zn7FBOlPiyBB38OmFE'],
[{ b: 2, a: 1 }, 'LMjVxyj2vtMZ3W1cZ2cJrQij5zn7FBOlPiyBB38OmFE'],
]
for (const [value, hash] of cases) {
test(JSON.stringify(value), function () {
assert.equal(jsonHash(value), hash)
})
}

View File

@@ -0,0 +1,33 @@
{
"private": false,
"name": "@vates/json-hash",
"description": "Compute a stable hash from a JSON-ifiable value",
"keywords": [
"hash",
"json",
"stable"
],
"homepage": "https://github.com/vatesfr/xen-orchestra/tree/master/@vates/json-hash",
"bugs": "https://github.com/vatesfr/xen-orchestra/issues",
"repository": {
"directory": "@vates/json-hash",
"type": "git",
"url": "https://github.com/vatesfr/xen-orchestra.git"
},
"author": {
"name": "Vates SAS",
"url": "https://vates.fr"
},
"license": "ISC",
"version": "0.2.0",
"engines": {
"node": ">=14.18.0"
},
"devDependencies": {
"test": "^3.3.0"
},
"scripts": {
"postversion": "npm publish --access public",
"test": "node--test"
}
}

View File

@@ -34,7 +34,6 @@ export default class NbdClient {
#exportSize
#waitBeforeReconnect
#readAhead
#readBlockRetries
#reconnectRetry
#connectTimeout
@@ -55,7 +54,6 @@ export default class NbdClient {
connectTimeout = 6e4,
messageTimeout = 6e4,
waitBeforeReconnect = 1e3,
readAhead = 10,
readBlockRetries = 5,
reconnectRetry = 5,
} = {}
@@ -65,7 +63,6 @@ export default class NbdClient {
this.#exportName = exportname
this.#serverCert = cert
this.#waitBeforeReconnect = waitBeforeReconnect
this.#readAhead = readAhead
this.#readBlockRetries = readBlockRetries
this.#reconnectRetry = reconnectRetry
this.#connectTimeout = connectTimeout

View File

@@ -6,7 +6,10 @@ import { createLogger } from '@xen-orchestra/log'
const { warn } = createLogger('vates:nbd-client:multi')
export default class MultiNbdClient {
#clients = []
#nbdConcurrency
#options
#readAhead
#settings
get exportSize() {
return this.#clients[0].exportSize
@@ -14,36 +17,64 @@ export default class MultiNbdClient {
constructor(settings, { nbdConcurrency = 8, readAhead = 16, ...options } = {}) {
this.#readAhead = readAhead
this.#options = options
this.#nbdConcurrency = nbdConcurrency
if (!Array.isArray(settings)) {
settings = [settings]
}
for (let i = 0; i < nbdConcurrency; i++) {
this.#clients.push(
new NbdClient(settings[i % settings.length], { ...options, readAhead: Math.ceil(readAhead / nbdConcurrency) })
)
}
this.#settings = settings
}
/**
*
* open nbdConcurrency connections to NBD servers
* it must obtain at least one connection to succeed
* it tries to spread connections on multiple host
*/
async connect() {
const connectedClients = []
for (const clientId in this.#clients) {
const client = this.#clients[clientId]
const candidates = [...this.#settings]
const promises = []
const baseOptions = this.#options
const _connect = async () => {
if (candidates.length === 0) {
return
}
// a little bit of randomization to spread the load
const nbdInfo = candidates[Math.floor(Math.random() * candidates.length)]
const client = new NbdClient(nbdInfo, {
...baseOptions,
readAhead: Math.ceil(this.#readAhead / this.#nbdConcurrency),
})
try {
await client.connect()
connectedClients.push(client)
this.#clients.push(client)
} catch (err) {
client.disconnect().catch(() => {})
// do not hammer unreachable hosts, once failed, remove from the list
const candidateIndex = candidates.findIndex(({ address }) => address === nbdInfo.address)
if (candidateIndex >= 0) {
// this candidate may have already been deleted by another parallel promise
candidates.splice(candidateIndex, 1)
}
warn(`can't connect to one nbd client`, { err })
// retry with another candidate (if available)
return _connect()
}
}
if (connectedClients.length === 0) {
for (let i = 0; i < this.#nbdConcurrency; i++) {
promises.push(_connect())
}
await Promise.all(promises)
if (this.#clients.length === 0) {
throw new Error(`Fail to connect to any Nbd client`)
}
if (connectedClients.length < this.#clients.length) {
if (this.#clients.length < this.#nbdConcurrency) {
warn(
`incomplete connection by multi Nbd, only ${connectedClients.length} over ${this.#clients.length} expected clients`
`incomplete connection by multi Nbd, only ${this.#clients.length} over ${this.#nbdConcurrency} expected clients`
)
this.#clients = connectedClients
}
}

View File

@@ -13,7 +13,7 @@
"url": "https://vates.fr"
},
"license": "ISC",
"version": "3.0.0",
"version": "3.1.0",
"engines": {
"node": ">=14.0"
},
@@ -24,7 +24,7 @@
"@xen-orchestra/async-map": "^0.1.2",
"@xen-orchestra/log": "^0.6.0",
"promise-toolbox": "^0.21.0",
"xen-api": "^2.0.1"
"xen-api": "^4.3.1"
},
"devDependencies": {
"tap": "^18.7.0",

View File

@@ -78,15 +78,14 @@ async function killNbdKit() {
)
}
test('it works with unsecured network', async tap => {
test('it works secured network', async tap => {
const path = await createTempFile(FILE_SIZE)
let nbdServer = await spawnNbdKit(path)
const client = new MultiNbdClient(
{
address: '127.0.0.1',
exportname: 'MY_SECRET_EXPORT',
cert: `-----BEGIN CERTIFICATE-----
const connectionSettings = {
address: '127.0.0.1',
exportname: 'MY_SECRET_EXPORT',
cert: `-----BEGIN CERTIFICATE-----
MIIDazCCAlOgAwIBAgIUeHpQ0IeD6BmP2zgsv3LV3J4BI/EwDQYJKoZIhvcNAQEL
BQAwRTELMAkGA1UEBhMCQVUxEzARBgNVBAgMClNvbWUtU3RhdGUxITAfBgNVBAoM
GEludGVybmV0IFdpZGdpdHMgUHR5IEx0ZDAeFw0yMzA1MTcxMzU1MzBaFw0yNDA1
@@ -108,12 +107,18 @@ CYu1Xn/FVPx1HoRgWc7E8wFhDcA/P3SJtfIQWHB9FzSaBflKGR4t8WCE2eE8+cTB
57ABhfYpMlZ4aHjuN1bL
-----END CERTIFICATE-----
`,
},
{
nbdConcurrency: 1,
readAhead: 2,
}
)
}
const invalid = {
address: '500.500.500.500',
port: 0,
exportname: 'nop',
}
// it should work even with some broken servers
const nbdInfos = [connectionSettings, connectionSettings, invalid]
const client = new MultiNbdClient(nbdInfos, {
nbdConcurrency: 4,
readAhead: 2,
})
await client.connect()
tap.equal(client.exportSize, BigInt(FILE_SIZE))
@@ -156,3 +161,18 @@ CYu1Xn/FVPx1HoRgWc7E8wFhDcA/P3SJtfIQWHB9FzSaBflKGR4t8WCE2eE8+cTB
nbdServer.kill()
await fs.unlink(path)
})
test('fails if server does not answer', async () => {
const client = new MultiNbdClient(
{
address: '500.500.500.500',
port: 0,
exportname: 'nop',
},
{
nbdConcurrency: 1,
readAhead: 2,
}
)
await assert.rejects(client.connect())
})

View File

@@ -17,7 +17,20 @@ import https from 'node:https'
import util from 'util'
import soap from 'soap'
import Cookie from 'soap-cookie' // required for session persistence
import { createLogger } from '@xen-orchestra/log'
const { warn } = createLogger('xo:node-vsphere-soap:client')
class VmwareError extends Error {
constructor(rawError) {
super(rawError.body)
const matches = rawError.body?.match(/<faultstring[^>]*>(.*)<\/faultstring>/im)
this.message = matches?.[1] ?? rawError.message
this.name = 'VmwareError'
this.stack = rawError.stack
// not putting the cause since the error failed to be stringified correctly down the road
warn(rawError)
}
}
// Client class
// inherits from EventEmitter
// possible events: connect, error, ready
@@ -31,14 +44,20 @@ export function Client(vCenterHostname, username, password, sslVerify) {
EventEmitter.call(this)
// sslVerify argument handling
// don't use any proxy to connect to the esxi
if (sslVerify) {
this.clientopts = {}
this.clientopts = {
request: axios.create({
proxy: false,
}),
}
} else {
this.clientopts = {
request: axios.create({
httpsAgent: new https.Agent({
rejectUnauthorized: false,
}),
proxy: false,
}),
}
}
@@ -134,8 +153,9 @@ Client.prototype._connect = function () {
self.clientopts,
function (err, client) {
if (err) {
self.emit('error', err)
throw err
const vErr = new VmwareError(err)
self.emit('error', vErr)
throw vErr
}
self.client = client // save client for later use
@@ -144,6 +164,7 @@ Client.prototype._connect = function () {
.runCommand('RetrieveServiceContent', { _this: 'ServiceInstance' })
.once('result', function (result, raw, soapHeader) {
if (!result.returnval) {
// this is a domain/server error return it as is
self.status = 'disconnected'
self.emit('error', raw)
return
@@ -202,7 +223,7 @@ Client.prototype._close = function () {
function _soapErrorHandler(self, emitter, command, args, err) {
err = err || { body: 'general error' }
if (err.body.match(/session is not authenticated/)) {
if (err.body?.match(/session is not authenticated/)) {
self.status = 'disconnected'
process.removeAllListeners('beforeExit')
@@ -214,16 +235,19 @@ function _soapErrorHandler(self, emitter, command, args, err) {
emitter.emit('result', result, raw, soapHeader)
})
.once('error', function (err) {
emitter.emit('error', err.body)
throw err
const vErr = new VmwareError(err)
emitter.emit('error', vErr)
throw vErr
})
} else {
emitter.emit('error', err.body)
throw err
const vErr = new VmwareError(err)
emitter.emit('error', vErr)
throw vErr
}
} else {
emitter.emit('error', err.body)
throw err
const vErr = new VmwareError(err)
emitter.emit('error', vErr)
throw vErr
}
}

View File

@@ -1,6 +1,6 @@
{
"name": "@vates/node-vsphere-soap",
"version": "2.0.0",
"version": "2.1.0",
"description": "interface to vSphere SOAP/WSDL from node for interfacing with vCenter or ESXi, forked from node-vsphere-soap",
"main": "lib/client.mjs",
"author": "reedog117",
@@ -11,6 +11,7 @@
},
"bugs": "https://github.com/vatesfr/xen-orchestra/issues",
"dependencies": {
"@xen-orchestra/log": "^0.6.0",
"axios": "^1.4.0",
"soap": "^1.0.0",
"soap-cookie": "^0.10.1"

View File

@@ -0,0 +1,46 @@
### `replace(value, replacement)`
> Recursively replace sensitive entries with a replacement value.
```js
import { replace } from '@vates/obfuscate'
replace({ username: 'foo', password: 'bar' }, 'obfuscated')
// → { username: 'foo', password: 'obfuscated'}
```
### `obfuscate(value)`
> Recursively replace sensitive entries with a special tag.
```js
import { obfuscate } from '@vates/obfuscate'
obfuscate({ username: 'foo', password: 'bar' })
// → {
// username: 'foo',
// password: 'obfuscated-q3oi6d9X8uenGvdLnHk2',
// }
```
### `merge(newValue, oldValue)`
> Replace entries obfuscated by `obfuscate()` in the new value by entries from the old one.
>
> This is especially useful to give an obfuscated value to a client, let them modify it, and then merge modified and unmodified values.
```js
import { obfuscate, merge } from '@vates/obfuscate'
const original = { username: 'foo', password: 'bar', token: 'baz' }
// compute an obfuscated value to send to a client
const obfuscated = obfuscate(original)
// let the client update any entries
obfuscated.token = 'qux'
// merge the updated value with the original one
merge(obfuscated, original)
// → { username: 'foo', password: 'bar', token: 'qux' }
```

1
@vates/obfuscate/.npmignore Symbolic link
View File

@@ -0,0 +1 @@
../../scripts/npmignore

View File

@@ -0,0 +1,77 @@
<!-- DO NOT EDIT MANUALLY, THIS FILE HAS BEEN GENERATED -->
# @vates/obfuscate
[![Package Version](https://badgen.net/npm/v/@vates/obfuscate)](https://npmjs.org/package/@vates/obfuscate) ![License](https://badgen.net/npm/license/@vates/obfuscate) [![PackagePhobia](https://badgen.net/bundlephobia/minzip/@vates/obfuscate)](https://bundlephobia.com/result?p=@vates/obfuscate) [![Node compatibility](https://badgen.net/npm/node/@vates/obfuscate)](https://npmjs.org/package/@vates/obfuscate)
## Install
Installation of the [npm package](https://npmjs.org/package/@vates/obfuscate):
```sh
npm install --save @vates/obfuscate
```
## Usage
### `replace(value, replacement)`
> Recursively replace sensitive entries with a replacement value.
```js
import { replace } from '@vates/obfuscate'
replace({ username: 'foo', password: 'bar' }, 'obfuscated')
// → { username: 'foo', password: 'obfuscated'}
```
### `obfuscate(value)`
> Recursively replace sensitive entries with a special tag.
```js
import { obfuscate } from '@vates/obfuscate'
obfuscate({ username: 'foo', password: 'bar' })
// → {
// username: 'foo',
// password: 'obfuscated-q3oi6d9X8uenGvdLnHk2',
// }
```
### `merge(newValue, oldValue)`
> Replace entries obfuscated by `obfuscate()` in the new value by entries from the old one.
>
> This is especially useful to give an obfuscated value to a client, let them modify it, and then merge modified and unmodified values.
```js
import { obfuscate, merge } from '@vates/obfuscate'
const original = { username: 'foo', password: 'bar', token: 'baz' }
// compute an obfuscated value to send to a client
const obfuscated = obfuscate(original)
// let the client update any entries
obfuscated.token = 'qux'
// merge the updated value with the original one
merge(obfuscated, original)
// → { username: 'foo', password: 'bar', token: 'qux' }
```
## Contributions
Contributions are _very_ welcomed, either on the documentation or on
the code.
You may:
- report any [issue](https://github.com/vatesfr/xen-orchestra/issues)
you've encountered;
- fork and create a pull request.
## License
[ISC](https://spdx.org/licenses/ISC) © [Vates SAS](https://vates.fr)

View File

@@ -1,9 +1,18 @@
import mapValues from 'lodash/mapValues.js'
'use strict'
function mapValues(object, iteratee) {
const result = {}
for (const key of Object.keys(object)) {
result[key] = iteratee(object[key], key, object)
}
return result
}
// this random value is used to obfuscate real data
const OBFUSCATED_VALUE = 'obfuscated-q3oi6d9X8uenGvdLnHk2'
exports.OBFUSCATED_VALUE = OBFUSCATED_VALUE
export const merge = (newValue, oldValue) => {
function merge(newValue, oldValue) {
if (newValue === OBFUSCATED_VALUE) {
return oldValue
}
@@ -23,14 +32,16 @@ export const merge = (newValue, oldValue) => {
const iteratee = (v, k) => merge(v, oldValue[k])
return isArray ? newValue.map(iteratee) : mapValues(newValue, iteratee)
}
exports.merge = merge
export const obfuscate = value => replace(value, OBFUSCATED_VALUE)
const obfuscate = value => replace(value, OBFUSCATED_VALUE)
exports.obfuscate = obfuscate
const SENSITIVE_PARAMS = ['token', 'passphrase', /password/i, 'encryptionKey']
const isSensitiveParam = name =>
SENSITIVE_PARAMS.some(pattern => (typeof pattern === 'string' ? pattern === name : pattern.test(name)))
export function replace(value, replacement) {
function replace(value, replacement) {
function helper(value, name) {
if (typeof value === 'string' && isSensitiveParam(name)) {
return replacement
@@ -45,3 +56,4 @@ export function replace(value, replacement) {
return helper(value)
}
exports.replace = replace

View File

@@ -0,0 +1,23 @@
{
"private": false,
"name": "@vates/obfuscate",
"homepage": "https://github.com/vatesfr/xen-orchestra/tree/master/@vates/obfuscate",
"bugs": "https://github.com/vatesfr/xen-orchestra/issues",
"repository": {
"directory": "@vates/obfuscate",
"type": "git",
"url": "https://github.com/vatesfr/xen-orchestra.git"
},
"author": {
"name": "Vates SAS",
"url": "https://vates.fr"
},
"license": "ISC",
"version": "0.1.0",
"engines": {
"node": ">=8.10"
},
"scripts": {
"postversion": "npm publish --access public"
}
}

View File

@@ -9,6 +9,15 @@ function assert(name, value) {
}
}
const WHITESPACES = /\s+/g
function cleanToken(otp) {
// remove whitespaces
//
// some OTP clients add whitespaces for better readability (e.g. `XXX XXX`)
// and users might be tempted to write them
return otp && otp.replace(WHITESPACES, '')
}
// https://github.com/google/google-authenticator/wiki/Key-Uri-Format
function generateUri(protocol, label, params) {
assert('label', typeof label === 'string')
@@ -64,7 +73,7 @@ export function generateHotpUri({ counter, digits, issuer, label, secret }) {
}
export async function verifyHotp(token, opts) {
return token === (await generateHotp(opts))
return cleanToken(token) === (await generateHotp(opts))
}
function totpCounter(period = 30, timestamp = Math.floor(Date.now() / 1e3)) {
@@ -85,6 +94,7 @@ export async function verifyTotp(token, { period, timestamp, window = 1, ...opts
const counter = totpCounter(period, timestamp)
const end = counter + window
opts.counter = counter - window
token = cleanToken(token)
while (opts.counter <= end) {
if (token === (await generateHotp(opts))) {
return true

View File

@@ -22,7 +22,7 @@
"url": "https://vates.fr"
},
"license": "ISC",
"version": "1.0.0",
"version": "1.1.0",
"engines": {
"node": ">=15"
},

View File

@@ -6,9 +6,11 @@ exports.parseDuration = value => {
if (typeof value === 'number') {
return value
}
const duration = ms(value)
if (duration === undefined) {
throw new TypeError(`not a valid duration: ${value}`)
if (typeof value === 'string' && value !== '') {
const duration = ms(value)
if (duration !== undefined) {
return duration
}
}
return duration
throw new TypeError(`not a valid duration: ${value}`)
}

View File

@@ -0,0 +1,22 @@
import { describe, it } from 'node:test'
import { parseDuration } from '@vates/parse-duration'
import assert from 'node:assert/strict'
describe('parseDuration()', () => {
it('should parse string', () => {
const input = '2 days'
const expected = 172800000
assert.strictEqual(parseDuration(input), expected)
})
it('should return its input if already a number', () => {
const input = 172800000
assert.strictEqual(parseDuration(input), input)
})
for (const input of [undefined, '', 'invalid duration']) {
it('should throw an error for ' + input, () => {
assert.throws(() => parseDuration(input), { message: `not a valid duration: ${input}` })
})
}
})

View File

@@ -27,6 +27,7 @@
"ms": "^2.1.2"
},
"scripts": {
"postversion": "npm publish --access public"
"postversion": "npm publish --access public",
"test": "node --test"
}
}

View File

@@ -72,6 +72,27 @@ Task.warning(message, data)
Task.set(property, value)
```
### `Task.run([opts], fn, ...args)`
This is a convenient shortcut to `new Task(opts).run(() => fn(...args))`.
```js
// options can be passed
await Task.run({ properties: { name: 'foo' } }, fn)
// arguments can be passed
await Task.run(fn, 'foo', 'bar')
// context (this) is forwarded
await Task.run.call(object, object.method)
// as a convenience, you can pass a method name directly
await Task.run.call(object, 'method')
// everything together
await Task.run.call(object, 'method', 'foo', 'bar')
```
### `combineEvents`
Create a consolidated log from individual events.

View File

@@ -88,6 +88,27 @@ Task.warning(message, data)
Task.set(property, value)
```
### `Task.run([opts], fn, ...args)`
This is a convenient shortcut to `new Task(opts).run(() => fn(...args))`.
```js
// options can be passed
await Task.run({ properties: { name: 'foo' } }, fn)
// arguments can be passed
await Task.run(fn, 'foo', 'bar')
// context (this) is forwarded
await Task.run.call(object, object.method)
// as a convenience, you can pass a method name directly
await Task.run.call(object, 'method')
// everything together
await Task.run.call(object, 'method', 'foo', 'bar')
```
### `combineEvents`
Create a consolidated log from individual events.

View File

@@ -44,6 +44,8 @@ exports.makeOnProgress = function ({ onRootTaskEnd = noop, onRootTaskStart = noo
} else if (type === 'property') {
;(taskLog.properties ?? (taskLog.properties = { __proto__: null }))[event.name] = event.value
} else if (type === 'end') {
taskLogs.delete(id)
taskLog.end = event.timestamp
taskLog.result = event.result
taskLog.status = event.status

View File

@@ -3,6 +3,10 @@
const assert = require('node:assert').strict
const { AsyncLocalStorage } = require('node:async_hooks')
function alreadyEnded() {
throw new Error('task has already ended')
}
// define a read-only, non-enumerable, non-configurable property
function define(object, property, value) {
Object.defineProperty(object, property, { value })
@@ -21,7 +25,7 @@ const asyncStorage = global[asyncStorageKey] ?? (global[asyncStorageKey] = new A
const getTask = () => asyncStorage.getStore()
exports.Task = class Task {
class Task {
static get abortSignal() {
const task = getTask()
if (task !== undefined) {
@@ -29,29 +33,25 @@ exports.Task = class Task {
}
}
static info(message, data) {
const task = getTask()
if (task !== undefined) {
task.#emit('info', { data, message })
static run(...args) {
let opts = args[0]
let fn
if (typeof opts === 'object') {
args.shift()
fn = args[0]
} else {
fn = opts
opts = undefined
}
}
args.shift()
static run(opts, fn) {
return new this(opts).run(fn)
}
const thisArg = this !== Task ? this : undefined
static set(name, value) {
const task = getTask()
if (task !== undefined) {
task.#emit('property', { name, value })
if (typeof fn !== 'function') {
fn = this[fn]
}
}
static warning(message, data) {
const task = getTask()
if (task !== undefined) {
task.#emit('warning', { data, message })
}
return new Task(opts).run(() => fn.apply(thisArg, args))
}
static wrap(opts, fn) {
@@ -110,9 +110,7 @@ exports.Task = class Task {
this.#emit('abortionRequested', { reason: signal.reason })
if (!this.#running) {
const status = FAILURE
this.#status = status
this.#emit('end', { result: signal.reason, status })
this.#end(FAILURE, signal.reason)
}
}
})
@@ -123,12 +121,26 @@ exports.Task = class Task {
}
#emit(type, data) {
assert.equal(this.#startData, undefined, 'task has not started yet')
data.id = this.id
data.timestamp = Date.now()
data.type = type
this.#onProgress(data)
}
#end(status, result) {
assert.equal(this.#status, PENDING)
this.#status = status
this.#emit('end', { status, result })
this.#onProgress = alreadyEnded
}
info(message, data) {
this.#emit('info', { data, message })
}
#maybeStart() {
const startData = this.#startData
if (startData !== undefined) {
@@ -140,8 +152,7 @@ exports.Task = class Task {
async run(fn) {
const result = await this.runInside(fn)
if (this.status === PENDING) {
this.#status = SUCCESS
this.#emit('end', { status: SUCCESS, result })
this.#end(SUCCESS, result)
}
return result
}
@@ -155,18 +166,27 @@ exports.Task = class Task {
this.#maybeStart()
try {
const result = await asyncStorage.run(this, fn)
const result = await asyncStorage.run(this, fn, this)
this.#running = false
return result
} catch (result) {
const status = FAILURE
this.#status = status
this.#emit('end', { status, result })
this.#end(FAILURE, result)
throw result
}
}
set(name, value) {
assert.equal(this.status, PENDING)
this.#emit('property', { name, value })
}
warning(message, data) {
assert.equal(this.status, PENDING)
this.#emit('warning', { data, message })
}
wrap(fn) {
const task = this
return function taskRun() {
@@ -181,3 +201,15 @@ exports.Task = class Task {
}
}
}
exports.Task = Task
// setup static aliases
for (const name of ['info', 'set', 'warning']) {
const method = Task.prototype[name]
Task[name] = function () {
const task = getTask()
if (task !== undefined) {
return method.apply(task, arguments)
}
}
}

View File

@@ -3,6 +3,7 @@
const assert = require('node:assert').strict
const { describe, it } = require('test')
const { makeOnProgress } = require('./combineEvents.js')
const { Task } = require('./index.js')
const noop = Function.prototype
@@ -162,6 +163,44 @@ describe('Task', function () {
})
})
describe('.run()', function () {
function fn(...args) {
Task.set('baz', 'qux')
return [this, ...args]
}
const obj = { fn }
it('accepts optional options', async function () {
assert.deepEqual(
await Task.run(
{
properties: { foo: 'bar' },
onProgress: makeOnProgress({
onRootTaskEnd(log) {
assert.deepEqual(log.properties, { __proto__: null, foo: 'bar', baz: 'qux' })
},
}),
},
fn
),
[undefined]
)
})
it('accepts optional arguments', async function () {
assert.deepEqual(await Task.run(fn, 'foo', 'bar'), [undefined, 'foo', 'bar'])
})
it('accepts optional context', async function () {
assert.deepEqual(await Task.run.call('foo', fn), ['foo'])
})
it('accepts a method name instead of a function', async function () {
assert.deepEqual(await Task.run.call(obj, 'fn'), [obj])
})
})
describe('.set()', function () {
it('does nothing when run outside a task', function () {
Task.set('progress', 10)
@@ -180,6 +219,31 @@ describe('Task', function () {
})
})
describe('#set()', function () {
const name = 'progress'
const value = 10
it('throws when the task is not started', function () {
const task = createTask()
assert.throws(() => task.set(name, value), { message: 'task has not started yet' })
})
it(`emits an property message`, async function () {
const task = createTask()
await task.run(async () => {
await Task.run(() => {
task.set(name, value)
assertEvent(task, {
name,
type: 'property',
value,
})
})
})
})
})
describe('.warning()', function () {
it('does nothing when run outside a task', function () {
Task.warning('foo')
@@ -198,6 +262,30 @@ describe('Task', function () {
})
})
for (const type of ['info', 'warning']) {
describe(`#${type}()`, function () {
it('throws when the task is not started', function () {
const task = createTask()
assert.throws(() => task[type]('foo'), { message: 'task has not started yet' })
})
it(`emits an ${type} message`, async function () {
const task = createTask()
await task.run(async () => {
await Task.run(() => {
task[type]('foo')
assertEvent(task, {
data: undefined,
message: 'foo',
type,
})
})
})
})
})
}
describe('#id', function () {
it('can be set', function () {
const task = createTask()

View File

@@ -13,7 +13,7 @@
"url": "https://vates.fr"
},
"license": "ISC",
"version": "0.2.0",
"version": "0.4.1",
"engines": {
"node": ">=14"
},

128
@vates/xml-rpc/.USAGE.md Normal file
View File

@@ -0,0 +1,128 @@
### Formatting
```js
import { xmlRpcFormatter } from '@vates/xml-rpc/formatter'
// There is a dedicated method per XML-RPC tag (`array`, `string`, etc.)
xmlRpcFormatter.format_methodCall({
methodName: 'examples.getStateName',
params: [40],
})
// → {
// name: 'methodCall',
// children: [
// {
// name: 'methodName',
// children: [ 'examples.getStateName' ]
// },
// {
// name: 'params',
// children: [
// {
// name: 'param',
// children: [ { name: 'value', children: [ '40' ] } ]
// }
// ]
// }
// ]
// }
// There is a dedicated method to format a JS value
xmlRpcFormatter.format_js(new Date(900684535000))
// → {
// name: 'dateTime.iso8601',
// children: [ '1998-07-17T14:08:55.000Z' ]
// }
```
Formatting XML is out of this library's scope, but you can achieve it easily with
`@vates/xml`:
```js
import { formatXml } from '@vates/xml/format'
// it can now be passed to the XML-RPC parser
const tree = xmlRpcFormatter.format_methodCall({
methodName: 'examples.getStateName',
params: [40],
})
// avoid any indentation or new lines as it will confuse many XML-RPC parsers.
const xml = formatXml(tree, { indent: 0 })
```
### Parsing
```js
import { xmlRpcParser } from '@vates/xml-rpc/parser'
xmlRpcParser.parse({
name: 'methodResponse',
children: [
{
name: 'params',
children: [
{
name: 'param',
children: [
{
name: 'value',
children: [
{
name: 'string',
children: ['South Dakota'],
},
],
},
],
},
],
},
],
})
// { params: [ 'South Dakota' ] }
// There is a dedicated method per XML-RPC tag (`array`, `string`, etc.)
xmlRpcParser.parse_array({
name: 'array',
children: [
{
name: 'data',
children: [
{
name: 'value',
children: [{ name: 'boolean', children: ['1'] }],
},
{
name: 'value',
children: [{ name: 'int', children: ['42'] }],
},
],
},
],
})
// [ true, 42 ]
```
Parsing XML is out of this library's scope, but you can achieve it easily with
`@vates/xml`:
```js
import { parseXml } from '@vates/xml/parse'
const xml = `
<?xml version="1.0"?>
<methodResponse>
<params>
<param>
<value><string>South Dakota</string></value>
</param>
</params>
</methodResponse>
`
const tree = parseXml(xml)
// it can now be passed to the XML-RPC parser
xmlRpcParser.parse(tree)
```

1
@vates/xml-rpc/.npmignore Symbolic link
View File

@@ -0,0 +1 @@
../../scripts/npmignore

161
@vates/xml-rpc/README.md Normal file
View File

@@ -0,0 +1,161 @@
<!-- DO NOT EDIT MANUALLY, THIS FILE HAS BEEN GENERATED -->
# @vates/xml-rpc
[![Package Version](https://badgen.net/npm/v/@vates/xml-rpc)](https://npmjs.org/package/@vates/xml-rpc) ![License](https://badgen.net/npm/license/@vates/xml-rpc) [![PackagePhobia](https://badgen.net/bundlephobia/minzip/@vates/xml-rpc)](https://bundlephobia.com/result?p=@vates/xml-rpc) [![Node compatibility](https://badgen.net/npm/node/@vates/xml-rpc)](https://npmjs.org/package/@vates/xml-rpc)
> Parse and format XML-RPC messages, do not handle transport or XML
## Install
Installation of the [npm package](https://npmjs.org/package/@vates/xml-rpc):
```sh
npm install --save @vates/xml-rpc
```
## Usage
### Formatting
```js
import { xmlRpcFormatter } from '@vates/xml-rpc/formatter'
// There is a dedicated method per XML-RPC tag (`array`, `string`, etc.)
xmlRpcFormatter.format_methodCall({
methodName: 'examples.getStateName',
params: [40],
})
// → {
// name: 'methodCall',
// children: [
// {
// name: 'methodName',
// children: [ 'examples.getStateName' ]
// },
// {
// name: 'params',
// children: [
// {
// name: 'param',
// children: [ { name: 'value', children: [ '40' ] } ]
// }
// ]
// }
// ]
// }
// There is a dedicated method to format a JS value
xmlRpcFormatter.format_js(new Date(900684535000))
// → {
// name: 'dateTime.iso8601',
// children: [ '1998-07-17T14:08:55.000Z' ]
// }
```
Formatting XML is out of this library's scope, but you can achieve it easily with
`@vates/xml`:
```js
import { formatXml } from '@vates/xml/format'
// it can now be passed to the XML-RPC parser
const tree = xmlRpcFormatter.format_methodCall({
methodName: 'examples.getStateName',
params: [40],
})
// avoid any indentation or new lines as it will confuse many XML-RPC parsers.
const xml = formatXml(tree, { indent: 0 })
```
### Parsing
```js
import { xmlRpcParser } from '@vates/xml-rpc/parser'
xmlRpcParser.parse({
name: 'methodResponse',
children: [
{
name: 'params',
children: [
{
name: 'param',
children: [
{
name: 'value',
children: [
{
name: 'string',
children: ['South Dakota'],
},
],
},
],
},
],
},
],
})
// { params: [ 'South Dakota' ] }
// There is a dedicated method per XML-RPC tag (`array`, `string`, etc.)
xmlRpcParser.parse_array({
name: 'array',
children: [
{
name: 'data',
children: [
{
name: 'value',
children: [{ name: 'boolean', children: ['1'] }],
},
{
name: 'value',
children: [{ name: 'int', children: ['42'] }],
},
],
},
],
})
// [ true, 42 ]
```
Parsing XML is out of this library's scope, but you can achieve it easily with
`@vates/xml`:
```js
import { parseXml } from '@vates/xml/parse'
const xml = `
<?xml version="1.0"?>
<methodResponse>
<params>
<param>
<value><string>South Dakota</string></value>
</param>
</params>
</methodResponse>
`
const tree = parseXml(xml)
// it can now be passed to the XML-RPC parser
xmlRpcParser.parse(tree)
```
## Contributions
Contributions are _very_ welcomed, either on the documentation or on
the code.
You may:
- report any [issue](https://github.com/vatesfr/xen-orchestra/issues)
you've encountered;
- fork and create a pull request.
## License
[ISC](https://spdx.org/licenses/ISC) © [Vates SAS](https://vates.fr)

104
@vates/xml-rpc/formatter.js Normal file
View File

@@ -0,0 +1,104 @@
'use strict'
function node(name, attributes, children) {
if (Array.isArray(attributes)) {
children = attributes
attributes = undefined
}
return { name, attributes, children }
}
class XmlRpcFormatter {
format_js(value) {
const type = typeof value
if (type === 'object') {
return value === null
? this.format_nil()
: value instanceof Date
? this['format_dateTime.iso8601'](value)
: Array.isArray(value)
? this.format_array(value)
: Buffer.isBuffer(value)
? this.format_base64(value)
: this.format_struct(value)
}
return this['format_' + type](value)
}
format_array(values) {
return node('array', [node('data', values.map(this.format_value, this))])
}
format_base64(buf) {
return node('base64', [buf.toString('base64')])
}
format_boolean(bool) {
return node('boolean', [bool ? '1' : '0'])
}
'format_dateTime.iso8601'(date) {
return node('dateTime.iso8601', [date.toISOString()])
}
format_double(str) {
return node('double', [String(str)])
}
format_fault(val) {
return node('fault', [this.format_value(val)])
}
format_i4(str) {
return node('i4', [String(str)])
}
format_int(str) {
return node('int', [String(str)])
}
format_member([name, value]) {
return node('member', [node('name', [name]), this.format_value(value)])
}
format_methodCall({ methodName, params }) {
return node('methodCall', [node('methodName', [methodName]), this.format_params(params)])
}
format_methodResponse({ fault, params }) {
return node('methodResponse', [fault !== undefined ? this.format_fault(fault) : this.format_params(params)])
}
format_nil() {
return node('nil')
}
format_number(num) {
return Number.isInteger(num) ? this.format_int(num) : this.format_double(num)
}
format_param(value) {
return node('param', [this.format_value(value)])
}
format_params(params) {
return node('params', params.map(this.format_param, this))
}
format_string(str) {
return str
}
format_struct(struct) {
return node('struct', Object.entries(struct).map(this.format_member, this))
}
format_value(value) {
return node('value', [this.format_js(value)])
}
}
exports.Formatter = XmlRpcFormatter
exports.xmlRpcFormatter = new XmlRpcFormatter()

View File

@@ -0,0 +1,33 @@
{
"private": false,
"name": "@vates/xml-rpc",
"description": "Parse and format XML-RPC messages, do not handle transport or XML",
"homepage": "https://github.com/vatesfr/xen-orchestra/tree/master/@vates/xml-rpc",
"bugs": "https://github.com/vatesfr/xen-orchestra/issues",
"repository": {
"directory": "@vates/xml-rpc",
"type": "git",
"url": "https://github.com/vatesfr/xen-orchestra.git"
},
"author": {
"name": "Vates SAS",
"url": "https://vates.fr"
},
"license": "ISC",
"version": "1.0.0",
"engines": {
"node": ">=12"
},
"devDependencies": {
"@vates/xml": "^2.0.0",
"test": "^3.3.0"
},
"exports": {
"./formatter": "./formatter.js",
"./parser": "./parser.js"
},
"scripts": {
"postversion": "npm publish --access public",
"test": "node--test"
}
}

133
@vates/xml-rpc/parser.js Normal file
View File

@@ -0,0 +1,133 @@
'use strict'
function toValue(node) {
const obj = { __proto__: null }
for (const child of node.children) {
if (typeof child === 'string') {
return child
}
const { name } = child
if (Object.hasOwn(obj, name)) {
const prev = obj[name]
if (Array.isArray(obj, name)) {
prev.push(child)
} else {
obj[name] = [prev, child]
}
} else {
obj[name] = child
}
}
return obj
}
// https://en.wikipedia.org/wiki/XML-RPC#Data_types
class XmlRpcParser {
parse(node) {
return this['parse_' + node.name](node)
}
parse_array({ children: [data] }) {
return data.children.map(this.parse_value, this)
}
parse_base64({ children: [str] }) {
return Buffer.from(str, 'base64')
}
parse_boolean({ children: [str] }) {
return Boolean(Number(str))
}
'parse_dateTime.iso8601'({ children: [str] }) {
const date = new Date(str)
// date successfully parsed
if (!Number.isNaN(+date)) {
return date
}
// XML-RPC dates may use YYYYMMDD instead of YYYY-MM-DD which ECMAScript
// does not parse
return new Date(str.slice(0, 4) + '-' + str.slice(4, 6) + '-' + str.slice(6))
}
parse_double({ children: [str] }) {
return Number(str)
}
parse_fault({ children: [value] }) {
return this.parse_value(value)
}
parse_i4({ children: [str] }) {
return Number(str)
}
parse_int({ children: [str] }) {
return Number(str)
}
parse_member(member) {
member = toValue(member)
return [member.name.children[0], this.parse_value(member.value)]
}
parse_methodCall(methodCall) {
methodCall = toValue(methodCall)
return {
methodName: methodCall.methodName.children[0],
params: this.parse_params(methodCall.params),
}
}
parse_methodResponse(methodResponse) {
methodResponse = toValue(methodResponse)
const { fault } = methodResponse
if (fault !== undefined) {
return { fault: this.parse_fault(fault) }
}
return { params: this.parse_params(methodResponse.params) }
}
parse_nil() {
return null
}
parse_param(param) {
return this.parse_value(param.children[0])
}
parse_params(params) {
return params.children.map(this.parse_param, this)
}
parse_string({ children: [str] }) {
return str
}
parse_struct(struct) {
return Object.fromEntries(struct.children.map(this.parse_member, this))
}
parse_value({ children }) {
if (children.length === 0) {
return ''
}
const child = children[0]
// can be a plain string
if (typeof child === 'string') {
return child
}
return this.parse(child)
}
}
exports.XmlRpcParser = XmlRpcParser
exports.xmlRpcParser = new XmlRpcParser()

View File

@@ -0,0 +1,19 @@
'use strict'
const { formatXml } = require('@vates/xml/format')
const { join } = require('node:path')
const { parseXml } = require('@vates/xml/parse')
const { readFileSync } = require('node:fs')
const { xmlRpcFormatter } = require('@vates/xml-rpc/formatter')
const assert = require('node:assert/strict')
const test = require('test')
const methodCall = require('./methodCall.js')
test(function () {
const xmlTree = parseXml(readFileSync(join(__dirname, 'methodCall.xml')))
const xmlRpc = xmlRpcFormatter.format_methodCall(methodCall)
assert.deepEqual(parseXml(formatXml(xmlRpc)), xmlTree)
})

View File

@@ -0,0 +1,16 @@
'use strict'
module.exports = {
methodName: 'examples.getStateName',
params: [
[1404, 'Something here'],
Buffer.from([121, 111, 117, 32, 99, 97, 110, 39, 116, 32, 114, 101, 97, 100, 32, 116, 104, 105, 115, 33]),
true,
new Date('1998-07-17T14:08:55.000Z'),
-12.53,
42,
'Hello world!',
{ foo: 1, bar: 2 },
null,
],
}

View File

@@ -0,0 +1,73 @@
<?xml version="1.0" encoding="UTF-8"?>
<methodCall>
<methodName>examples.getStateName</methodName>
<params>
<param>
<value>
<array>
<data>
<value>
<int>1404</int>
</value>
<value>
Something here
</value>
</data>
</array>
</value>
</param>
<param>
<value>
<base64>eW91IGNhbid0IHJlYWQgdGhpcyE=</base64>
</value>
</param>
<param>
<value>
<boolean>1</boolean>
</value>
</param>
<param>
<value>
<dateTime.iso8601>1998-07-17T14:08:55.000Z</dateTime.iso8601>
</value>
</param>
<param>
<value>
<double>-12.53</double>
</value>
</param>
<param>
<value>
<int>42</int>
</value>
</param>
<param>
<value>
Hello world!
</value>
</param>
<param>
<value>
<struct>
<member>
<name>foo</name>
<value>
<int>1</int>
</value>
</member>
<member>
<name>bar</name>
<value>
<int>2</int>
</value>
</member>
</struct>
</value>
</param>
<param>
<value>
<nil />
</value>
</param>
</params>
</methodCall>

View File

@@ -0,0 +1,32 @@
'use strict'
const { join } = require('node:path')
const { parseXml } = require('@vates/xml/parse')
const { readFileSync } = require('node:fs')
const { xmlRpcParser } = require('@vates/xml-rpc/parser')
const assert = require('node:assert/strict')
const test = require('test')
const methodCall = require('./methodCall.js')
test('parser.parse()', function () {
const xml = String(readFileSync(join(__dirname, 'methodCall.xml')))
const xmlRpc = parseXml(xml)
assert.deepEqual(xmlRpcParser.parse(xmlRpc), methodCall)
})
test('datetime without dashes nor milliseconds', function () {
assert.deepEqual(
xmlRpcParser.parse({ name: 'dateTime.iso8601', children: ['19980717T14:08:55Z'] }),
new Date('1998-07-17T14:08:55Z')
)
})
test('i4 support', function () {
assert.equal(xmlRpcParser.parse({ name: 'i4', children: ['42'] }), 42)
})
test('string support', function () {
assert.equal(xmlRpcParser.parse({ name: 'string', children: ['foo'] }), 'foo')
})

56
@vates/xml/.USAGE.md Normal file
View File

@@ -0,0 +1,56 @@
### `parseXml(xml, [opts])`
> Based on [`sax`](https://www.npmjs.com/package/sax)
`opts` is an optional object which can contain the following options:
- `normalize = true`: if true, then turn any whitespace into a single space
- `strict = true`: whether or not to be a jerk
- `trim = true`: whether or not to trim text nodes
```js
import { parseXml } from '@xen-orchestra/xml/parse'
const tree = parseXml(`<?xml version="1.0" encoding="UTF-8"?>
<tag1 attr1="value1" attr2="value2">
Text &amp; entities
<tag2 />
<tag2 />
<ns:tag3 />
</tag1>
`)
// → {
// name: 'tag1',
// attributes: { attr1: 'value1', attr2: 'value2' },
// children: [
// 'Text & entities',
// { name: 'tag2', attributes: {}, children: [] },
// { name: 'tag2', attributes: {}, children: [] },
// { name: 'ns:tag3', attributes: {}, children: [] }
// ]
// }
```
### `formatXml(tree, [opts])`
`opts` is an optional object which can contain the following options:
- `includeDeclaration = true`: whether to include an XML declaration
- `indent = 2`: string or number of spaces to use to indent; if an empty string or `0`, no indent or new lines will be used
```js
import { formatXml } from '@xen-orchestra/xml/format'
formatXml({
name: 'tag1',
attributes: { attr1: 'value1', attr2: 'value2' },
children: ['Text & entities', { name: 'tag2' }, { name: 'tag2' }, { name: 'ns:tag3' }],
})
// → <?xml version="1.0" encoding="UTF-8"?>
// <tag1 attr1="value1" attr2="value2">
// Text &amp; entities
// <tag2 />
// <tag2 />
// <ns:tag3 />
// </tag1>
```

1
@vates/xml/.npmignore Symbolic link
View File

@@ -0,0 +1 @@
../../scripts/npmignore

89
@vates/xml/README.md Normal file
View File

@@ -0,0 +1,89 @@
<!-- DO NOT EDIT MANUALLY, THIS FILE HAS BEEN GENERATED -->
# @vates/xml
[![Package Version](https://badgen.net/npm/v/@vates/xml)](https://npmjs.org/package/@vates/xml) ![License](https://badgen.net/npm/license/@vates/xml) [![PackagePhobia](https://badgen.net/bundlephobia/minzip/@vates/xml)](https://bundlephobia.com/result?p=@vates/xml) [![Node compatibility](https://badgen.net/npm/node/@vates/xml)](https://npmjs.org/package/@vates/xml)
> Simple XML formatting/parsing
## Install
Installation of the [npm package](https://npmjs.org/package/@vates/xml):
```sh
npm install --save @vates/xml
```
## Usage
### `parseXml(xml, [opts])`
> Based on [`sax`](https://www.npmjs.com/package/sax)
`opts` is an optional object which can contain the following options:
- `normalize = true`: if true, then turn any whitespace into a single space
- `strict = true`: whether or not to be a jerk
- `trim = true`: whether or not to trim text nodes
```js
import { parseXml } from '@xen-orchestra/xml/parse'
const tree = parseXml(`<?xml version="1.0" encoding="UTF-8"?>
<tag1 attr1="value1" attr2="value2">
Text &amp; entities
<tag2 />
<tag2 />
<ns:tag3 />
</tag1>
`)
// → {
// name: 'tag1',
// attributes: { attr1: 'value1', attr2: 'value2' },
// children: [
// 'Text & entities',
// { name: 'tag2', attributes: {}, children: [] },
// { name: 'tag2', attributes: {}, children: [] },
// { name: 'ns:tag3', attributes: {}, children: [] }
// ]
// }
```
### `formatXml(tree, [opts])`
`opts` is an optional object which can contain the following options:
- `includeDeclaration = true`: whether to include an XML declaration
- `indent = 2`: string or number of spaces to use to indent; if an empty string or `0`, no indent or new lines will be used
```js
import { formatXml } from '@xen-orchestra/xml/format'
formatXml({
name: 'tag1',
attributes: { attr1: 'value1', attr2: 'value2' },
children: ['Text & entities', { name: 'tag2' }, { name: 'tag2' }, { name: 'ns:tag3' }],
})
// → <?xml version="1.0" encoding="UTF-8"?>
// <tag1 attr1="value1" attr2="value2">
// Text &amp; entities
// <tag2 />
// <tag2 />
// <ns:tag3 />
// </tag1>
```
## Contributions
Contributions are _very_ welcomed, either on the documentation or on
the code.
You may:
- report any [issue](https://github.com/vatesfr/xen-orchestra/issues)
you've encountered;
- fork and create a pull request.
## License
[ISC](https://spdx.org/licenses/ISC) © [Vates SAS](https://vates.fr)

30
@vates/xml/cli.js Executable file
View File

@@ -0,0 +1,30 @@
#!/usr/bin/env node
'use strict'
const { inspect } = require('node:util')
const { formatXml } = require('@vates/xml/format')
const { parseXml } = require('@vates/xml/parse')
const { readFileSync } = require('node:fs')
function log(val) {
process.stdout.write(inspect(val, false, null, true))
process.stdout.write('\n')
}
function main([inputPath = 0]) {
const input = readFileSync(inputPath)
// attempt to parse from JSON
let data
try {
data = JSON.parse(input)
} catch (error) {
// fallback to XML
log(parseXml(input))
return
}
process.stdout.write(formatXml(data))
}
main(process.argv.slice(2))

64
@vates/xml/format.js Normal file
View File

@@ -0,0 +1,64 @@
'use strict'
const ENTITIES = {
'"': '&quot;',
'&': '&amp;',
'<': '&lt;',
'>': '&gt;',
"'": '&apos;',
}
const RE = new RegExp(Object.keys(ENTITIES).join('|'), 'g')
function replace(match) {
return ENTITIES[match]
}
function escape(str) {
return str.replace(RE, replace)
}
function formatNode(node, depth) {
const indent = this.indent.repeat(depth)
if (typeof node === 'object') {
const line = [indent, '<', node.name]
const { attributes } = node
if (attributes !== undefined) {
for (const name of Object.keys(attributes)) {
line.push(' ', name, '="', escape(attributes[name]), '"')
}
}
const { children } = node
if (children === undefined || children.length === 0) {
line.push(' />')
this.lines.push(line.join(''))
} else {
line.push('>')
this.lines.push(line.join(''))
for (const child of children) {
formatNode.call(this, child, depth + 1)
}
this.lines.push(indent + '</' + node.name + '>')
}
} else {
// string (or scalar)
this.lines.push(indent + escape(String(node)))
}
}
exports.formatXml = function formatXml(tree, { includeDeclaration = true, indent = 2 } = {}) {
const lines = []
if (includeDeclaration) {
lines.push('<?xml version="1.0" encoding="UTF-8"?>')
}
const ctx = {
lines,
indent: typeof indent === 'number' ? ' '.repeat(indent) : indent,
}
formatNode.call(ctx, tree, 0)
return lines.join(indent !== 0 && indent !== '' ? '\n' : '')
}

35
@vates/xml/package.json Normal file
View File

@@ -0,0 +1,35 @@
{
"private": false,
"name": "@vates/xml",
"description": "Simple XML formatting/parsing",
"homepage": "https://github.com/vatesfr/xen-orchestra/tree/master/@vates/xml",
"bugs": "https://github.com/vatesfr/xen-orchestra/issues",
"repository": {
"directory": "@vates/xml",
"type": "git",
"url": "https://github.com/vatesfr/xen-orchestra.git"
},
"author": {
"name": "Vates SAS",
"url": "https://vates.fr"
},
"license": "ISC",
"version": "2.0.0",
"engines": {
"node": ">=14"
},
"dependencies": {
"sax": "^1.3.0"
},
"devDependencies": {
"test": "^3.3.0"
},
"exports": {
"./format": "./format.js",
"./parse": "./parse.js"
},
"scripts": {
"postversion": "npm publish --access public",
"test": "node--test"
}
}

23
@vates/xml/parse.js Normal file
View File

@@ -0,0 +1,23 @@
'use strict'
const sax = require('sax')
exports.parseXml = function parseXml(xml, { normalize = true, strict = true, trim = true } = {}) {
const stack = [{ children: [] }]
const parser = sax.parser(strict, { normalize, trim })
parser.ontext = text => {
stack[stack.length - 1].children.push(text)
}
parser.onopentag = ({ name, attributes }) => {
stack.push({ name, attributes, children: [] })
}
parser.onclosetag = () => {
const node = stack.pop()
stack[stack.length - 1].children.push(node)
}
parser.write(xml).close()
return stack[0].children[0]
}

25
@vates/xml/test/data.json Normal file
View File

@@ -0,0 +1,25 @@
{
"name": "tag1",
"attributes": {
"attr1": "value1",
"attr2": "value2"
},
"children": [
"Text & entities",
{
"name": "tag2",
"attributes": {},
"children": []
},
{
"name": "tag2",
"attributes": {},
"children": []
},
{
"name": "ns:tag3",
"attributes": {},
"children": []
}
]
}

7
@vates/xml/test/data.xml Normal file
View File

@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<tag1 attr1="value1" attr2="value2">
Text &amp; entities
<tag2 />
<tag2 />
<ns:tag3 />
</tag1>

18
@vates/xml/test/format.js Normal file
View File

@@ -0,0 +1,18 @@
'use strict'
const { formatXml } = require('@vates/xml/format')
const { join } = require('node:path')
const { readFileSync } = require('node:fs')
const assert = require('node:assert/strict')
const test = require('test')
test('format()', function () {
const xml = String(readFileSync(join(__dirname, 'data.xml')))
const tree = JSON.parse(readFileSync(join(__dirname, 'data.json')))
assert.equal(formatXml(tree) + '\n', xml)
})
test('supports missing attributes and children', function () {
assert.equal(formatXml({ name: 'foo' }, { includeDeclaration: false }), '<foo />')
})

14
@vates/xml/test/parse.js Normal file
View File

@@ -0,0 +1,14 @@
'use strict'
const { parseXml } = require('@vates/xml/parse')
const { readFileSync } = require('node:fs')
const { join } = require('node:path')
const assert = require('node:assert/strict')
const test = require('test')
test('parse()', function () {
const xml = String(readFileSync(join(__dirname, 'data.xml')))
const tree = JSON.parse(readFileSync(join(__dirname, 'data.json')))
assert.deepEqual(parseXml(xml), tree)
})

View File

@@ -35,7 +35,7 @@
"test": "node--test"
},
"devDependencies": {
"sinon": "^17.0.1",
"sinon": "^18.0.0",
"test": "^3.2.1"
}
}

View File

@@ -130,6 +130,10 @@ class AuditCore {
return nValid
}
get(id) {
return this._storage.get(id)
}
async *getFrom(newest) {
const storage = this._storage

View File

@@ -7,7 +7,7 @@
"type": "git",
"url": "https://github.com/vatesfr/xen-orchestra.git"
},
"version": "0.2.3",
"version": "0.3.0",
"engines": {
"node": ">=14"
},

View File

@@ -7,8 +7,8 @@
"bugs": "https://github.com/vatesfr/xen-orchestra/issues",
"dependencies": {
"@xen-orchestra/async-map": "^0.1.2",
"@xen-orchestra/backups": "^0.45.0",
"@xen-orchestra/fs": "^4.1.5",
"@xen-orchestra/backups": "^0.54.0",
"@xen-orchestra/fs": "^4.1.7",
"filenamify": "^6.0.0",
"getopts": "^2.2.5",
"lodash": "^4.17.15",
@@ -27,7 +27,7 @@
"scripts": {
"postversion": "npm publish --access public"
},
"version": "1.0.15",
"version": "1.0.25",
"license": "AGPL-3.0-or-later",
"author": {
"name": "Vates SAS",

View File

@@ -49,26 +49,25 @@ export class HealthCheckVmBackup {
}
// wait for the 'Running' event to be really stored in local xapi object cache
restoredVm = await xapi.waitObjectState(restoredVm.$ref, vm => vm.power_state === 'Running', {
timeout: remainingTimeout,
timeoutMessage: refOrUuid =>
`local xapi did not get Running state for VM ${refOrUuid} after ${timeout / 1000} second`,
})
const running = new Date()
remainingTimeout -= running - started
if (remainingTimeout < 0) {
throw new Error(`local xapi did not get Running state for VM ${restoredId} after ${timeout / 1000} second`)
}
// wait for the guest tool version to be defined
await xapi.waitObjectState(restoredVm.guest_metrics, gm => gm?.PV_drivers_version?.major !== undefined, {
timeout: remainingTimeout,
timeoutMessage: refOrUuid =>
`timeout reached while waiting for ${refOrUuid} to report the driver version through the Xen tools. Please check or update the Xen tools.`,
})
const guestToolsReady = new Date()
remainingTimeout -= guestToolsReady - running
if (remainingTimeout < 0) {
throw new Error(`local xapi did not get he guest tools check ${restoredId} after ${timeout / 1000} second`)
}
if (waitForScript) {
const startedRestoredVm = await xapi.waitObjectState(
@@ -79,19 +78,10 @@ export class HealthCheckVmBackup {
vm.xenstore_data['vm-data/xo-backup-health-check'] === 'failure'),
{
timeout: remainingTimeout,
timeoutMessage: refOrUuid =>
`timeout reached while waiting for ${refOrUuid} to report the startup script execution.`,
}
)
const scriptOk = new Date()
remainingTimeout -= scriptOk - guestToolsReady
if (remainingTimeout < 0) {
throw new Error(
`Backup health check script did not update vm-data/xo-backup-health-check of ${restoredId} after ${
timeout / 1000
} second, got ${
startedRestoredVm.xenstore_data['vm-data/xo-backup-health-check']
} instead of 'success' or 'failure'`
)
}
if (startedRestoredVm.xenstore_data['vm-data/xo-backup-health-check'] !== 'success') {
const message = startedRestoredVm.xenstore_data['vm-data/xo-backup-health-check-error']

View File

@@ -18,6 +18,7 @@ import fromEvent from 'promise-toolbox/fromEvent'
import groupBy from 'lodash/groupBy.js'
import pDefer from 'promise-toolbox/defer'
import pickBy from 'lodash/pickBy.js'
import reduce from 'lodash/reduce.js'
import tar from 'tar'
import zlib from 'zlib'
@@ -826,6 +827,29 @@ export class RemoteAdapter {
}
return metadata
}
#computeTotalBackupSizeRecursively(backups) {
return reduce(
backups,
(prev, backup) => {
const _backup = Array.isArray(backup) ? this.#computeTotalBackupSizeRecursively(backup) : backup
return {
onDisk: prev.onDisk + (_backup.onDisk ?? _backup.size),
}
},
{ onDisk: 0 }
)
}
async getTotalVmBackupSize() {
return this.#computeTotalBackupSizeRecursively(await this.listAllVmBackups())
}
async getTotalBackupSize() {
const vmBackupSize = await this.getTotalVmBackupSize()
// @TODO: add `getTotalXoBackupSize` and `getTotalPoolBackupSize` once `size` is implemented by fs
return vmBackupSize
}
}
Object.assign(RemoteAdapter.prototype, {

View File

@@ -2,7 +2,10 @@ import { createLogger } from '@xen-orchestra/log'
import { catchGlobalErrors } from '@xen-orchestra/log/configure'
import Disposable from 'promise-toolbox/Disposable'
import humanFormat from 'human-format'
import ignoreErrors from 'promise-toolbox/ignoreErrors'
import mapValues from 'lodash/mapValues.js'
import ms from 'ms'
import { compose } from '@vates/compose'
import { createCachedLookup } from '@vates/cached-dns.lookup'
import { createDebounceResource } from '@vates/disposable/debounceResource.js'
@@ -20,7 +23,7 @@ createCachedLookup().patchGlobal()
const logger = createLogger('xo:backups:worker')
catchGlobalErrors(logger)
const { debug } = logger
const { debug, info, warn } = logger
class BackupWorker {
#config
@@ -149,6 +152,27 @@ process.on('message', async message => {
debug('message received', { message })
if (message.action === 'run') {
const resourceStart = process.resourceUsage()
const timeStart = process.hrtime.bigint()
info('starting backup')
process.on('exit', exitCode => {
const resourceUsage = mapValues(process.resourceUsage(), (end, key) => end - resourceStart[key])
const cpuTotal = resourceUsage.userCPUTime + resourceUsage.systemCPUTime
const duration = Number((process.hrtime.bigint() - timeStart) / 1000n) // in μs
info('process will exit', {
duration,
exitCode,
resourceUsage,
summary: {
duration: ms(duration / 1000),
cpuUsage: Math.round((100 * cpuTotal) / duration) + '%',
memoryUsage: humanFormat.bytes(resourceUsage.maxRSS * 1024),
},
})
})
const backupWorker = new BackupWorker(message.data)
try {
const result = message.runWithLogs
@@ -177,8 +201,16 @@ process.on('message', async message => {
status: 'failure',
})
} finally {
info('backup has ended')
await ignoreErrors.call(backupWorker.debounceResource.flushAll())
process.disconnect()
setTimeout(() => {
warn('worker process did not exit automatically, forcing...')
// eslint-disable-next-line n/no-process-exit
process.exit()
}, 30e3).unref()
}
}
})

View File

@@ -3,7 +3,7 @@ import sum from 'lodash/sum.js'
import { asyncMap } from '@xen-orchestra/async-map'
import { Constants, openVhd, VhdAbstract, VhdFile } from 'vhd-lib'
import { isVhdAlias, resolveVhdAlias } from 'vhd-lib/aliases.js'
import { dirname, resolve } from 'node:path'
import { basename, dirname, resolve } from 'node:path'
import { isMetadataFile, isVhdFile, isXvaFile, isXvaSumFile } from './_backupType.mjs'
import { limitConcurrency } from 'limit-concurrency-decorator'
import { mergeVhdChain } from 'vhd-lib/merge.js'
@@ -179,7 +179,8 @@ export async function cleanVm(
vmDir,
{
fixMetadata,
remove,
remove = false,
removeTmp = remove,
merge,
mergeBlockConcurrency,
mergeLimiter = defaultMergeLimiter,
@@ -200,6 +201,10 @@ export async function cleanVm(
// remove broken VHDs
await asyncMap(vhds, async path => {
if(removeTmp && basename(path)[0] === '.'){
logInfo('deleting temporary VHD', { path })
return VhdAbstract.unlink(handler, path)
}
try {
await Disposable.use(openVhd(handler, path, { checkSecondFooter: !interruptedVhds.has(path) }), vhd => {
if (vhd.footer.diskType === DISK_TYPES.DIFFERENCING) {

View File

@@ -1,52 +1,23 @@
import groupBy from 'lodash/groupBy.js'
import ignoreErrors from 'promise-toolbox/ignoreErrors'
import omit from 'lodash/omit.js'
import { asyncMap } from '@xen-orchestra/async-map'
import { CancelToken } from 'promise-toolbox'
import { compareVersions } from 'compare-versions'
import { createVhdStreamWithLength } from 'vhd-lib'
import { defer } from 'golike-defer'
import { cancelableMap } from './_cancelableMap.mjs'
import { Task } from './Task.mjs'
import pick from 'lodash/pick.js'
// in `other_config` of an incrementally replicated VM, contains the UUID of the source VM
export const TAG_BASE_DELTA = 'xo:base_delta'
// in `other_config` of an incrementally replicated VM, contains the UUID of the target SR used for replication
//
// added after the complete replication
export const TAG_BACKUP_SR = 'xo:backup:sr'
// in other_config of VDIs of an incrementally replicated VM, contains the UUID of the source VDI
export const TAG_COPY_SRC = 'xo:copy_of'
import { BASE_DELTA_VDI, COPY_OF, VM_UUID } from './_otherConfig.mjs'
const ensureArray = value => (value === undefined ? [] : Array.isArray(value) ? value : [value])
export async function exportIncrementalVm(
vm,
baseVm,
{
cancelToken = CancelToken.none,
// Sets of UUIDs of VDIs that must be exported as full.
fullVdisRequired = new Set(),
disableBaseTags = false,
nbdConcurrency = 1,
preferNbd,
} = {}
baseVdis = {},
{ cancelToken = CancelToken.none, nbdConcurrency = 1, preferNbd } = {}
) {
// refs of VM's VDIs → base's VDIs.
const baseVdis = {}
baseVm &&
baseVm.$VBDs.forEach(vbd => {
let vdi, snapshotOf
if ((vdi = vbd.$VDI) && (snapshotOf = vdi.$snapshot_of) && !fullVdisRequired.has(snapshotOf.uuid)) {
baseVdis[vdi.snapshot_of] = vdi
}
})
const streams = {}
const vdis = {}
@@ -67,13 +38,16 @@ export async function exportIncrementalVm(
}
// Look for a snapshot of this vdi in the base VM.
const baseVdi = baseVdis[vdi.snapshot_of]
const baseVdi = baseVdis[vdi.$snapshot_of.uuid]
vdis[vdiRef] = {
...vdi,
other_config: {
...vdi.other_config,
[TAG_BASE_DELTA]: baseVdi && !disableBaseTags ? baseVdi.uuid : undefined,
[BASE_DELTA_VDI]: baseVdi?.uuid,
[VM_UUID]:
vm.$snapshot_of?.uuid ?? // vm is a snapshot
vm.uuid, // vm is a not snapshot
},
$snapshot_of$uuid: vdi.$snapshot_of?.uuid,
$SR$uuid: vdi.$SR.uuid,
@@ -120,13 +94,6 @@ export async function exportIncrementalVm(
vifs,
vm: {
...vm,
other_config:
baseVm && !disableBaseTags
? {
...vm.other_config,
[TAG_BASE_DELTA]: baseVm.uuid,
}
: omit(vm.other_config, TAG_BASE_DELTA),
},
},
'streams',
@@ -205,7 +172,7 @@ export const importIncrementalVm = defer(async function importIncrementalVm(
newVdi = await xapi.getRecord('VDI', await vdi.baseVdi.$clone())
$defer.onFailure(() => newVdi.$destroy())
await newVdi.update_other_config(TAG_COPY_SRC, vdi.uuid)
await newVdi.update_other_config(COPY_OF, vdi.uuid)
if (vdi.virtual_size > newVdi.virtual_size) {
await newVdi.$callAsync('resize', vdi.virtual_size)
}
@@ -259,9 +226,6 @@ export const importIncrementalVm = defer(async function importIncrementalVm(
if (typeof stream === 'function') {
stream = await stream()
}
if (stream.length === undefined) {
stream = await createVhdStreamWithLength(stream)
}
await xapi.setField('VDI', vdi.$ref, 'name_label', `[Importing] ${vdiRecords[id].name_label}`)
await vdi.$importContent(stream, { cancelToken, format: 'vhd' })
await xapi.setField('VDI', vdi.$ref, 'name_label', vdiRecords[id].name_label)

View File

@@ -0,0 +1,165 @@
import { formatDateTime } from '@xen-orchestra/xapi'
import assert from 'node:assert/strict'
// in `other_config` of an incrementally replicated VM or VDI
// contains the UUID of the object used as a base for an incremental export
// used to search for the replica of the base before applying a incremental replication
export const BASE_DELTA_VDI = 'xo:base_delta_vdi'
// in `other_config` of an incrementally replicated VM, contains the UUID of the target SR used for replication
//
// added after the complete replication
export const REPLICATED_TO_SR_UUID = 'xo:backup:sr'
// in other_config of VDIs of an incrementally replicated VM
// contains the UUID of the source exported object (snapshot or VM)
export const COPY_OF = 'xo:copy_of'
export const DATETIME = 'xo:backup:datetime'
export const JOB_ID = 'xo:backup:job'
export const SCHEDULE_ID = 'xo:backup:schedule'
// contains the number of delta in a chain, stored as a string
export const DELTA_CHAIN_LENGTH = 'xo:backup:deltaChainLength'
// contains the string true if this vdi has been exported successfully
export const EXPORTED_SUCCESSFULLY = 'xo:backup:exported'
// the VM ( not the snapshot) uuid
export const VM_UUID = 'xo:backup:vm'
async function listVdiRefs(xapi, vmRef) {
return xapi.VM_getDisks(vmRef)
}
async function applyToVmAndVdis(xapi, vmRef, fn) {
const vdiRefs = await listVdiRefs(xapi, vmRef)
return Promise.all([fn('VM', vmRef), ...vdiRefs.map(vdiRef => fn('VDI', vdiRef))])
}
async function getDeltaChainLength(xapi, type, ref) {
const otherConfig = await xapi.getField(type, ref, 'other_config')
return Number(otherConfig[DELTA_CHAIN_LENGTH] ?? 0)
}
/**
* set the delta chain lenght ( number of delta since last base backup) to a VM and its associated VDIs
*
* @param {Xapi} xapi
* @param {String} vmRef
* @param {Number} length
* @returns {Promise}
*/
export async function setVmDeltaChainLength(xapi, vmRef, length) {
return applyToVmAndVdis(xapi, vmRef, async (type, ref) => {
await xapi.setFieldEntry(type, ref, 'other_config', DELTA_CHAIN_LENGTH, String(length))
})
}
/**
* Compute the delta chain length of a VM and its associated VDIs
* if there is a discrependcy, use, the highest value
* @param {Xapi} xapi
* @param {String} vmRef
* @returns {Promise}
*/
export async function getVmDeltaChainLength(xapi, vmRef) {
const lengths = await applyToVmAndVdis(xapi, vmRef, async (type, ref) => getDeltaChainLength(xapi, type, ref))
return Math.max(...lengths)
}
/**
*
* Reset the other_config field of a VM and its VDIs
*
* @param {Xapi} xapi
* @param {String} vmRef
* @returns {Promise}
*/
export function resetVmOtherConfig(xapi, vmRef) {
return applyToVmAndVdis(xapi, vmRef, (type, ref) => {
return xapi.setFieldEntries(type, ref, 'other_config', {
[DATETIME]: null,
[DELTA_CHAIN_LENGTH]: null,
[EXPORTED_SUCCESSFULLY]: null,
[JOB_ID]: null,
[SCHEDULE_ID]: null,
[VM_UUID]: null,
// REPLICATED_TO_SR_UUID is not reset since we can replicate a replication
})
})
}
/**
*
* used to ensure compatibiliy with the previous snapshots that were having the config stored only into VM
*
* @param {Xapi} xapi
* @param {String} vmRef
* @returns {Promise}
*/
export async function populateVdisOtherConfig(xapi, vmRef) {
const otherConfig = await xapi.getField('VM', vmRef, 'other_config')
const {
[DATETIME]: datetime,
[DELTA_CHAIN_LENGTH]: chainLength,
[EXPORTED_SUCCESSFULLY]: successfully,
[JOB_ID]: jobId,
[REPLICATED_TO_SR_UUID]: replicatedTo,
[SCHEDULE_ID]: scheduleId,
[VM_UUID]: vmUuid,
} = otherConfig
return applyToVmAndVdis(xapi, vmRef, (type, ref) =>
xapi.setFieldEntries(type, ref, 'other_config', {
[DATETIME]: datetime,
[DELTA_CHAIN_LENGTH]: chainLength,
[EXPORTED_SUCCESSFULLY]: successfully,
[JOB_ID]: jobId,
[REPLICATED_TO_SR_UUID]: replicatedTo,
[SCHEDULE_ID]: scheduleId,
[VM_UUID]: vmUuid,
})
)
}
/**
*
* set the other_config key related to a backup of a VM and its associated VDIs
*
* @param {Xapi} xapi
* @param {String} vmRef
* @param {*} settings
* @returns {PRomise}
*/
export async function setVmOtherConfig(xapi, vmRef, { timestamp, jobId, scheduleId, vmUuid, srUuid = null, ...other }) {
assert.notEqual(timestamp, undefined)
assert.notEqual(jobId, undefined)
assert.notEqual(scheduleId, undefined)
assert.notEqual(vmUuid, undefined)
// srUuid is nullish for backup
assert.equal(Object.keys(other).length, 0)
return applyToVmAndVdis(xapi, vmRef, (type, ref) =>
xapi.setFieldEntries(type, ref, 'other_config', {
[REPLICATED_TO_SR_UUID]: srUuid,
[DATETIME]: formatDateTime(timestamp),
[JOB_ID]: jobId,
[SCHEDULE_ID]: scheduleId,
[VM_UUID]: vmUuid,
})
)
}
/**
*
* mark the export of he VM and its VDIs as successfull
*
* @param {Xapi} xapi
* @param {String} vmRef
* @returns {Promise}
*/
export async function markExportSuccessfull(xapi, vmRef) {
return applyToVmAndVdis(xapi, vmRef, (type, ref) =>
xapi.setFieldEntry(type, ref, 'other_config', EXPORTED_SUCCESSFULLY, 'true')
)
}

View File

@@ -19,6 +19,7 @@ const DEFAULT_REMOTE_VM_SETTINGS = {
exportRetention: 0,
healthCheckSr: undefined,
healthCheckVmsWithTags: [],
healthCheckTimeout: '10m',
maxExportRate: 0,
maxMergedDeltasPerRun: Infinity,
nRetriesVmBackupFailures: 0,

View File

@@ -15,6 +15,7 @@ const noop = Function.prototype
const DEFAULT_XAPI_VM_SETTINGS = {
bypassVdiChainsCheck: false,
cbtDestroySnapshotData: false,
checkpointSnapshot: false,
concurrency: 2,
copyRetention: 0,
@@ -24,6 +25,7 @@ const DEFAULT_XAPI_VM_SETTINGS = {
fullInterval: 0,
healthCheckSr: undefined,
healthCheckVmsWithTags: [],
healthCheckTimeout: '10m',
maxExportRate: 0,
maxMergedDeltasPerRun: Infinity,
nRetriesVmBackupFailures: 0,

View File

@@ -31,7 +31,7 @@ export class PoolMetadataBackup {
const poolDir = `${DIR_XO_POOL_METADATA_BACKUPS}/${schedule.id}/${pool.$id}`
const dir = `${poolDir}/${formatFilenameDate(timestamp)}`
const stream = await this._exportPoolMetadata()
const stream = (await this._exportPoolMetadata()).body
const fileName = `${dir}/data`
const metadata = JSON.stringify(

View File

@@ -29,6 +29,10 @@ export function forkStreamUnpipe(source) {
if (source.forks === 0) {
debug('no more forks, destroying original stream')
source.destroy(new Error('no more consumers for this stream'))
} else {
// a combination of stream.unpipe, onReadable and onData may stall stream here
// force it to flow again since we're piping it
source.resume()
}
})
return fork

View File

@@ -1,52 +1,40 @@
import { decorateMethodsWith } from '@vates/decorate-with'
import { defer } from 'golike-defer'
import { AbstractRemote } from './_AbstractRemote.mjs'
import { FullRemoteWriter } from '../_writers/FullRemoteWriter.mjs'
import { forkStreamUnpipe } from '../_forkStreamUnpipe.mjs'
import { watchStreamSize } from '../../_watchStreamSize.mjs'
import { Task } from '../../Task.mjs'
export const FullRemote = class FullRemoteVmBackupRunner extends AbstractRemote {
_getRemoteWriter() {
return FullRemoteWriter
}
async _run($defer) {
_filterTransferList(transferList) {
return transferList.filter(this._filterPredicate)
}
async _run() {
const transferList = await this._computeTransferList(({ mode }) => mode === 'full')
await this._callWriters(async writer => {
await writer.beforeBackup()
$defer(async () => {
await writer.afterBackup()
})
}, 'writer.beforeBackup()')
if (transferList.length > 0) {
for (const metadata of transferList) {
const stream = await this._sourceRemoteAdapter.readFullVmBackup(metadata)
const sizeContainer = watchStreamSize(stream)
for (const metadata of transferList) {
const stream = await this._sourceRemoteAdapter.readFullVmBackup(metadata)
const sizeContainer = watchStreamSize(stream)
// @todo shouldn't transfer backup if it will be deleted by retention policy (higher retention on source than destination)
await this._callWriters(
writer =>
writer.run({
stream: forkStreamUnpipe(stream),
// stream will be forked and transformed, it's not safe to attach additionnal properties to it
streamLength: stream.length,
timestamp: metadata.timestamp,
vm: metadata.vm,
vmSnapshot: metadata.vmSnapshot,
sizeContainer,
}),
'writer.run()'
)
// for healthcheck
this._tags = metadata.vm.tags
}
} else {
Task.info('No new data to upload for this VM')
// @todo shouldn't transfer backup if it will be deleted by retention policy (higher retention on source than destination)
await this._callWriters(
writer =>
writer.run({
stream: forkStreamUnpipe(stream),
// stream will be forked and transformed, it's not safe to attach additionnal properties to it
streamLength: stream.length,
timestamp: metadata.timestamp,
vm: metadata.vm,
vmSnapshot: metadata.vmSnapshot,
sizeContainer,
}),
'writer.run()'
)
// for healthcheck
this._tags = metadata.vm.tags
}
}
}
decorateMethodsWith(FullRemote, {
_run: defer,
})

View File

@@ -30,10 +30,12 @@ export const FullXapi = class FullXapiVmBackupRunner extends AbstractXapi {
const vm = this._vm
const exportedVm = this._exportedVm
const stream = this._throttleStream(
await this._xapi.VM_export(exportedVm.$ref, {
compress: Boolean(compression) && (compression === 'native' ? 'gzip' : 'zstd'),
useSnapshot: false,
})
(
await this._xapi.VM_export(exportedVm.$ref, {
compress: Boolean(compression) && (compression === 'native' ? 'gzip' : 'zstd'),
useSnapshot: false,
})
).body
)
const vdis = await exportedVm.$getDisks()

View File

@@ -1,6 +1,4 @@
import { asyncEach } from '@vates/async-each'
import { decorateMethodsWith } from '@vates/decorate-with'
import { defer } from 'golike-defer'
import assert from 'node:assert'
import * as UUID from 'uuid'
import isVhdDifferencingDisk from 'vhd-lib/isVhdDifferencingDisk.js'
@@ -9,7 +7,6 @@ import mapValues from 'lodash/mapValues.js'
import { AbstractRemote } from './_AbstractRemote.mjs'
import { forkDeltaExport } from './_forkDeltaExport.mjs'
import { IncrementalRemoteWriter } from '../_writers/IncrementalRemoteWriter.mjs'
import { Task } from '../../Task.mjs'
import { Disposable } from 'promise-toolbox'
import { openVhd } from 'vhd-lib'
import { getVmBackupDir } from '../../_getVmBackupDir.mjs'
@@ -18,6 +15,16 @@ class IncrementalRemoteVmBackupRunner extends AbstractRemote {
_getRemoteWriter() {
return IncrementalRemoteWriter
}
// we'll transfer the full list if at least one backup should be transfered
// to ensure we don't cut the delta chain
_filterTransferList(transferList) {
if (transferList.some(vmBackupMetadata => this._filterPredicate(vmBackupMetadata))) {
return transferList
}
return []
}
async _selectBaseVm(metadata) {
// for each disk , get the parent
const baseUuidToSrcVdi = new Map()
@@ -52,64 +59,51 @@ class IncrementalRemoteVmBackupRunner extends AbstractRemote {
})
// yeah , let's go
}
async _run($defer) {
async _run() {
const transferList = await this._computeTransferList(({ mode }) => mode === 'delta')
await this._callWriters(async writer => {
await writer.beforeBackup()
$defer(async () => {
await writer.afterBackup()
for (const metadata of transferList) {
assert.strictEqual(metadata.mode, 'delta')
await this._selectBaseVm(metadata)
await this._callWriters(writer => writer.prepare({ isBase: metadata.isBase }), 'writer.prepare()')
const incrementalExport = await this._sourceRemoteAdapter.readIncrementalVmBackup(metadata, undefined, {
useChain: false,
})
}, 'writer.beforeBackup()')
if (transferList.length > 0) {
for (const metadata of transferList) {
assert.strictEqual(metadata.mode, 'delta')
await this._selectBaseVm(metadata)
await this._callWriters(writer => writer.prepare({ isBase: metadata.isBase }), 'writer.prepare()')
const incrementalExport = await this._sourceRemoteAdapter.readIncrementalVmBackup(metadata, undefined, {
useChain: false,
})
const isVhdDifferencing = {}
const isVhdDifferencing = {}
await asyncEach(Object.entries(incrementalExport.streams), async ([key, stream]) => {
isVhdDifferencing[key] = await isVhdDifferencingDisk(stream)
})
await asyncEach(Object.entries(incrementalExport.streams), async ([key, stream]) => {
isVhdDifferencing[key] = await isVhdDifferencingDisk(stream)
})
incrementalExport.streams = mapValues(incrementalExport.streams, this._throttleStream)
await this._callWriters(
writer =>
writer.transfer({
deltaExport: forkDeltaExport(incrementalExport),
isVhdDifferencing,
timestamp: metadata.timestamp,
vm: metadata.vm,
vmSnapshot: metadata.vmSnapshot,
}),
'writer.transfer()'
)
// this will update parent name with the needed alias
await this._callWriters(
writer =>
writer.updateUuidAndChain({
isVhdDifferencing,
timestamp: metadata.timestamp,
vdis: incrementalExport.vdis,
}),
'writer.updateUuidAndChain()'
)
incrementalExport.streams = mapValues(incrementalExport.streams, this._throttleStream)
await this._callWriters(
writer =>
writer.transfer({
deltaExport: forkDeltaExport(incrementalExport),
isVhdDifferencing,
timestamp: metadata.timestamp,
vm: metadata.vm,
vmSnapshot: metadata.vmSnapshot,
}),
'writer.transfer()'
)
// this will update parent name with the needed alias
await this._callWriters(
writer =>
writer.updateUuidAndChain({
isVhdDifferencing,
timestamp: metadata.timestamp,
vdis: incrementalExport.vdis,
}),
'writer.updateUuidAndChain()'
)
await this._callWriters(writer => writer.cleanup(), 'writer.cleanup()')
// for healthcheck
this._tags = metadata.vm.tags
}
} else {
Task.info('No new data to upload for this VM')
await this._callWriters(writer => writer.cleanup(), 'writer.cleanup()')
// for healthcheck
this._tags = metadata.vm.tags
}
}
}
export const IncrementalRemote = IncrementalRemoteVmBackupRunner
decorateMethodsWith(IncrementalRemoteVmBackupRunner, {
_run: defer,
})

View File

@@ -1,8 +1,6 @@
import { asyncEach } from '@vates/async-each'
import { asyncMap } from '@xen-orchestra/async-map'
import { createLogger } from '@xen-orchestra/log'
import { pipeline } from 'node:stream'
import findLast from 'lodash/findLast.js'
import isVhdDifferencingDisk from 'vhd-lib/isVhdDifferencingDisk.js'
import keyBy from 'lodash/keyBy.js'
import mapValues from 'lodash/mapValues.js'
@@ -15,9 +13,15 @@ import { IncrementalRemoteWriter } from '../_writers/IncrementalRemoteWriter.mjs
import { IncrementalXapiWriter } from '../_writers/IncrementalXapiWriter.mjs'
import { Task } from '../../Task.mjs'
import { watchStreamSize } from '../../_watchStreamSize.mjs'
import {
DATETIME,
DELTA_CHAIN_LENGTH,
EXPORTED_SUCCESSFULLY,
setVmDeltaChainLength,
markExportSuccessfull,
} from '../../_otherConfig.mjs'
const { debug } = createLogger('xo:backups:IncrementalXapiVmBackup')
const noop = Function.prototype
export const IncrementalXapi = class IncrementalXapiVmBackupRunner extends AbstractXapi {
@@ -30,17 +34,14 @@ export const IncrementalXapi = class IncrementalXapiVmBackupRunner extends Abstr
}
async _copy() {
const baseVm = this._baseVm
const baseVdis = this._baseVdis
const vm = this._vm
const exportedVm = this._exportedVm
const fullVdisRequired = this._fullVdisRequired
const isFull = fullVdisRequired === undefined || fullVdisRequired.size !== 0
const isFull = Object.values(baseVdis).length === 0 || Object.values(baseVdis).some(_ => !_)
await this._callWriters(writer => writer.prepare({ isFull }), 'writer.prepare()')
const deltaExport = await exportIncrementalVm(exportedVm, baseVm, {
fullVdisRequired,
const deltaExport = await exportIncrementalVm(exportedVm, baseVdis, {
nbdConcurrency: this._settings.nbdConcurrency,
preferNbd: this._settings.preferNbd,
})
@@ -90,18 +91,13 @@ export const IncrementalXapi = class IncrementalXapiVmBackupRunner extends Abstr
'writer.updateUuidAndChain()'
)
this._baseVm = exportedVm
if (baseVm !== undefined) {
await exportedVm.update_other_config(
'xo:backup:deltaChainLength',
String(+(baseVm.other_config['xo:backup:deltaChainLength'] ?? 0) + 1)
)
}
if (!isFull) {
await setVmDeltaChainLength(this._xapi, exportedVm.$ref, (this._deltaChainLength ?? 0) + 1)
} // on a full the delta chain will be null
// not the case if offlineBackup
if (exportedVm.is_a_snapshot) {
await exportedVm.update_other_config('xo:backup:exported', 'true')
await markExportSuccessfull(this._xapi, exportedVm.$ref)
}
const size = Object.values(sizeContainers).reduce((sum, { size }) => sum + size, 0)
@@ -119,43 +115,67 @@ export const IncrementalXapi = class IncrementalXapiVmBackupRunner extends Abstr
async _selectBaseVm() {
const xapi = this._xapi
let baseVm = findLast(this._jobSnapshots, _ => 'xo:backup:exported' in _.other_config)
if (baseVm === undefined) {
debug('no base VM found')
return
// filter _jobSnapshotVdis to have only the last successfully exported vdi
// compute delta chain length
// fill baseUuidToSrcVdi with this data
const exportedVdis = this._jobSnapshotVdis.filter(
_ => EXPORTED_SUCCESSFULLY in _.other_config && DATETIME in _.other_config
)
let lastSuccessfullBackup
let lastExportedVdis = []
for (const exportedVdi of exportedVdis) {
if (lastSuccessfullBackup === undefined || lastSuccessfullBackup < exportedVdi.other_config[DATETIME]) {
lastExportedVdis = []
lastSuccessfullBackup = exportedVdi.other_config[DATETIME]
}
if (lastSuccessfullBackup === exportedVdi.other_config[DATETIME]) {
lastExportedVdis.push(exportedVdi)
}
}
this._baseVdis = {}
if (lastExportedVdis.length === 0) {
debug('no base VDIS found', {
jobLength: this._jobSnapshotVdis.length,
lastSuccessfullBackup,
exportedLength: exportedVdis.length,
})
return
}
const deltaChainLength = Math.max(
...lastExportedVdis.map(({ other_config }) => Number(other_config[DELTA_CHAIN_LENGTH] ?? 0))
)
const fullInterval = this._settings.fullInterval
const deltaChainLength = +(baseVm.other_config['xo:backup:deltaChainLength'] ?? 0) + 1
if (!(fullInterval === 0 || fullInterval > deltaChainLength)) {
debug('not using base VM becaust fullInterval reached')
if (fullInterval !== 0 && fullInterval <= deltaChainLength + 1) {
debug('not using base VM because fullInterval reached', {
fullInterval,
deltaChainLength,
eq: fullInterval < deltaChainLength + 1,
dc1: deltaChainLength + 1,
})
return
}
const srcVdis = keyBy(await xapi.getRecords('VDI', await this._vm.$getDisks()), '$ref')
// resolve full record
baseVm = await xapi.getRecord('VM', baseVm.$ref)
const baseUuidToSrcVdi = new Map()
await asyncMap(await baseVm.$getDisks(), async baseRef => {
const [baseUuid, snapshotOf] = await Promise.all([
xapi.getField('VDI', baseRef, 'uuid'),
xapi.getField('VDI', baseRef, 'snapshot_of'),
])
const baseUuidToSrcVdiUuid = new Map()
for (const lastExportedVdi of lastExportedVdis) {
const baseUuid = lastExportedVdi.uuid
const snapshotOf = lastExportedVdi.snapshot_of
const srcVdi = srcVdis[snapshotOf]
if (srcVdi !== undefined) {
baseUuidToSrcVdi.set(baseUuid, srcVdi.uuid)
baseUuidToSrcVdiUuid.set(baseUuid, srcVdi.uuid)
} else {
debug('ignore snapshot VDI because no longer present on VM', {
vdi: baseUuid,
})
}
})
}
const presentBaseVdis = new Map(baseUuidToSrcVdi)
const presentBaseVdis = new Map(baseUuidToSrcVdiUuid)
await this._callWriters(
writer => presentBaseVdis.size !== 0 && writer.checkBaseVdis(presentBaseVdis, baseVm),
writer => presentBaseVdis.size !== 0 && writer.checkBaseVdis(presentBaseVdis),
'writer.checkBaseVdis()',
false
)
@@ -164,24 +184,22 @@ export const IncrementalXapi = class IncrementalXapiVmBackupRunner extends Abstr
debug('no base VM found')
return
}
const fullVdisRequired = new Set()
baseUuidToSrcVdi.forEach((srcVdiUuid, baseUuid) => {
baseUuidToSrcVdiUuid.forEach((srcVdiUuid, baseUuid) => {
if (presentBaseVdis.has(baseUuid)) {
debug('found base VDI', {
base: baseUuid,
vdi: srcVdiUuid,
})
this._baseVdis[srcVdiUuid] = lastExportedVdis.find(vdi => vdi.uuid === baseUuid)
} else {
debug('missing base VDI', {
base: baseUuid,
vdi: srcVdiUuid,
})
fullVdisRequired.add(srcVdiUuid)
// this will force a full for this vdi
this._baseVdis[srcVdiUuid] = undefined
}
})
this._baseVm = baseVm
this._fullVdisRequired = fullVdisRequired
this._deltaChainLength = deltaChainLength
}
}

View File

@@ -1,12 +1,18 @@
import { asyncEach } from '@vates/async-each'
import groupBy from 'lodash/groupBy.js'
import { decorateMethodsWith } from '@vates/decorate-with'
import { defer } from 'golike-defer'
import { Disposable } from 'promise-toolbox'
import { createPredicate } from 'value-matcher'
import { getVmBackupDir } from '../../_getVmBackupDir.mjs'
import { Abstract } from './_Abstract.mjs'
import { extractIdsFromSimplePattern } from '../../extractIdsFromSimplePattern.mjs'
import { Task } from '../../Task.mjs'
export const AbstractRemote = class AbstractRemoteVmBackupRunner extends Abstract {
_filterPredicate
constructor({
config,
job,
@@ -55,46 +61,91 @@ export const AbstractRemote = class AbstractRemoteVmBackupRunner extends Abstrac
})
)
})
const { filter } = job
if (filter === undefined) {
this._filterPredicate = () => true
} else {
this._filterPredicate = createPredicate(filter)
}
}
async _computeTransferList(predicate) {
const vmBackups = await this._sourceRemoteAdapter.listVmBackups(this._vmUuid, predicate)
async #computeTransferListPerJob(sourceBackups, remotesBackups) {
const localMetada = new Map()
Object.values(vmBackups).forEach(metadata => {
sourceBackups.forEach(metadata => {
const timestamp = metadata.timestamp
localMetada.set(timestamp, metadata)
})
const nbRemotes = Object.keys(this.remoteAdapters).length
const nbRemotes = remotesBackups.length
const remoteMetadatas = {}
await asyncEach(Object.values(this.remoteAdapters), async remoteAdapter => {
const remoteMetadata = await remoteAdapter.listVmBackups(this._vmUuid, predicate)
remoteMetadata.forEach(metadata => {
remotesBackups.forEach(async remoteBackups => {
remoteBackups.forEach(metadata => {
const timestamp = metadata.timestamp
remoteMetadatas[timestamp] = (remoteMetadatas[timestamp] ?? 0) + 1
})
})
let chain = []
let transferList = []
const timestamps = [...localMetada.keys()]
timestamps.sort()
for (const timestamp of timestamps) {
if (remoteMetadatas[timestamp] !== nbRemotes) {
// this backup is not present in all the remote
// should be retransfered if not found later
chain.push(localMetada.get(timestamp))
transferList.push(localMetada.get(timestamp))
} else {
// backup is present in local and remote : the chain has already been transferred
chain = []
transferList = []
}
}
return chain
if (transferList.length > 0) {
const filteredTransferList = this._filterTransferList(transferList)
if (filteredTransferList.length > 0) {
return filteredTransferList
} else {
Task.info('This VM is excluded by the job filter')
return []
}
} else {
Task.info('No new data to upload for this VM')
}
return []
}
async run() {
/**
*
* @param {*} vmPredicate a callback checking if backup is eligible for transfer. This filter MUST NOT cut delta chains
* @returns
*/
async _computeTransferList(vmPredicate) {
const sourceBackups = Object.values(await this._sourceRemoteAdapter.listVmBackups(this._vmUuid, vmPredicate))
const remotesBackups = await Promise.all(
Object.values(this.remoteAdapters).map(remoteAdapter => remoteAdapter.listVmBackups(this._vmUuid, vmPredicate))
)
const sourceBackupByJobId = groupBy(sourceBackups, 'jobId')
const transferByJobs = await Promise.all(
Object.values(sourceBackupByJobId).map(vmBackupsByJob =>
this.#computeTransferListPerJob(vmBackupsByJob, remotesBackups)
)
)
return transferByJobs.flat(1)
}
async run($defer) {
const handler = this._sourceRemoteAdapter._handler
await Disposable.use(await handler.lock(getVmBackupDir(this._vmUuid)), async () => {
await this._callWriters(async writer => {
await writer.beforeBackup()
$defer(async () => {
await writer.afterBackup()
})
}, 'writer.beforeBackup()')
await this._run()
await this._healthCheck()
})
}
}
decorateMethodsWith(AbstractRemote, {
run: defer,
})

View File

@@ -4,11 +4,18 @@ import ignoreErrors from 'promise-toolbox/ignoreErrors'
import { asyncMap } from '@xen-orchestra/async-map'
import { decorateMethodsWith } from '@vates/decorate-with'
import { defer } from 'golike-defer'
import { formatDateTime } from '@xen-orchestra/xapi'
import { getOldEntries } from '../../_getOldEntries.mjs'
import { Task } from '../../Task.mjs'
import { Abstract } from './_Abstract.mjs'
import {
DATETIME,
JOB_ID,
SCHEDULE_ID,
populateVdisOtherConfig,
resetVmOtherConfig,
setVmOtherConfig,
} from '../../_otherConfig.mjs'
export const AbstractXapi = class AbstractXapiVmBackupRunner extends Abstract {
constructor({
@@ -25,7 +32,7 @@ export const AbstractXapi = class AbstractXapiVmBackupRunner extends Abstract {
vm,
}) {
super()
if (vm.other_config['xo:backup:job'] === job.id && 'start' in vm.blocked_operations) {
if (vm.other_config[JOB_ID] === job.id && 'start' in vm.blocked_operations) {
// don't match replicated VMs created by this very job otherwise they
// will be replicated again and again
throw new Error('cannot backup a VM created by this very job')
@@ -49,17 +56,17 @@ export const AbstractXapi = class AbstractXapiVmBackupRunner extends Abstract {
this._exportedVm = undefined
this._vm = vm
this._fullVdisRequired = undefined
this._baseVdis = undefined
this._getSnapshotNameLabel = getSnapshotNameLabel
this._isIncremental = job.mode === 'delta'
this._healthCheckSr = healthCheckSr
this._jobId = job.id
this._jobSnapshots = undefined
this._jobSnapshotVdis = undefined
this._throttleStream = throttleStream
this._xapi = vm.$xapi
// Base VM for the export
this._baseVm = undefined
this._baseVdis = undefined
// Settings for this specific run (job, schedule, VM)
if (tags.includes('xo-memory-backup')) {
@@ -123,15 +130,8 @@ export const AbstractXapi = class AbstractXapiVmBackupRunner extends Abstract {
// copied on manual snapshots and interfere with the backup jobs
async _cleanMetadata() {
const vm = this._vm
if ('xo:backup:job' in vm.other_config) {
await vm.update_other_config({
'xo:backup:datetime': null,
'xo:backup:deltaChainLength': null,
'xo:backup:exported': null,
'xo:backup:job': null,
'xo:backup:schedule': null,
'xo:backup:vm': null,
})
if (JOB_ID in vm.other_config) {
await resetVmOtherConfig(this._xapi, vm.$ref)
}
}
@@ -146,23 +146,29 @@ export const AbstractXapi = class AbstractXapiVmBackupRunner extends Abstract {
if (!settings.bypassVdiChainsCheck) {
await vm.$assertHealthyVdiChains()
}
if (settings.preferNbd) {
try {
// enable CBT on all disks if possible
const diskRefs = await xapi.VM_getDisks(vm.$ref)
await Promise.all(diskRefs.map(diskRef => xapi.call('VDI.enable_cbt', diskRef)))
} catch (error) {
Task.info(`couldn't enable CBT`, error)
}
}
const snapshotRef = await vm[settings.checkpointSnapshot ? '$checkpoint' : '$snapshot']({
ignoreNobakVdis: true,
ignoredVdisTag: '[NOBAK]',
name_label: this._getSnapshotNameLabel(vm),
unplugVusbs: true,
})
this.timestamp = Date.now()
await xapi.setFieldEntries('VM', snapshotRef, 'other_config', {
'xo:backup:datetime': formatDateTime(this.timestamp),
'xo:backup:job': this._jobId,
'xo:backup:schedule': this.scheduleId,
'xo:backup:vm': vm.uuid,
await setVmOtherConfig(xapi, snapshotRef, {
timestamp: this.timestamp,
jobId: this._jobId,
scheduleId: this.scheduleId,
vmUuid: vm.uuid,
})
this._exportedVm = await xapi.getRecord('VM', snapshotRef)
return this._exportedVm.uuid
})
} else {
@@ -176,40 +182,123 @@ export const AbstractXapi = class AbstractXapiVmBackupRunner extends Abstract {
const vmRef = this._vm.$ref
const xapi = this._xapi
const snapshotsRef = await xapi.getField('VM', vmRef, 'snapshots')
const snapshotsOtherConfig = await asyncMap(snapshotsRef, ref => xapi.getField('VM', ref, 'other_config'))
// to ensure compatibility with snapshots older than CBT implementation
// update vdi data to ensure the vdi are correctly fetched in _jobSnapshotVdis
// remove by then end of 2024
const vmSnapshotsRef = await xapi.getField('VM', vmRef, 'snapshots')
const vmSnapshotsOtherConfig = await asyncMap(vmSnapshotsRef, ref => xapi.getField('VM', ref, 'other_config'))
const snapshots = []
snapshotsOtherConfig.forEach((other_config, i) => {
if (other_config['xo:backup:job'] === jobId) {
snapshots.push({ other_config, $ref: snapshotsRef[i] })
const vmSnapshots = []
vmSnapshotsOtherConfig.forEach((other_config, i) => {
if (other_config[JOB_ID] === jobId) {
vmSnapshots.push({ other_config, $ref: vmSnapshotsRef[i] })
}
})
snapshots.sort((a, b) => (a.other_config['xo:backup:datetime'] < b.other_config['xo:backup:datetime'] ? -1 : 1))
this._jobSnapshots = snapshots
await Promise.all(vmSnapshots.map(snapshot => populateVdisOtherConfig(xapi, snapshot.$ref)))
// end of compatibiliy handling
// handle snapshot by VDI
this._jobSnapshotVdis = []
const srcVdis = await xapi.getRecords('VDI', await this._vm.$getDisks())
for (const srcVdi of srcVdis) {
const snapshots = await xapi.getRecords('VDI', srcVdi.snapshots)
for (const snapshot of snapshots) {
if (snapshot.other_config[JOB_ID] === jobId) {
this._jobSnapshotVdis.push(snapshot)
}
}
}
}
async _removeUnusedSnapshots() {
const allSettings = this.job.settings
const baseSettings = this._baseSettings
const baseVmRef = this._baseVm?.$ref
const snapshotsPerSchedule = groupBy(this._jobSnapshots, _ => _.other_config['xo:backup:schedule'])
const xapi = this._xapi
await asyncMap(Object.entries(snapshotsPerSchedule), ([scheduleId, snapshots]) => {
// ensure all the event has been processed by the xapi
await xapi.barrier()
// ensure cached object are up to date
this._jobSnapshotVdis = this._jobSnapshotVdis.map(vdi => xapi.getObject(vdi.$ref))
const snapshotsPerSchedule = groupBy(this._jobSnapshotVdis, _ => _.other_config[SCHEDULE_ID])
await asyncMap(Object.entries(snapshotsPerSchedule), async ([scheduleId, snapshots]) => {
const snapshotPerDatetime = groupBy(snapshots, _ => _.other_config[DATETIME])
const datetimes = Object.keys(snapshotPerDatetime)
datetimes.sort()
const settings = {
...baseSettings,
...allSettings[scheduleId],
...allSettings[this._vm.uuid],
}
return asyncMap(getOldEntries(settings.snapshotRetention, snapshots), ({ $ref }) => {
if ($ref !== baseVmRef) {
return xapi.VM_destroy($ref)
// ensure we never delete the last one for delta
const minRetention = this.job.mode === 'delta' ? 1 : 0
const retention = Math.max(settings.snapshotRetention ?? 0, minRetention)
await asyncMap(getOldEntries(retention, datetimes), async datetime => {
const vdis = snapshotPerDatetime[datetime]
let vmRef
// if there is an attached VM => destroy the VM (Non CBT backups)
for (const vdi of vdis) {
const vbds = vdi.$VBDs.filter(({ $VM }) => $VM.is_control_domain === false)
if (vbds.length > 0) {
// only one VM linked to this vdi
// this will throw error for VDI still attached to control domain
assert.strictEqual(vbds.length, 1, 'VDI must be free or attached to exactly one VM')
const vm = vbds[0].$VM
assert.strictEqual(vm.is_a_snapshot, true, `VM must be a snapshot`) // don't delete a VM (especially a control domain)
const vmRefVdi = vm.$ref
// same vm than other vdi of the same batch
assert.ok(
vmRef === undefined || vmRef === vmRefVdi,
'_removeUnusedSnapshots don t handle vdi related to multiple VMs '
)
vmRef = vmRefVdi
}
}
if (vmRef !== undefined) {
return xapi.VM_destroy(vmRef)
} else {
return asyncMap(
vdis.map(async ({ $ref }) => {
await xapi.VDI_destroy($ref)
})
)
}
})
})
}
async _removeSnapshotData() {
// now that we use CBT, we can destroy the data of the snapshot used for this backup
// going back to a previous version of XO not supporting CBT will create a full backup
// this will only do something after snapshot and transfer
if (
// don't modify the VM
this._exportedVm?.is_a_snapshot &&
// user don't want to keep the snapshot data
this._settings.snapshotRetention === 0 &&
// preferNbd is not a guarantee that the backup used NBD, depending on the network configuration,
// in that case next runs will be full, but there is not an easy way to prevent that
this._settings.preferNbd &&
// only delete snapshost data if the config allows it
this._settings.cbtDestroySnapshotData
) {
Task.info('will delete snapshot data')
const vdiRefs = await this._xapi.VM_getDisks(this._exportedVm.$ref)
await this._xapi.call('VM.destroy', this._exportedVm.$ref)
for (const vdiRef of vdiRefs) {
try {
// data_destroy will fail with a VDI_NO_CBT_METADATA error if CBT is not enabled on this VDI
await this._xapi.VDI_dataDestroy(vdiRef)
Task.info(`Snapshot data has been deleted`, { vdiRef })
} catch (error) {
Task.warning(`Couldn't delete snapshot data`, { error, vdiRef })
}
}
}
}
async copy() {
throw new Error('Not implemented')
}
@@ -240,6 +329,33 @@ export const AbstractXapi = class AbstractXapiVmBackupRunner extends Abstract {
})
}, 'writer.beforeBackup()')
const vm = this._vm
// block migration during the backup on the VM itself, not the latest snapshot
{
const { pool_migrate, migrate_send } = vm.blocked_operations
const reason = 'VM migration is blocked during backup'
await vm.update_blocked_operations({ pool_migrate: reason, migrate_send: reason })
$defer(async () => {
// delete the entries if they did not exist previously or if they were
// equal to reason (which happen if a previous backup was interrupted
// before resetting them)
await vm.update_blocked_operations({
migrate_send: migrate_send === undefined || migrate_send === reason ? null : migrate_send,
pool_migrate: pool_migrate === undefined || pool_migrate === reason ? null : pool_migrate,
})
// 2024-08-19 - Work-around a XAPI bug where allowed_operations are not properly computed when blocked_operations is updated
//
// this is a problem because some clients (e.g. XenCenter) use this field to allow operations.
//
// internal source: https://team.vates.fr/vates/pl/mjmxnce9qfdx587r3qpe4z91ho
await vm.$call('update_allowed_operations')
})
}
await this._fetchJobSnapshots()
await this._selectBaseVm()
@@ -247,7 +363,6 @@ export const AbstractXapi = class AbstractXapiVmBackupRunner extends Abstract {
await this._cleanMetadata()
await this._removeUnusedSnapshots()
const vm = this._vm
const isRunning = vm.power_state === 'Running'
const startAfter = isRunning && (settings.offlineBackup ? 'backup' : settings.offlineSnapshot && 'snapshot')
if (startAfter) {
@@ -261,15 +376,7 @@ export const AbstractXapi = class AbstractXapiVmBackupRunner extends Abstract {
}
if (this._writers.size !== 0) {
const { pool_migrate = null, migrate_send = null } = this._exportedVm.blocked_operations
const reason = 'VM migration is blocked during backup'
await this._exportedVm.update_blocked_operations({ pool_migrate: reason, migrate_send: reason })
try {
await this._copy()
} finally {
await this._exportedVm.update_blocked_operations({ pool_migrate, migrate_send })
}
await this._copy()
}
} finally {
if (startAfter) {
@@ -278,6 +385,7 @@ export const AbstractXapi = class AbstractXapiVmBackupRunner extends Abstract {
await this._fetchJobSnapshots()
await this._removeUnusedSnapshots()
await this._removeSnapshotData()
}
await this._healthCheck()
}

View File

@@ -1,6 +1,5 @@
import ignoreErrors from 'promise-toolbox/ignoreErrors'
import { asyncMap, asyncMapSettled } from '@xen-orchestra/async-map'
import { formatDateTime } from '@xen-orchestra/xapi'
import { formatFilenameDate } from '../../_filenameDate.mjs'
import { getOldEntries } from '../../_getOldEntries.mjs'
@@ -9,6 +8,7 @@ import { Task } from '../../Task.mjs'
import { AbstractFullWriter } from './_AbstractFullWriter.mjs'
import { MixinXapiWriter } from './_MixinXapiWriter.mjs'
import { listReplicatedVms } from './_listReplicatedVms.mjs'
import { setVmOtherConfig } from '../../_otherConfig.mjs'
export class FullXapiWriter extends MixinXapiWriter(AbstractFullWriter) {
constructor(props) {
@@ -76,14 +76,12 @@ export class FullXapiWriter extends MixinXapiWriter(AbstractFullWriter) {
'Start operation for this vm is blocked, clone it if you want to use it.'
)
),
targetVm.update_other_config({
'xo:backup:sr': srUuid,
// these entries need to be added in case of offline backup
'xo:backup:datetime': formatDateTime(timestamp),
'xo:backup:job': job.id,
'xo:backup:schedule': scheduleId,
'xo:backup:vm': vm.uuid,
setVmOtherConfig(xapi, targetVmRef, {
timestamp,
jobId: job.id,
scheduleId,
srUuid,
vmUuid: vm.uuid,
}),
])

View File

@@ -140,6 +140,7 @@ export class IncrementalRemoteWriter extends MixinRemoteWriter(AbstractIncrement
if (isDifferencing) {
assert.notStrictEqual(
parentVdiPaths,
undefined,
'checkbasevdi must be called before updateUuidAndChain for incremental backups'
)
const parentPath = parentVdiPaths[dirname(path)]

View File

@@ -1,39 +1,34 @@
import assert from 'node:assert'
import { asyncMap, asyncMapSettled } from '@xen-orchestra/async-map'
import ignoreErrors from 'promise-toolbox/ignoreErrors'
import { formatDateTime } from '@xen-orchestra/xapi'
import { formatFilenameDate } from '../../_filenameDate.mjs'
import { getOldEntries } from '../../_getOldEntries.mjs'
import { importIncrementalVm, TAG_BACKUP_SR, TAG_BASE_DELTA, TAG_COPY_SRC } from '../../_incrementalVm.mjs'
import { importIncrementalVm } from '../../_incrementalVm.mjs'
import { Task } from '../../Task.mjs'
import { AbstractIncrementalWriter } from './_AbstractIncrementalWriter.mjs'
import { MixinXapiWriter } from './_MixinXapiWriter.mjs'
import { listReplicatedVms } from './_listReplicatedVms.mjs'
import find from 'lodash/find.js'
import { COPY_OF, setVmOtherConfig, BASE_DELTA_VDI } from '../../_otherConfig.mjs'
import assert from 'node:assert'
export class IncrementalXapiWriter extends MixinXapiWriter(AbstractIncrementalWriter) {
async checkBaseVdis(baseUuidToSrcVdi, baseVm) {
assert.notStrictEqual(baseVm, undefined)
async checkBaseVdis(baseUuidToSrcVdi) {
const sr = this._sr
const replicatedVm = listReplicatedVms(sr.$xapi, this._job.id, sr.uuid, this._vmUuid).find(
vm => vm.other_config[TAG_COPY_SRC] === baseVm.uuid
)
if (replicatedVm === undefined) {
return baseUuidToSrcVdi.clear()
}
const xapi = replicatedVm.$xapi
const replicatedVdis = new Set(
await asyncMap(await replicatedVm.$getDisks(), async vdiRef => {
const otherConfig = await xapi.getField('VDI', vdiRef, 'other_config')
return otherConfig[TAG_COPY_SRC]
// @todo use an index if possible
// @todo : this seems similare to decorateVmMetadata
const replicatedVdis = sr.$VDIs
.filter(vdi => {
// REPLICATED_TO_SR_UUID is not used here since we are already filtering from sr.$VDIs
return baseUuidToSrcVdi.has(vdi?.other_config[COPY_OF])
})
)
.map(({ other_config }) => other_config?.[COPY_OF])
.filter(_ => !!_)
for (const uuid of baseUuidToSrcVdi.keys()) {
if (!replicatedVdis.has(uuid)) {
if (!replicatedVdis.includes(uuid)) {
baseUuidToSrcVdi.delete(uuid)
}
}
@@ -57,10 +52,10 @@ export class IncrementalXapiWriter extends MixinXapiWriter(AbstractIncrementalWr
this.cleanup = task.wrapFn(this.cleanup, !hasHealthCheckSr)
this.healthCheck = task.wrapFn(this.healthCheck, hasHealthCheckSr)
return task.run(() => this._prepare())
return task.run(() => this._prepare(isFull))
}
async _prepare() {
async _prepare(isFull) {
const settings = this._settings
const { uuid: srUuid, $xapi: xapi } = this._sr
const vmUuid = this._vmUuid
@@ -72,14 +67,19 @@ export class IncrementalXapiWriter extends MixinXapiWriter(AbstractIncrementalWr
this._oldEntries = getOldEntries(settings.copyRetention - 1, listReplicatedVms(xapi, scheduleId, srUuid, vmUuid))
if (settings.deleteFirst) {
// we want to keep the baseVM when copying a delta
// even if we want to keep only one after
let mostRecentEntry
if (this._oldEntries.length > 1 && settings.copyRetention === 1 && !isFull) {
mostRecentEntry = this._oldEntries.pop()
}
await this._deleteOldEntries()
this._oldEntries = mostRecentEntry !== undefined ? [mostRecentEntry] : []
}
}
async cleanup() {
if (!this._settings.deleteFirst) {
await this._deleteOldEntries()
}
await this._deleteOldEntries()
}
async _deleteOldEntries() {
@@ -89,46 +89,39 @@ export class IncrementalXapiWriter extends MixinXapiWriter(AbstractIncrementalWr
#decorateVmMetadata(backup) {
const { _warmMigration } = this._settings
const sr = this._sr
const xapi = sr.$xapi
const vm = backup.vm
vm.other_config[TAG_COPY_SRC] = vm.uuid
const remoteBaseVmUuid = vm.other_config[TAG_BASE_DELTA]
let baseVm
if (remoteBaseVmUuid) {
baseVm = find(
xapi.objects.all,
obj => (obj = obj.other_config) && obj[TAG_COPY_SRC] === remoteBaseVmUuid && obj[TAG_BACKUP_SR] === sr.$id
)
if (!baseVm) {
throw new Error(`could not find the base VM (copy of ${remoteBaseVmUuid})`)
}
}
const baseVdis = {}
baseVm?.$VBDs.forEach(vbd => {
const vdi = vbd.$VDI
if (vdi !== undefined) {
baseVdis[vbd.VDI] = vbd.$VDI
}
})
vm.other_config[TAG_COPY_SRC] = vm.uuid
vm.other_config[COPY_OF] = vm.uuid
if (!_warmMigration) {
vm.tags.push('Continuous Replication')
}
// extracting the uuid of each delta vdi on the source
// get all in one pass, since there is a lot of objects
const sourceVdiUuids = Object.values(backup.vdis)
.map(({ other_config }) => other_config[BASE_DELTA_VDI])
// full vdi don't have a base
.filter(_ => !!_)
// @todo use index ?
const replicatedVdis = sr.$VDIs
.filter(vdi => {
// REPLICATED_TO_SR_UUID is not used here since we are already filtering from sr.$VDIs
return sourceVdiUuids.includes(vdi?.other_config[COPY_OF])
})
Object.values(backup.vdis).forEach(vdi => {
vdi.other_config[TAG_COPY_SRC] = vdi.uuid
vdi.SR = sr.$ref
// vdi.other_config[TAG_BASE_DELTA] is never defined on a suspend vdi
if (vdi.other_config[TAG_BASE_DELTA]) {
const remoteBaseVdiUuid = vdi.other_config[TAG_BASE_DELTA]
const baseVdi = find(baseVdis, vdi => vdi.other_config[TAG_COPY_SRC] === remoteBaseVdiUuid)
if (!baseVdi) {
throw new Error(`missing base VDI (copy of ${remoteBaseVdiUuid})`)
}
vdi.baseVdi = baseVdi
vdi.other_config[COPY_OF] = vdi.uuid
if (sourceVdiUuids.length > 0) {
const baseReplicatedTo = replicatedVdis.find(
replicatedVdi => replicatedVdi.other_config[COPY_OF] === vdi.other_config[BASE_DELTA_VDI]
)
assert.notStrictEqual(baseReplicatedTo, undefined)
vdi.baseVdi = baseReplicatedTo
} else {
vdi.baseVdi = undefined
}
// ensure the VDI are created on the target SR
vdi.SR = sr.$ref
})
return backup
@@ -164,14 +157,12 @@ export class IncrementalXapiWriter extends MixinXapiWriter(AbstractIncrementalWr
'Start operation for this vm is blocked, clone it if you want to use it.'
)
),
targetVm.update_other_config({
[TAG_BACKUP_SR]: srUuid,
// these entries need to be added in case of offline backup
'xo:backup:datetime': formatDateTime(timestamp),
'xo:backup:job': job.id,
'xo:backup:schedule': scheduleId,
[TAG_BASE_DELTA]: vm.uuid,
setVmOtherConfig(xapi, targetVmRef, {
timestamp,
jobId: job.id,
scheduleId,
vmUuid: vm.uuid,
srUuid,
}),
])
}

View File

@@ -8,6 +8,7 @@ import { HealthCheckVmBackup } from '../../HealthCheckVmBackup.mjs'
import { ImportVmBackup } from '../../ImportVmBackup.mjs'
import { Task } from '../../Task.mjs'
import * as MergeWorker from '../../merge-worker/index.mjs'
import ms from 'ms'
const { info, warn } = createLogger('xo:backups:MixinBackupWriter')
@@ -37,6 +38,7 @@ export const MixinRemoteWriter = (BaseClass = Object) =>
},
lock: false,
mergeBlockConcurrency: this._config.mergeBlockConcurrency,
removeTmp: true,
})
})
} catch (error) {
@@ -100,10 +102,17 @@ export const MixinRemoteWriter = (BaseClass = Object) =>
additionnalVmTag: 'xo:no-bak=Health Check',
},
}).run()
const restoredVm = xapi.getObject(restoredId)
let restoredVm
try {
restoredVm = xapi.getObject(restoredId)
} catch (err) {
restoredVm = await xapi.waitObject(restoredId)
}
try {
const timeout = ms(this._settings.healthCheckTimeout)
await new HealthCheckVmBackup({
restoredVm,
timeout,
xapi,
}).run()
} finally {

View File

@@ -1,8 +1,8 @@
import { extractOpaqueRef } from '@xen-orchestra/xapi'
import assert from 'node:assert/strict'
import { HealthCheckVmBackup } from '../../HealthCheckVmBackup.mjs'
import { Task } from '../../Task.mjs'
import ms from 'ms'
export const MixinXapiWriter = (BaseClass = Object) =>
class MixinXapiWriter extends BaseClass {
@@ -26,7 +26,8 @@ export const MixinXapiWriter = (BaseClass = Object) =>
}
healthCheck() {
const sr = this._healthCheckSr
// the SR that the VM has been replicated on
const sr = this._sr
assert.notStrictEqual(sr, undefined, 'SR should be defined before making a health check')
assert.notEqual(this._targetVmRef, undefined, 'A vm should have been transfered to be health checked')
// copy VM
@@ -38,29 +39,36 @@ export const MixinXapiWriter = (BaseClass = Object) =>
const { $xapi: xapi } = sr
let healthCheckVmRef
try {
const baseVm = xapi.getObject(this._targetVmRef) ?? (await xapi.waitObject(this._targetVmRef))
let baseVm
try {
baseVm = xapi.getObject(this._targetVmRef)
} catch (err) {
baseVm = await xapi.waitObject(this._targetVmRef)
}
if (await this.#isAlreadyOnHealthCheckSr(baseVm)) {
healthCheckVmRef = await Task.run(
{ name: 'cloning-vm' },
async () =>
await xapi
.callAsync('VM.clone', this._targetVmRef, `Health Check - ${baseVm.name_label}`)
.then(extractOpaqueRef)
async () => await xapi.callAsync('VM.clone', this._targetVmRef, `Health Check - ${baseVm.name_label}`)
)
} else {
healthCheckVmRef = await Task.run(
{ name: 'copying-vm' },
async () =>
await xapi
.callAsync('VM.copy', this._targetVmRef, `Health Check - ${baseVm.name_label}`, sr.$ref)
.then(extractOpaqueRef)
await xapi.callAsync(
'VM.copy',
this._targetVmRef,
`Health Check - ${baseVm.name_label}`,
this._healthCheckSr.$ref
)
)
}
const healthCheckVm = xapi.getObject(healthCheckVmRef) ?? (await xapi.waitObject(healthCheckVmRef))
const healthCheckVm =
xapi.getObject(healthCheckVmRef, undefined) ?? (await xapi.waitObject(healthCheckVmRef))
await healthCheckVm.add_tags('xo:no-bak=Health Check')
const timeout = ms(this._settings.healthCheckTimeout)
await new HealthCheckVmBackup({
restoredVm: healthCheckVm,
timeout,
xapi,
}).run()
} finally {

View File

@@ -1,5 +1,7 @@
import { DATETIME, JOB_ID, REPLICATED_TO_SR_UUID, SCHEDULE_ID, VM_UUID } from '../../_otherConfig.mjs'
const getReplicatedVmDatetime = vm => {
const { 'xo:backup:datetime': datetime = vm.name_label.slice(-17, -1) } = vm.other_config
const { [DATETIME]: datetime = vm.name_label.slice(-17, -1) } = vm.other_config
return datetime
}
@@ -16,11 +18,11 @@ export function listReplicatedVms(xapi, scheduleOrJobId, srUuid, vmUuid) {
!object.is_a_snapshot &&
!object.is_a_template &&
'start' in object.blocked_operations &&
(oc['xo:backup:job'] === scheduleOrJobId || oc['xo:backup:schedule'] === scheduleOrJobId) &&
oc['xo:backup:sr'] === srUuid &&
(oc['xo:backup:vm'] === vmUuid ||
(oc[JOB_ID] === scheduleOrJobId || oc[SCHEDULE_ID] === scheduleOrJobId) &&
oc[REPLICATED_TO_SR_UUID] === srUuid &&
(oc[VM_UUID] === vmUuid ||
// 2018-03-28, JFT: to catch VMs replicated before this fix
oc['xo:backup:vm'] === undefined)
oc[VM_UUID] === undefined)
) {
vms[object.$id] = object
}

View File

@@ -59,13 +59,13 @@ In case any incoherence is detected, the file is deleted so it will be fully gen
## Attributes
### Of created snapshots
### Of created snapshots (VMs and associated VDIs)
- `other_config`:
- `xo:backup:deltaChainLength` = n (number of delta copies/replicated since a full)
- `xo:backup:exported` = 'true' (added at the end of the backup)
### Of created VMs and snapshots
### Of created VMs , their associated VDIs and snapshots
- `other_config`:
- `xo:backup:datetime`: format is UTC %Y%m%dT%H:%M:%SZ
@@ -75,7 +75,7 @@ In case any incoherence is detected, the file is deleted so it will be fully gen
- `xo:backup:schedule` = schedule.id
- `xo:backup:vm` = vm.uuid
### Of created VMs
### Of created VMs and their associated VDIs
- `name_label`: `${original name} - ${job name} - (${safeDateFormat(backup timestamp)})`
- tag:

View File

@@ -8,7 +8,7 @@
"type": "git",
"url": "https://github.com/vatesfr/xen-orchestra.git"
},
"version": "0.45.0",
"version": "0.54.0",
"engines": {
"node": ">=14.18"
},
@@ -24,39 +24,42 @@
"@vates/compose": "^2.1.0",
"@vates/decorate-with": "^2.1.0",
"@vates/disposable": "^0.1.5",
"@vates/fuse-vhd": "^2.1.0",
"@vates/nbd-client": "^3.0.0",
"@vates/fuse-vhd": "^2.1.1",
"@vates/nbd-client": "^3.1.0",
"@vates/parse-duration": "^0.1.1",
"@xen-orchestra/async-map": "^0.1.2",
"@xen-orchestra/fs": "^4.1.5",
"@xen-orchestra/fs": "^4.1.7",
"@xen-orchestra/log": "^0.6.0",
"@xen-orchestra/template": "^0.1.0",
"app-conf": "^2.3.0",
"app-conf": "^3.0.0",
"compare-versions": "^6.0.0",
"d3-time-format": "^4.1.0",
"decorator-synchronized": "^0.6.0",
"golike-defer": "^0.5.1",
"limit-concurrency-decorator": "^0.5.0",
"human-format": "^1.2.0",
"limit-concurrency-decorator": "^0.6.0",
"lodash": "^4.17.20",
"ms": "^2.1.3",
"node-zone": "^0.4.0",
"parse-pairs": "^2.0.0",
"promise-toolbox": "^0.21.0",
"proper-lockfile": "^4.1.2",
"tar": "^6.1.15",
"uuid": "^9.0.0",
"vhd-lib": "^4.9.1",
"xen-api": "^2.0.1",
"value-matcher": "^0.2.0",
"vhd-lib": "^4.11.0",
"xen-api": "^4.3.1",
"yazl": "^2.5.1"
},
"devDependencies": {
"fs-extra": "^11.1.0",
"rimraf": "^5.0.1",
"sinon": "^17.0.1",
"sinon": "^18.0.0",
"test": "^3.2.1",
"tmp": "^0.2.1"
},
"peerDependencies": {
"@xen-orchestra/xapi": "^4.3.0"
"@xen-orchestra/xapi": "^7.6.0"
},
"license": "AGPL-3.0-or-later",
"author": {

View File

@@ -1,7 +1,7 @@
{
"private": false,
"name": "@xen-orchestra/cr-seed-cli",
"version": "1.0.0",
"version": "1.0.2",
"homepage": "https://github.com/vatesfr/xen-orchestra/tree/master/@xen-orchestra/cr-seed-cli",
"bugs": "https://github.com/vatesfr/xen-orchestra/issues",
"repository": {
@@ -18,7 +18,7 @@
"preferGlobal": true,
"dependencies": {
"golike-defer": "^0.5.1",
"xen-api": "^2.0.1"
"xen-api": "^4.3.1"
},
"scripts": {
"postversion": "npm publish"

View File

@@ -42,7 +42,7 @@
"test": "node--test"
},
"devDependencies": {
"sinon": "^17.0.1",
"sinon": "^18.0.0",
"test": "^3.2.1"
}
}

View File

@@ -0,0 +1,29 @@
### `defined()`
Returns the first non-`undefined` value from a list of arguments, evaluating functions if needed.
There is two ways to use this function:
- either with a single array argument: it should return the first non-undefined item
- or with multiple arguments: it should return the first non-undefined argument
If only `undefined` values, return `undefined`.
```js
import defined from '@xen-orchestra/defined/index.js'
defined(undefined, 'foo', 42)
// Returns 'foo'
defined([undefined, null, 10])
// Returns null
defined([undefined, undefined], [undefined, undefined, 10])
// Returns [undefined, undefined]
defined(() => 'bar', 42)
// Returns 'bar'
defined(undefined, undefined)
// Returns undefined
```

View File

@@ -14,6 +14,37 @@ Installation of the [npm package](https://npmjs.org/package/@xen-orchestra/defin
npm install --save @xen-orchestra/defined
```
## Usage
### `defined()`
Returns the first non-`undefined` value from a list of arguments, evaluating functions if needed.
There is two ways to use this function:
- either with a single array argument: it should return the first non-undefined item
- or with multiple arguments: it should return the first non-undefined argument
If only `undefined` values, return `undefined`.
```js
import defined from '@xen-orchestra/defined/index.js'
defined(undefined, 'foo', 42)
// Returns 'foo'
defined([undefined, null, 10])
// Returns null
defined([undefined, undefined], [undefined, undefined, 10])
// Returns [undefined, undefined]
defined(() => 'bar', 42)
// Returns 'bar'
defined(undefined, undefined)
// Returns undefined
```
## Contributions
Contributions are _very_ welcomed, either on the documentation or on

View File

@@ -22,7 +22,7 @@ function defined() {
}
for (let i = 0; i < n; ++i) {
let arg = arguments[i]
let arg = args[i]
if (typeof arg === 'function') {
arg = get(arg)
}

View File

@@ -0,0 +1,30 @@
import { describe, it } from 'node:test'
import assert from 'node:assert/strict'
import defined_ from '@xen-orchestra/defined/index.js'
// for each test, use the flat syntax and the array syntax
for (const [title, defined] of Object.entries({
'defined(...values)': defined_,
'defined([ ...values ])': (...args) => defined_(args),
})) {
describe(title, () => {
it('returns the first non undefined value', () => {
assert.deepEqual(defined(undefined, 'foo', 42), 'foo')
})
it('returns undefined if only undefined values', () => {
assert.equal(defined(undefined, undefined), undefined)
})
it('resolves functions with `get(fn)`', () => {
const o = { foo: undefined, baz: 'baz' }
assert.deepEqual(
defined(
() => o.foo.bar,
() => o.baz
),
'baz'
)
})
})
}

View File

@@ -1,7 +1,7 @@
{
"private": false,
"name": "@xen-orchestra/defined",
"version": "0.0.1",
"version": "0.0.2",
"license": "ISC",
"description": "Utilities to help handling (possibly) undefined values",
"homepage": "https://github.com/vatesfr/xen-orchestra/tree/master/@xen-orchestra/defined",
@@ -23,6 +23,7 @@
"node": ">=6"
},
"scripts": {
"postversion": "npm publish"
"postversion": "npm publish",
"test": "node --test"
}
}

View File

@@ -1,7 +1,7 @@
{
"private": false,
"name": "@xen-orchestra/fs",
"version": "4.1.5",
"version": "4.1.7",
"license": "AGPL-3.0-or-later",
"description": "The File System for Xen Orchestra backups.",
"homepage": "https://github.com/vatesfr/xen-orchestra/tree/master/@xen-orchestra/fs",
@@ -25,7 +25,6 @@
"@aws-sdk/lib-storage": "^3.54.0",
"@aws-sdk/middleware-apply-body-checksum": "^3.58.0",
"@aws-sdk/node-http-handler": "^3.54.0",
"@sindresorhus/df": "^3.1.1",
"@vates/async-each": "^1.0.0",
"@vates/coalesce-calls": "^0.1.0",
"@vates/decorate-with": "^2.1.0",
@@ -36,7 +35,7 @@
"execa": "^5.0.0",
"fs-extra": "^11.1.0",
"get-stream": "^6.0.0",
"limit-concurrency-decorator": "^0.5.0",
"limit-concurrency-decorator": "^0.6.0",
"lodash": "^4.17.4",
"promise-toolbox": "^0.21.0",
"proper-lockfile": "^4.1.2",
@@ -53,7 +52,7 @@
"cross-env": "^7.0.2",
"dotenv": "^16.0.0",
"rimraf": "^5.0.1",
"sinon": "^17.0.1",
"sinon": "^18.0.0",
"test": "^3.3.0",
"tmp": "^0.2.1"
},

View File

@@ -12,7 +12,7 @@ import { synchronized } from 'decorator-synchronized'
import { basename, dirname, normalize as normalizePath } from './path'
import { createChecksumStream, validChecksumOfReadStream } from './checksum'
import { DEFAULT_ENCRYPTION_ALGORITHM, _getEncryptor } from './_encryptor'
import { DEFAULT_ENCRYPTION_ALGORITHM, UNENCRYPTED_ALGORITHM, _getEncryptor } from './_encryptor'
const { info, warn } = createLogger('xo:fs:abstract')
@@ -674,6 +674,10 @@ export default class RemoteHandlerAbstract {
get isEncrypted() {
return this.#encryptor.id !== 'NULL_ENCRYPTOR'
}
get encryptionAlgorithm() {
return this.#encryptor?.algorithm ?? UNENCRYPTED_ALGORITHM
}
}
// from implementation methods, which names start with `__`, create public

View File

@@ -1,7 +1,9 @@
import df from '@sindresorhus/df'
import assert from 'node:assert/strict'
import fromCallback from 'promise-toolbox/fromCallback'
import fs from 'fs-extra'
import lockfile from 'proper-lockfile'
import { createLogger } from '@xen-orchestra/log'
import { execFile } from 'node:child_process'
import { fromEvent, retry } from 'promise-toolbox'
import RemoteHandlerAbstract from './abstract'
@@ -29,6 +31,22 @@ async function addSyncStackTrace(fn, ...args) {
}
}
// $filesystem $size $used $available_bytes $capacity $mountpoint
const DF_RE = /^(.+?)\s+(\d+)\s+(\d+)\s+(\d+)\s+(\d{1,3})%\s+(.+)$/
async function df(path) {
const stdout = await fromCallback(execFile, 'df', ['-kP', path])
const lines = stdout.trim().split('\n')
assert.equal(lines.length, 2) // headers + first line
const matches = DF_RE.exec(lines[1])
assert.notEqual(matches, null)
return {
size: Number(matches[2]) * 1024,
used: Number(matches[3]) * 1024,
available: Number(matches[4]) * 1024,
}
}
function dontAddSyncStackTrace(fn, ...args) {
return fn.apply(this, args)
}
@@ -101,7 +119,7 @@ export default class LocalHandler extends RemoteHandlerAbstract {
// filesystem, type, size, used, available, capacity and mountpoint.
// size, used, available and capacity may be `NaN` so we remove any `NaN`
// value from the object.
const info = await df.file(this.getFilePath('/'))
const info = await df(this.getFilePath('/'))
Object.keys(info).forEach(key => {
if (Number.isNaN(info[key])) {
delete info[key]

View File

@@ -17,19 +17,19 @@
"xo-lift-remote-immutability": "./liftProtection.mjs"
},
"license": "AGPL-3.0-or-later",
"version": "1.0.2",
"version": "1.0.12",
"engines": {
"node": ">=14.0.0"
},
"dependencies": {
"@vates/async-each": "^1.0.0",
"@xen-orchestra/backups": "^0.45.0",
"@xen-orchestra/backups": "^0.54.0",
"@xen-orchestra/log": "^0.6.0",
"app-conf": "^2.3.0",
"app-conf": "^3.0.0",
"chokidar": "^3.5.3",
"execa": "^5.0.0",
"ms": "^2.1.3",
"vhd-lib": "^4.9.1"
"vhd-lib": "^4.11.0"
},
"devDependencies": {
"rimraf": "^5.0.5",

View File

@@ -2,6 +2,33 @@
## **next**
- Handle IPv6 hosts
## **0.4.0** (2024-09-30)
- [Settings] Default UI theme is now _auto_ instead of _dark_
## **0.2.7** (2024-07-31)
- [Pool/Dashboard] Add missing translations for hosts and VMs statuses (PR [#7744](https://github.com/vatesfr/xen-orchestra/pull/7744))
- [i18n] Add Persian translation (based on the contribution made by [@Jokar-xen](https://github.com/Jokar-xen)) (PR [#7775](https://github.com/vatesfr/xen-orchestra/pull/7775))
- [Access XOA] Support `xo-server`'s' setting `http.publicUrl` to redirect to a custom URL when "Access XOA" button is clicked in XO Lite [Forum#9392](https://xcp-ng.org/forum/topic/9392) (PR [#7849](https://github.com/vatesfr/xen-orchestra/pull/7849))
## **0.2.3** (2024-05-31)
- [Pool/Dashboard] In the `Storage usage` card, DVDs are no longer taken into account (PR [#7670](https://github.com/vatesfr/xen-orchestra/pull/7670))
- [Header] Add link to XOA when XOA is detected on the pool (PR [#7679](https://github.com/vatesfr/xen-orchestra/pull/7679))
- Add german translation (based on the contribution made by [@borzel](https://github.com/borzel)) (PR [#7686](https://github.com/vatesfr/xen-orchestra/pull/7686))
## **0.2.2** (2024-04-30)
- [Tree view] Update tree view with new components from design system (PR [#7531](https://github.com/vatesfr/xen-orchestra/pull/7531))
## **0.2.1** (2024-04-02)
- Fix duplicate consoles after failed connection (PR [#7505](https://github.com/vatesfr/xen-orchestra/pull/7505))
- [Tabs] Disable navigation to in-progress views (PR [7482](https://github.com/vatesfr/xen-orchestra/pull/7482))
## **0.2.0** (2024-02-29)
- Fix Typescript typings errors when running `yarn type-check` command (PR [#7278](https://github.com/vatesfr/xen-orchestra/pull/7278))

View File

@@ -5,213 +5,6 @@
- `yarn`
- `yarn dev`
## Conventions
## Guidelines
### File names
| Type | Format | Exemple |
| ---------- | ---------------------------------------- | ----------------------------------- |
| Component | `components/<PascalCase>.vue` | `components/FooBar.vue` |
| View | `views/<PascalCase>View.vue` | `views/FooBarView.vue` |
| Composable | `composables/<kebab-case>.composable.ts` | `composables/foo-bar.composable.ts` |
| Store | `stores/<kebab-case>.store.ts` | `stores/foo-bar.store.ts` |
| Other | `libs/<kebab-case>.ts` | `libs/foo-bar.ts` |
For components and views, prepend the subdirectories names to the resulting filename.
Example: `components/foo/bar/FooBarBaz.vue`
### Vue Components
Use Vue Single File Components (`*.vue`).
Insert blocks in the following order: `template`, `script` then `style`.
#### Template
Use HTML.
If your component only has one root element, add the component name as a class.
```vue
<!-- MyComponent.vue -->
<template>
<div class="my-component">...</div>
</template>
```
#### Script
Use composition API + TypeScript + `setup` attribute (`<script lang="ts" setup>`).
Note: When reading Vue official doc, don't forget to set "API Preference" toggle (in the upper left) on "Composition".
```vue
<script lang="ts" setup>
import { computed, ref } from 'vue'
const props = defineProps<{
greetings: string
}>()
const firstName = ref('')
const lastName = ref('')
const fullName = computed(() => `${props.greetings} ${firstName.value} ${lastName.value}`)
</script>
```
#### CSS
Always use `scoped` attribute (`<style scoped>`).
Nested rules are allowed.
Vue variables can be interpolated with `v-bind`.
```vue
<script lang="ts" setup>
import { ref } from 'vue'
const fontSize = ref('2rem')
</script>
<style scoped>
.my-item {
.nested {
font-size: v-bind(fontSize);
}
}
</style>
```
### Icons
This project is using Font Awesome 6 Free.
Icons can be displayed with the `UiIcon` component.
Passing `undefined` as `icon` prop will disable the component (no need to use an additional `v-if` condition).
Use the `busy` prop to display a loader icon.
```vue
<template>
<div>
<UiIcon :icon="faDisplay" />
</div>
</template>
<script lang="ts" setup>
import UiIcon from '@/components/ui/icon/UiIcon.vue'
import { faDisplay } from '@fortawesome/free-solid-svg-icons'
</script>
```
#### Font weight <=> Style name
Here is the equivalent between font weight and style name.
| Style name | Font weight |
| ---------- | ----------- |
| Solid | 900 |
| Regular | 400 |
### CSS
Always use `rem` unit (`1rem` = `10px`)
### Store
Use Pinia store with setup function.
State are `ref`
Getters are `computed`
Actions/Mutations are simple functions
#### Naming convention
For a `foobar` store, create a `store/foobar.store.ts` then use `defineStore('foobar', setupFunc)`
#### Example
```typescript
import { computed, ref } from 'vue'
export const useFoobarStore = defineStore('foobar', () => {
const aStateVar = ref(0)
const otherStateVar = ref(0)
const aGetter = computed(() => aStateVar.value * 2)
const anAction = () => (otherStateVar.value += 10)
return {
aStateVar,
otherStateVar,
aGetter,
anAction,
}
})
```
### I18n
Internationalization of the app is done with [Vue-i18n](https://vue-i18n.intlify.dev/).
Locale files are located in `src/locales` directory.
Source of truth is `en-US.json` file.
To quickly check if there are missing translations in other locale files, open `main.ts` and check the `messages`
property of `createI18n()` for TypeScript error.
#### Example
```json
{
"hello": "Hello",
"hello_name": "Hello {name}",
"hello_linked": "@:hello_name how are you?",
"hello_plural": "No hello | Hello to you | Hello to {count} persons"
}
```
```html
<!-- String -->
<p>{{ $t("hello") }}</p>
<!-- Hello -->
<p>{{ $t("hello_name", { name: "World" }) }}</p>
<!-- Hello World -->
<p>{{ $t("hello_linked", { name: "World" }) }}</p>
<!-- Hello World how are you? -->
<p>{{ $tc("hello_plural", 0) }}</p>
<!-- No hello -->
<p>{{ $tc("hello_plural", 1) }}</p>
<!-- Hello to you -->
<p>{{ $tc("hello_plural", 4) }}</p>
<!-- Hello to 4 persons -->
<!-- Date and time -->
<p>{{ $d(date, "date_short") }}</p>
<!-- 9/10/2022 -->
<p>{{ $d(date, "date_medium") }}</p>
<!-- Sep 10, 2022 -->
<p>{{ $d(date, "date_long") }}</p>
<!-- September 10, 2022 -->
<p>{{ $d(date, "datetime_short") }}</p>
<!-- 9/10/2022, 06:30 PM -->
<p>{{ $d(date, "datetime_medium") }}</p>
<!-- Sep 10, 2022, 06:30 PM -->
<p>{{ $d(date, "datetime_long") }}</p>
<!-- September 10, 2022 at 06:30 PM -->
<p>{{ $d(date, "time") }}</p>
<!-- 06:30 PM -->
<!-- Number -->
<p>{{ $n(1234567.898765) }}</p>
<!-- 1,234,567.899 -->
```
Please follow the guidelines from the `@xen-orchestra/web-core/docs/guidelines` directory.

View File

@@ -130,10 +130,10 @@ withDefaults(
)
const emit = defineEmits<{
(event: 'click'): void
(event: 'clickWithArg', id: string): void
(event: 'update:modelValue', value: string): void
(event: 'update:customModel', value: number): void
click: []
clickWithArg: [id: string]
'update:modelValue': [value: string]
'update:customModel': [value: number]
}>()
const moonDistance = 384400

View File

@@ -1,6 +1,7 @@
/// <reference types="vite/client" />
/// <reference types="json-rpc-2.0/dist" />
/// <reference types="vite-plugin-pages/client" />
/// <reference types="novnc__novnc" />
declare const XO_LITE_VERSION: string
declare const XO_LITE_GIT_HEAD: string

View File

@@ -1,6 +1,6 @@
{
"name": "@xen-orchestra/lite",
"version": "0.2.0",
"version": "0.4.0",
"type": "module",
"scripts": {
"dev": "GIT_HEAD=$(git rev-parse HEAD) vite",
@@ -15,7 +15,6 @@
},
"devDependencies": {
"@csstools/postcss-global-data": "^2.1.1",
"@fontsource/poppins": "^5.0.8",
"@fortawesome/fontawesome-svg-core": "^6.5.1",
"@fortawesome/free-regular-svg-icons": "^6.5.1",
"@fortawesome/free-solid-svg-icons": "^6.5.1",
@@ -32,7 +31,7 @@
"@vueuse/core": "^10.7.1",
"@vueuse/math": "^10.7.1",
"@vueuse/shared": "^10.7.1",
"@xen-orchestra/web-core": "*",
"@xen-orchestra/web-core": "^0.3.0",
"complex-matcher": "^0.7.1",
"d3-time-format": "^4.1.0",
"decorator-synchronized": "^0.6.0",
@@ -43,7 +42,7 @@
"iterable-backoff": "^0.1.0",
"json-rpc-2.0": "^1.7.0",
"json5": "^2.2.3",
"limit-concurrency-decorator": "^0.5.0",
"limit-concurrency-decorator": "^0.6.0",
"lodash-es": "^4.17.21",
"make-error": "^1.3.6",
"marked": "^9.1.5",
@@ -57,10 +56,10 @@
"postcss-nested": "^6.0.1",
"typescript": "~5.3.3",
"vite": "^5.0.11",
"vue": "^3.4.13",
"vue": "~3.4.13",
"vue-echarts": "^6.6.8",
"vue-i18n": "^9.9.0",
"vue-router": "^4.2.5",
"vue-router": "^4.4.0",
"vue-tsc": "^1.8.27",
"zx": "^7.2.3"
},

Some files were not shown because too many files have changed in this diff Show More