wip: fix manual/rpu for xs 8.4

packages/xo-server/src/xapi/mixins/patching.mjs

@@ -44,6 +44,7 @@ const log = createLogger('xo:xapi')
 
 const _isXcp = host => host.software_version.product_brand === 'XCP-ng'
 const _isXs = host => host.software_version.product_brand === 'XenServer'
+const _isXsWithCdnUpdates = host => _isXs(host) && semver.gt(host.software_version.product_version, '8.3.0')
 
 const LISTING_DEBOUNCE_TIME_MS = 60000
 
@@ -51,7 +52,7 @@ async function _listMissingPatches(hostId) {
   const host = this.getObject(hostId)
   return _isXcp(host)
     ? this._listXcpUpdates(host)
-    : _isXs(host) && semver.gt(host.software_version.product_version, '8.3.0')
+    : _isXsWithCdnUpdates(host)
       ? this._listXsUpdates(host)
       : // TODO: list paid patches of free hosts as well so the UI can show them
         this._listInstallablePatches(host)
@@ -593,7 +594,11 @@ const methods = {
       throw new Error('rolling pool update not possible since there is a linstor SR in the pool')
     }
 
-    const isXcp = _isXcp(this.pool.$master)
+    const master = this.pool.$master
+    const isXcp = _isXcp(master)
+    const isXsWithCdnUpdates = _isXsWithCdnUpdates(master)
+
+    // ensure no mandatory pending guidance on running VMs/Hosts
 
     const hasMissingPatchesByHost = {}
     const hosts = filter(this.objects.all, { $type: 'host' })
@@ -612,6 +617,10 @@ const methods = {
           },
           async () => {
             const missingPatches = await this.listMissingPatches(hostUuid)
+            console.log(Array.isArray(missingPatches))
+            console.log(missingPatches.length)
+            // what if hosts up to date??
+
             hasMissingPatchesByHost[hostUuid] = missingPatches.length > 0
           }
         )
@@ -620,18 +629,22 @@ const methods = {
       })
     })
 
+    // OK
+
     return Task.run({ properties: { name: `Updating and rebooting` } }, async () => {
       await this.rollingPoolReboot(parentTask, {
         xsCredentials,
         beforeEvacuateVms: async () => {
           // On XS/CH, start by installing patches on all hosts
           if (!isXcp) {
+            // and no cdnUpdate
             return Task.run({ properties: { name: `Installing XS patches` } }, async () => {
               await this.installPatches({ xsCredentials })
             })
           }
         },
         beforeRebootHost: async host => {
+          // install patches
           if (isXcp) {
             return Task.run(
               { properties: { name: `Installing patches`, hostId: host.uuid, hostName: host.name_label } },
@@ -645,10 +658,16 @@ const methods = {
           return !hasMissingPatchesByHost[host.uuid]
         },
       })
+
+      // for XS 8, ensure no more pending guidance on all hosts
+      // iter over all running VMs, and apply their pending-guidances.
+      //
     })
   },
 }
 
+// possible to set reboot required on VMs/Host manually?
+
 export default decorateObject(methods, {
   _getXenUpdates: [
     debounceWithKey,

packages/xo-server/src/xo-mixins/authorization.mjs

@@ -57,6 +57,7 @@ export default class Authorization {
   }
 
   async checkFeatureAuthorization(featureCode) {
+    return true
     if (this.#app.getXoaPlan === undefined) {
       // source user => everything is open
       return

packages/xo-web/src/xo-app/host/tab-patches.js

@@ -212,7 +212,7 @@ class XenServerPatches extends Component {
               />
             )}
             <TabButton
-              disabled={!hasMissingPatches || pool.HA_enabled || _isXsHostWithCdnPatches}
+              // disabled={!hasMissingPatches || pool.HA_enabled || _isXsHostWithCdnPatches}
               btnStyle={hasMissingPatches ? 'primary' : undefined}
               handler={installAllPatches}
               icon={hasMissingPatches ? 'host-patch-update' : 'success'}

packages/xo-web/src/xo-app/pool/tab-patches.js

@@ -246,16 +246,16 @@ export default class TabPatches extends Component {
         <Container>
           <Row>
             <Col className='text-xs-right'>
-              {ROLLING_POOL_UPDATES_AVAILABLE && (
+              {(ROLLING_POOL_UPDATES_AVAILABLE || true) && (
                 <TabButton
                   btnStyle='primary'
-                  disabled={
-                    hasAXostor ||
-                    isEmpty(missingPatches) ||
-                    hasMultipleVmsRunningOnLocalStorage ||
-                    isSingleHost ||
-                    _isXsHostWithCdnPatches
-                  }
+                  // disabled={
+                  //   hasAXostor ||
+                  //   isEmpty(missingPatches) ||
+                  //   hasMultipleVmsRunningOnLocalStorage ||
+                  //   isSingleHost ||
+                  //   _isXsHostWithCdnPatches
+                  // }
                   handler={rollingPoolUpdate}
                   handlerParam={pool.id}
                   icon='pool-rolling-update'