Administrator/Xen-Orchestra-xen-orchestra-MIRROR
1
0
Fork 1
mirror of https://github.com/vatesfr/xen-orchestra.git synced 2026-11-09 17:06:13 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(xo-server-sdn-controller): Guard center.$ref access in _pifUpdated and _hostUnreachable

Browse Source 
Avoid to dereference privateNetwork.center without checking it first.
This commit is contained in:
Sebastien Rodot
2026-10-19 17:35:33 +02:00
committed by Sebastien Marie
parent 1329b7bc69
commit d4dd0791f2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/xo-server-sdn-controller/src/index.js
View File

@@ -1167,7 +1167,7 @@ class SDNController extends EventEmitter {
if (!pif.currently_attached) {
const tunnel = getHostTunnelForNetwork(pif.$host, pif.network)
await tunnel.set_status({ active: 'false' })
if (privateNetwork.center.$ref !== pif.host) {
if (privateNetwork.center?.$ref !== pif.host) {
return
}
@@ -1478,7 +1478,7 @@ class SDNController extends EventEmitter {
async _hostUnreachable(host) {
let privateNetworks = filter(this.privateNetworks, privateNetwork => {
return privateNetwork.center.$ref === host.$ref
return privateNetwork.center?.$ref === host.$ref
})
for (const privateNetwork of privateNetworks) {
log.debug('Unreachable star-center, electing a new one', {