mirror of
https://github.com/opencv/opencv.git
synced 2026-11-21 00:35:35 -06:00
imgproc: fix out-of-bounds read in OpenCL color kernels for 3-channel input 🤖🤖🤖 - #30274 YUV2RGB, RGB2YCrCb, YCrCb2RGB and the PIX_PER_WI_X != 2 path of RGB2YUV_YV12_IYUV load each source pixel with vload4 but only use the first three components. With SCN == 3 the load of the last pixel reads one element past the end of the source buffer, which may result in a GPU page fault. Use vload3, as RGB2YUV already does, and drop the now unused DATA_TYPE_4 macro. The same issue is fixed in RGB2XYZ, XYZ2RGB, BGR2Lab, Lab2BGR, RGB2HSV, HSV2RGB, RGB2HLS, HLS2RGB and RGB2RGB5x5, which load each source pixel with vload4 but only use the first three components when SCN == 3. Add an OpenCL cvtColor test with a contiguous 3-channel source whose size is a multiple of 1 MiB, so the last pixel ends exactly at the end of the buffer, covering 8U and 32F conversions and RGB2RGB5x5. ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake