mirror of
https://github.com/opencv/opencv.git
synced 2026-09-11 12:52:33 -05:00
5846edaa83
samples: fix HoughLines/HoughLinesP Python sample for 5.0 shape change (fixes #29637) - #29663 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake <!-- Note!!! If you are an automated agent, we have a special process for you: add 🤖🤖🤖 to the end of the PR title. --> Fixes #29637. OpenCV 5.0 changed vector-backed Mat/OutputArray to true 1D arrays (see migration guide: 1D and 0D array semantics). This changes HoughLines/ HoughLinesP Python return shape from (N,1,X) to (N,X), breaking the old indexing pattern used in the tutorial sample. Tested locally against opencv-python 5.0 — script runs without error, lines drawn correctly on samples/data/sudoku.png.
60 lines
1.5 KiB
Python
Executable File
60 lines
1.5 KiB
Python
Executable File
#!/usr/bin/python
|
|
|
|
'''
|
|
This example illustrates how to use Hough Transform to find lines
|
|
|
|
Usage:
|
|
houghlines.py [<image_name>]
|
|
image argument defaults to pic1.png
|
|
'''
|
|
|
|
# Python 2/3 compatibility
|
|
from __future__ import print_function
|
|
|
|
import cv2 as cv
|
|
import numpy as np
|
|
|
|
import sys
|
|
import math
|
|
|
|
def main():
|
|
try:
|
|
fn = sys.argv[1]
|
|
except IndexError:
|
|
fn = 'pic1.png'
|
|
|
|
src = cv.imread(cv.samples.findFile(fn))
|
|
dst = cv.Canny(src, 50, 200)
|
|
cdst = cv.cvtColor(dst, cv.COLOR_GRAY2BGR)
|
|
|
|
if True: # HoughLinesP
|
|
lines = cv.HoughLinesP(dst, 1, math.pi/180.0, 40, np.array([]), 50, 10)
|
|
a, b = lines.shape
|
|
for i in range(a):
|
|
cv.line(cdst, (lines[i][0], lines[i][1]), (lines[i][2], lines[i][3]), (0, 0, 255), 3, cv.LINE_AA)
|
|
|
|
else: # HoughLines
|
|
lines = cv.HoughLines(dst, 1, math.pi/180.0, 50, np.array([]), 0, 0)
|
|
if lines is not None:
|
|
num_lines, _ = lines.shape
|
|
for i in range(num_lines):
|
|
rho = lines[i][0]
|
|
theta = lines[i][1]
|
|
a = math.cos(theta)
|
|
b = math.sin(theta)
|
|
x0, y0 = a*rho, b*rho
|
|
pt1 = ( int(x0+1000*(-b)), int(y0+1000*(a)) )
|
|
pt2 = ( int(x0-1000*(-b)), int(y0-1000*(a)) )
|
|
cv.line(cdst, pt1, pt2, (0, 0, 255), 3, cv.LINE_AA)
|
|
|
|
cv.imshow("detected lines", cdst)
|
|
|
|
cv.imshow("source", src)
|
|
cv.waitKey(0)
|
|
print('Done')
|
|
|
|
|
|
if __name__ == '__main__':
|
|
print(__doc__)
|
|
main()
|
|
cv.destroyAllWindows() |