Files
opencv-MIRROR/modules
pranayr710 ec1ee5a5fb Merge pull request #30199 from pranayr710:fix/convert-32u-signed-and-precision
core: fix convertTo() from CV_32U returning negative values for CV_16BF and losing precision for CV_64F - #30199

Fixes #30198.

Two entries in the `32u` block of `convert.simd.hpp` pick the wrong type. Both make `convertTo()` from `CV_32U` return something an unsigned source cannot produce, and both are one-line changes.

### 1. `CV_32U -> CV_16BF` declared its source as `int`

```cpp
DEF_CVT_FUNC(32u16bf, cvt1_, int, bfloat, v_float32)
```

Every other entry in the block says `unsigned`, including the neighbouring `CV_32U -> CV_16F`, which is correct. So everything above `INT_MAX` was read as negative - `UINT_MAX` converted to `-1`, `3000000000` to `-1291845600`.

This one is wrong at **every length, scalar path included**, because the type is wrong at the declaration rather than in the vector code.

### 2. `CV_32U -> CV_64F` widened through `float`

```cpp
DEF_CVT_FUNC(32u64f, cvt_, unsigned, double, v_float32)
```

`float` has a 24-bit mantissa and cannot hold a `uint32`, so values above 2^24 were rounded on the way to a destination that represents all of them exactly: `16777217` came back as `16777216`, `UINT_MAX` as `4294967296`. Only the vector body was affected, so the same value was correct at length 8 and wrong at length 16.

`CV_32U` was the only integer depth converting to `CV_64F` through `float` - `8U`, `8S`, `16U`, `16S` and `32S` go via `v_int32`, `64U` and `64S` via `v_float64`. It now uses the exact 64-bit path like the rest.

### One thing that needed care

`vx_load_pair_as(const unsigned*, v_float64&, v_float64&)` backed that exact path with a scalar spill through a buffer, so simply switching to it would have traded precision for speed - which is not a trade worth offering. It now widens to 64 bits and uses the existing signed conversion, exact because every `uint32` is a non-negative `int64`, and stays vectorized:

```cpp
v_uint64 lo, hi;
v_expand(vx_load(ptr), lo, hi);
a = v_cvt_f64(v_reinterpret_as_s64(lo));
b = v_cvt_f64(v_reinterpret_as_s64(hi));
```

No new HAL primitive is needed - `v_cvt_f64(v_int64)` exists on every backend.

### How these were found

A length-independence sweep over the element-wise operations: 2688 combinations of depth, boundary value and length, checking that an element's result never depends on how many elements sit beside it.

Worth recording that the sweep's first output was misleading. It reported `add`, `absdiff` and `multiply` on `CV_32U` as broken, because it compared results via `convertTo(CV_64F)` - which is defect 2. Reading the raw `uint32` lanes instead showed all three are exact, and that the readback was the bug. I would have filed three imaginary bugs by trusting the first run.

### Testing

`Core_ConvertFrom32U` asserts that no conversion from `CV_32U` is ever negative, and that `CV_64F` - the only destination here that can represent every `uint32` - is exact. Lengths straddle the vector width so the body, the tail and the two together are covered.

Checked it fails without the patch rather than assuming: **36 of its 224 cases fail** on current 5.x with only the test applied.

With the patch: 228/228 on `*ConvertTo*` and `*ConvertFrom32U*` at both the default dispatch and `OPENCV_CPU_DISABLE=AVX2,AVX,FP16`. Full `opencv_test_core` 17185 passed, with only the 7 filestorage/globbing failures this machine always has.

### Note on overlap

#30178 also touches `convert.hpp` and `test_arithm.cpp`, but in the other direction (16-bit float sources into wide integer destinations) and in different regions of both files, so there is no functional overlap - only a possible textual conflict in the test file, which I am happy to rebase around.

### Pull Request Readiness Checklist

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
- [x] The feature is well documented and sample code can be built with the project CMake
2026-10-15 12:38:17 +03:00
..
2026-07-09 12:17:24 +03:00
2026-07-09 12:17:24 +03:00
2026-09-23 11:18:41 +02:00
2026-08-19 17:38:39 +02:00