Administrator/opencv-MIRROR
1
0
Fork 0
mirror of https://github.com/opencv/opencv.git synced 2026-09-15 07:29:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #29877 from cuishuang:core-reject-invalid-bool

Browse Source 
core: reject invalid boolean values in CommandLineParser
This commit is contained in:
Alexander Smorkalov
2026-09-11 15:43:44 +03:00
committed by GitHub
parent 49c3f46f85 fd00f2b2d0
commit 254269f094
3 changed files with 33 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
modules/core/src/command_line_parser.cpp
View File

@@ -76,9 +76,13 @@ static bool parse_bool(std::string str)
{
std::transform(str.begin(), str.end(), str.begin(), details::char_tolower);
std::istringstream is(str);
bool b;
is >> (str.size() > 1 ? std::boolalpha : std::noboolalpha) >> b;
return b;
bool value = false;
is >> (str.size() > 1 ? std::boolalpha : std::noboolalpha) >> value;
if (is.fail())
CV_Error_(Error::StsBadArg, ("can not convert: [%s] to [bool]", str.c_str()));
return value;
}
static void from_str(const String& str, Param type, void* dst)

22
modules/core/test/test_utils.cpp
View File

@@ -165,6 +165,28 @@ TEST(CommandLineParser, testBoolOption_FalseValues)
EXPECT_FALSE(parser.get<bool>("n"));
}
TEST(CommandLineParser, testBoolOption_InvalidValue)
{
const char* argv[] = {"<bin>", "--info=invalid"};
const int argc = 2;
cv::CommandLineParser parser(argc, argv, keys);
parser.get<bool>("info");
EXPECT_FALSE(parser.check());
}
TEST(CommandLineParser, testBoolOption_InvalidNumericValue)
{
const char* argv[] = {"<bin>", "--info=2"};
const int argc = 2;
cv::CommandLineParser parser(argc, argv, keys);
parser.get<bool>("info");
EXPECT_FALSE(parser.check());
}
static const char * const keys2 =
"{ h help | | print help }"