Administrator/gitea-MIRROR
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2026-11-09 17:37:20 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix(web): don't block README images with REQUIRE_SIGNIN_VIEW = expensive (#40264)

Browse Source 
Relax expensive endpoint list, then README can render its images.

---------

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
Renox
2026-11-07 13:34:01 +00:00
committed by GitHub
parent 3aca9c8fb7
commit 462ab3801a
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
routers/common/blockexpensive.go
View File

@@ -39,20 +39,22 @@ func isRoutePathExpensive(routePattern string) bool {
return false return false
} }
// an endpoint is expensive if crawlers could consume a lot of resources by accessing it
expensivePaths := []string{ expensivePaths := []string{
// code related // code related
// media and raw endpoints are for single file accesses and useful for rendering README images, not that expensive
// the single file endpoints won't be accessed by crawlers as long as the commits/files endpoints are protected from crawlers
"/{username}/{reponame}/archive/", "/{username}/{reponame}/archive/",
"/{username}/{reponame}/blame/", "/{username}/{reponame}/blame/",
"/{username}/{reponame}/commit/", "/{username}/{reponame}/commit/",
"/{username}/{reponame}/commits/", "/{username}/{reponame}/commits/",
"/{username}/{reponame}/compare/", "/{username}/{reponame}/compare/",
"/{username}/{reponame}/graph", "/{username}/{reponame}/graph",
"/{username}/{reponame}/media/",
"/{username}/{reponame}/raw/",
"/{username}/{reponame}/rss/branch/", "/{username}/{reponame}/rss/branch/",
"/{username}/{reponame}/src/", "/{username}/{reponame}/src/",
// issue & PR related (no trailing slash) // issue & PR related (no trailing slash)
// because it would cause heavy database queries, and PR pages need to load a lot of git data
"/{username}/{reponame}/issues", "/{username}/{reponame}/issues",
"/{username}/{reponame}/{type:issues}", "/{username}/{reponame}/{type:issues}",
"/{username}/{reponame}/pulls", "/{username}/{reponame}/pulls",

5
tests/integration/signin_test.go
View File

@@ -188,6 +188,11 @@ func TestRequireSignInView(t *testing.T) {
req = NewRequest(t, "GET", "/user2/repo1/src/branch/master") req = NewRequest(t, "GET", "/user2/repo1/src/branch/master")
resp := MakeRequest(t, req, http.StatusSeeOther) resp := MakeRequest(t, req, http.StatusSeeOther)
assert.Equal(t, "/user/login?redirect_to=%2Fuser2%2Frepo1%2Fsrc%2Fbranch%2Fmaster", resp.Header().Get("Location")) assert.Equal(t, "/user/login?redirect_to=%2Fuser2%2Frepo1%2Fsrc%2Fbranch%2Fmaster", resp.Header().Get("Location"))
req = NewRequest(t, "GET", "/user2/repo1/media/branch/master/README.md")
MakeRequest(t, req, http.StatusOK)
req = NewRequest(t, "GET", "/user2/repo1/raw/commit/65f1bf27bc3bf70f64657658635e66094edbcb4d/README.md")
MakeRequest(t, req, http.StatusOK)
}) })
} }