mirror of
https://github.com/vatesfr/xen-orchestra.git
synced 2026-11-09 17:06:13 -06:00
3bf50c38ee
This branch is a reliability overhaul of the ESXi/vSphere source side of V2V, plus a scope reduction of the package. The SOAP plumbing is rewritten:
VimClient wraps @vates/node-vsphere-soap in a promise API with one emitter per call (no more cross-talk between concurrent calls, no listener leak) and a pTimeout;
vim25 faults are now parsed (_parseFault.mjs) so callers get a real fault type instead of task execution failed;
the library no longer throws from async callbacks (which killed xo-server) and its beforeExit logout hook is per-client instead of removeAllListeners.
Request specs are built in explicit schema order (soap/specs.mjs) with xsi:type, and property values are normalized (soap/normalize.mjs) so search() and the new #retrieveProperty share one shape.
search() now paginates, cancels the retrieval and destroys the container view.
Datastore HTTP downloads get session-cookie reuse, retry with jittered backoff, a headers-only timeout, and range-honouring validation.
Task waiting polls with backoff and per-operation timeouts (6 h for snapshot consolidation).
nbdkit servers are memoized by a key that includes the export options, the readiness wait races the process death instead of sleeping 2 s
the password file is 0600 and unlinked
the thumbprint is read over TLS in-process instead of two openssl spawns.
The old VHD-over-datastore readers (VhdEsxi*, Datastore*, openDeltaVmdkAsVhd) are deleted, hence the majo, rleaving the vddk/NBD path with a COWD grain-directory parser as data-map fallback.
~1.7k lines of unit tests are added.
57 lines
1.8 KiB
JavaScript
57 lines
1.8 KiB
JavaScript
import assert from 'node:assert/strict'
|
|
import { describe, it } from 'node:test'
|
|
|
|
import { formatNbdkitArgs } from './_nbdkit.mjs'
|
|
|
|
const PARAMS = {
|
|
compression: 'fastlz',
|
|
diskPath: '[ds main] a.vm/a.vm.vmdk',
|
|
host: 'esxi.test',
|
|
libdir: '/usr/local/lib/vddk/vmware-vix-disklib-distrib',
|
|
passFile: '/tmp/xo-server-42/params',
|
|
port: 11000,
|
|
singleLink: false,
|
|
threads: 1,
|
|
thumbprint: 'AA:BB:CC',
|
|
user: 'root',
|
|
vmId: 'vm-42',
|
|
}
|
|
|
|
describe('formatNbdkitArgs', function () {
|
|
it('never passes an empty argument', function () {
|
|
// an empty argument sits in the slot of the magic positional parameter of the plugin
|
|
for (const singleLink of [false, true]) {
|
|
const args = formatNbdkitArgs({ ...PARAMS, singleLink })
|
|
assert.equal(
|
|
args.every(argument => argument.length > 0),
|
|
true,
|
|
JSON.stringify(args)
|
|
)
|
|
}
|
|
})
|
|
|
|
it('exports read only, exits with its parent, and reads the password from a file', function () {
|
|
const args = formatNbdkitArgs(PARAMS)
|
|
|
|
assert.ok(args.includes('-r'))
|
|
assert.ok(args.includes('--exit-with-parent'))
|
|
assert.ok(args.includes(`password=+${PARAMS.passFile}`))
|
|
// the password itself never appears in the command line, which is world readable
|
|
assert.equal(
|
|
args.some(argument => argument.includes('password=') && !argument.startsWith('password=+')),
|
|
false
|
|
)
|
|
})
|
|
|
|
it('restricts the export to the top delta only when asked', function () {
|
|
assert.equal(formatNbdkitArgs(PARAMS).includes('single-link=true'), false)
|
|
assert.equal(formatNbdkitArgs({ ...PARAMS, singleLink: true }).includes('single-link=true'), true)
|
|
})
|
|
|
|
it('ends with the disk to export', function () {
|
|
const args = formatNbdkitArgs({ ...PARAMS, singleLink: true })
|
|
|
|
assert.equal(args[args.length - 1], PARAMS.diskPath)
|
|
})
|
|
})
|