From 54260268ba66b460aa2d37c3fc2311f84efb5274 Mon Sep 17 00:00:00 2001 From: Mathieu Date: Mon, 20 Jul 2026 16:00:13 +0200 Subject: [PATCH] fix(xo-server): demote successful fallback logs (#10131) XO-2734 --- CHANGELOG.unreleased.md | 1 + packages/xo-server/docs/rolling-pool-update-reboot.md | 2 +- packages/xo-server/src/xapi/index.mjs | 7 ++++++- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md index 025b18a661..2b9521b447 100644 --- a/CHANGELOG.unreleased.md +++ b/CHANGELOG.unreleased.md @@ -44,6 +44,7 @@ - [RPU] Fix `The updater plugin is busy` error making the update fail right after the "Updating LINSTOR packages" step (PR [#10115](https://github.com/vatesfr/xen-orchestra/pull/10115)) - [Plugins/Perf-alert] Update URL generation to support V6 routing (PR [#10054](https://github.com/vatesfr/xen-orchestra/pull/10054)) - [Rolling Pool Update/Reboot] Temporarily disable VMs auto power on during the run: unexpected VM starts on rebooted hosts could break the remaining host evacuations (`HOST_NOT_ENOUGH_FREE_MEMORY`) (PR [#10104](https://github.com/vatesfr/xen-orchestra/pull/10104)) +- [Host] Successful evacuation signature fallbacks on older XAPI versions are no longer logged as warnings (PR [#10131](https://github.com/vatesfr/xen-orchestra/pull/10131)) ### Packages to release diff --git a/packages/xo-server/docs/rolling-pool-update-reboot.md b/packages/xo-server/docs/rolling-pool-update-reboot.md index 04a86ab819..36e1ba775e 100644 --- a/packages/xo-server/docs/rolling-pool-update-reboot.md +++ b/packages/xo-server/docs/rolling-pool-update-reboot.md @@ -54,7 +54,7 @@ Old traces are garbage-collected on mtime (`rpu.tracesRetention`, 31 days by def | ------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | `The updater plugin is busy (current operation: update)` on `Listing missing patches` | Race between the LINSTOR update step and `check_update`: the updater lock on the host is not released yet. Not destructive, happens before anything is installed. Relaunch. | | `VM_LACKS_FEATURE` with OpaqueRefs, on `Updating and rebooting` | A running VM has no PV drivers. `assert_can_evacuate` runs on all hosts before anything starts, so the RPU refuses upfront. Shut the VM down or install guest tools. | -| `MESSAGE_PARAMETER_COUNT_MISMATCH(host.evacuate, 1, 3)` (WARN) | Signature fallback on XAPI 8.2. Harmless. | +| `MESSAGE_PARAMETER_COUNT_MISMATCH(host.evacuate, 1, 3)` (DEBUG) | Expected signature fallback on XAPI 8.2. WARN only if every supported signature fails. | | Timeout on `Waiting for host to be up` | Host takes too long to boot. `xapiOptions.restartHostTimeout` (default 20 minutes). | | Pool stays `disconnected` after the master rebooted, `EHOSTUNREACH` | Stale connection error, the retry did not kick in yet. `POST /rest/v0/servers//actions/connect` reconnects immediately. | diff --git a/packages/xo-server/src/xapi/index.mjs b/packages/xo-server/src/xapi/index.mjs index dcfb18e961..783ceefff5 100644 --- a/packages/xo-server/src/xapi/index.mjs +++ b/packages/xo-server/src/xapi/index.mjs @@ -240,7 +240,12 @@ export default class Xapi extends XapiBase { delay: 0, when: { code: 'MESSAGE_PARAMETER_COUNT_MISMATCH' }, onRetry: error => { - log.warn(error) + if (params.length <= 1) { + log.warn(error) + throw error + } + + log.debug(error) popParamsAndTrim(1) }, })