From 3cba902de28fc0fbe91e3b7b48532e61a6e7800c Mon Sep 17 00:00:00 2001
From: Inhwan Wee <inhwan.wee@holiday-robotics.com>
Date: Mon, 2 Jun 2025 14:55:46 +0900
Subject: [PATCH] add video scale (desktop)

---
 desktop/src/renderer/src/App.tsx              | 16 ++++-
 .../src/components/menu/video/index.tsx       |  2 +
 .../src/components/menu/video/scale.tsx       | 58 +++++++++++++++++++
 desktop/src/renderer/src/i18n/locales/be.ts   |  5 +-
 desktop/src/renderer/src/i18n/locales/de.ts   |  5 +-
 desktop/src/renderer/src/i18n/locales/en.ts   |  1 +
 desktop/src/renderer/src/i18n/locales/ko.ts   |  1 +
 desktop/src/renderer/src/i18n/locales/nl.ts   |  5 +-
 desktop/src/renderer/src/i18n/locales/ru.ts   |  1 +
 desktop/src/renderer/src/i18n/locales/zh.ts   |  1 +
 desktop/src/renderer/src/jotai/device.ts      |  2 +
 .../src/renderer/src/libs/storage/index.ts    | 13 +++++
 12 files changed, 102 insertions(+), 8 deletions(-)
 create mode 100644 desktop/src/renderer/src/components/menu/video/scale.tsx

diff --git a/desktop/src/renderer/src/App.tsx b/desktop/src/renderer/src/App.tsx
index 97f9bb4..7ab90ac 100644
--- a/desktop/src/renderer/src/App.tsx
+++ b/desktop/src/renderer/src/App.tsx
@@ -11,7 +11,12 @@ import { Keyboard } from '@renderer/components/keyboard'
 import { Menu } from '@renderer/components/menu'
 import { Mouse } from '@renderer/components/mouse'
 import { VirtualKeyboard } from '@renderer/components/virtual-keyboard'
-import { resolutionAtom, serialPortStateAtom, videoStateAtom } from '@renderer/jotai/device'
+import {
+  resolutionAtom,
+  serialPortStateAtom,
+  videoScaleAtom,
+  videoStateAtom
+} from '@renderer/jotai/device'
 import { isKeyboardEnableAtom } from '@renderer/jotai/keyboard'
 import { mouseStyleAtom } from '@renderer/jotai/mouse'
 import { camera } from '@renderer/libs/camera'
@@ -24,6 +29,7 @@ const App = (): ReactElement => {
   const { t } = useTranslation()
   const isBigScreen = useMediaQuery({ minWidth: 850 })
 
+  const videoScale = useAtomValue(videoScaleAtom)
   const videoState = useAtomValue(videoStateAtom)
   const serialPortState = useAtomValue(serialPortStateAtom)
   const mouseStyle = useAtomValue(mouseStyleAtom)
@@ -115,7 +121,13 @@ const App = (): ReactElement => {
       <video
         id="video"
         className={clsx('block min-h-[480px] min-w-[640px] select-none', mouseStyle)}
-        style={{ maxWidth: '100%', maxHeight: '100%', objectFit: 'scale-down' }}
+        style={{
+          transform: `scale(${videoScale})`,
+          transformOrigin: 'center',
+          maxWidth: '100%',
+          maxHeight: '100%',
+          objectFit: 'scale-down'
+        }}
         autoPlay
         playsInline
       />
diff --git a/desktop/src/renderer/src/components/menu/video/index.tsx b/desktop/src/renderer/src/components/menu/video/index.tsx
index 45896b5..8bcf218 100644
--- a/desktop/src/renderer/src/components/menu/video/index.tsx
+++ b/desktop/src/renderer/src/components/menu/video/index.tsx
@@ -4,11 +4,13 @@ import { MonitorIcon } from 'lucide-react'
 
 import { Device } from './device'
 import { Resolution } from './resolution'
+import { Scale } from './scale'
 
 export const Video = (): ReactElement => {
   const content = (
     <div className="flex flex-col space-y-1">
       <Resolution />
+      <Scale />
       <Device />
     </div>
   )
diff --git a/desktop/src/renderer/src/components/menu/video/scale.tsx b/desktop/src/renderer/src/components/menu/video/scale.tsx
new file mode 100644
index 0000000..7c39b15
--- /dev/null
+++ b/desktop/src/renderer/src/components/menu/video/scale.tsx
@@ -0,0 +1,58 @@
+import { ReactElement, useEffect } from 'react'
+import { Popover, Slider } from 'antd'
+import { useAtom } from 'jotai'
+import { ScalingIcon } from 'lucide-react'
+import { useTranslation } from 'react-i18next'
+
+import { videoScaleAtom } from '@renderer/jotai/device'
+import * as storage from '@renderer/libs/storage'
+
+export const Scale = (): ReactElement => {
+  const { t } = useTranslation()
+
+  const [videoScale, setVideoScale] = useAtom(videoScaleAtom)
+
+  useEffect(() => {
+    const scale = storage.getVideoScale()
+    if (scale) {
+      setVideoScale(scale)
+    }
+  }, [setVideoScale])
+
+  async function updateScale(scale: number): Promise<void> {
+    setVideoScale(scale)
+    storage.setVideoScale(scale)
+  }
+
+  const content = (
+    <div className="h-[150px] w-[60px] py-3">
+      <Slider
+        vertical
+        marks={{
+          0.5: <span>x0.5</span>,
+          1: <span>x1.0</span>,
+          1.5: <span>x1.5</span>,
+          2: <span>x2.0</span>
+        }}
+        range={false}
+        included={false}
+        min={0.5}
+        max={2}
+        step={0.1}
+        defaultValue={videoScale}
+        onChange={updateScale}
+      />
+    </div>
+  )
+
+  return (
+    <Popover content={content} placement="rightTop" arrow={false} align={{ offset: [13, 0] }}>
+      <div className="flex h-[30px] cursor-pointer items-center space-x-1 rounded px-3 text-neutral-300 hover:bg-neutral-700/50">
+        <div className="flex h-[14px] w-[20px] items-end">
+          <ScalingIcon size={16} />
+        </div>
+        <span>{t('video.scale')}</span>
+      </div>
+    </Popover>
+  )
+}
diff --git a/desktop/src/renderer/src/i18n/locales/be.ts b/desktop/src/renderer/src/i18n/locales/be.ts
index ce82906..5858b17 100644
--- a/desktop/src/renderer/src/i18n/locales/be.ts
+++ b/desktop/src/renderer/src/i18n/locales/be.ts
@@ -19,6 +19,7 @@ const be = {
       },
       video: {
         resolution: 'Resolutie',
+        scale: 'Schaal',
         customResolution: 'Aangepast',
         device: 'Toestel',
         custom: {
@@ -76,5 +77,5 @@ const be = {
       }
     }
   }
-  
-  export default be
\ No newline at end of file
+
+  export default be
diff --git a/desktop/src/renderer/src/i18n/locales/de.ts b/desktop/src/renderer/src/i18n/locales/de.ts
index 8a1ac47..334cf68 100644
--- a/desktop/src/renderer/src/i18n/locales/de.ts
+++ b/desktop/src/renderer/src/i18n/locales/de.ts
@@ -19,6 +19,7 @@ const de = {
       },
       video: {
         resolution: 'Auflösung',
+        scale: 'Skalierung',
         customResolution: 'Benutzerdefiniert',
         device: 'Gerät',
         custom: {
@@ -76,5 +77,5 @@ const de = {
       }
     }
   }
-  
-  export default de
\ No newline at end of file
+
+  export default de
diff --git a/desktop/src/renderer/src/i18n/locales/en.ts b/desktop/src/renderer/src/i18n/locales/en.ts
index 707c660..4110787 100644
--- a/desktop/src/renderer/src/i18n/locales/en.ts
+++ b/desktop/src/renderer/src/i18n/locales/en.ts
@@ -19,6 +19,7 @@ const en = {
     },
     video: {
       resolution: 'Resolution',
+      scale: 'Scale',
       customResolution: 'Custom',
       device: 'Device',
       custom: {
diff --git a/desktop/src/renderer/src/i18n/locales/ko.ts b/desktop/src/renderer/src/i18n/locales/ko.ts
index 7e0b720..6b58ec8 100644
--- a/desktop/src/renderer/src/i18n/locales/ko.ts
+++ b/desktop/src/renderer/src/i18n/locales/ko.ts
@@ -19,6 +19,7 @@ const ko = {
     },
     video: {
       resolution: '해상도',
+      scale: '배율',
       customResolution: '사용자 정의',
       device: '장치',
       custom: {
diff --git a/desktop/src/renderer/src/i18n/locales/nl.ts b/desktop/src/renderer/src/i18n/locales/nl.ts
index f2dd737..395ff32 100644
--- a/desktop/src/renderer/src/i18n/locales/nl.ts
+++ b/desktop/src/renderer/src/i18n/locales/nl.ts
@@ -19,6 +19,7 @@ const nl = {
       },
       video: {
         resolution: 'Resolutie',
+        scale: 'Schaal',
         customResolution: 'Aangepast',
         device: 'Apparaat',
         custom: {
@@ -76,5 +77,5 @@ const nl = {
       }
     }
   }
-  
-  export default nl
\ No newline at end of file
+
+  export default nl
diff --git a/desktop/src/renderer/src/i18n/locales/ru.ts b/desktop/src/renderer/src/i18n/locales/ru.ts
index 4e50e6d..029b1b1 100644
--- a/desktop/src/renderer/src/i18n/locales/ru.ts
+++ b/desktop/src/renderer/src/i18n/locales/ru.ts
@@ -19,6 +19,7 @@ const ru = {
     },
     video: {
       resolution: 'Разрешение',
+      scale: 'Масштаб',
       customResolution: 'Пользовательское',
       device: 'Видеоустройство',
       custom: {
diff --git a/desktop/src/renderer/src/i18n/locales/zh.ts b/desktop/src/renderer/src/i18n/locales/zh.ts
index f6ea3f1..1c6551f 100644
--- a/desktop/src/renderer/src/i18n/locales/zh.ts
+++ b/desktop/src/renderer/src/i18n/locales/zh.ts
@@ -18,6 +18,7 @@ const zh = {
     },
     video: {
       resolution: '分辨率',
+      scale: '缩放',
       customResolution: '自定义',
       device: '设备',
       custom: {
diff --git a/desktop/src/renderer/src/jotai/device.ts b/desktop/src/renderer/src/jotai/device.ts
index c42460f..84dbee6 100644
--- a/desktop/src/renderer/src/jotai/device.ts
+++ b/desktop/src/renderer/src/jotai/device.ts
@@ -10,6 +10,8 @@ export const resolutionAtom = atom<Resolution>({
   height: 1080
 })
 
+export const videoScaleAtom = atom<number>(1.0)
+
 export const videoDeviceIdAtom = atom('')
 export const videoStateAtom = atom<VideoState>('disconnected')
 
diff --git a/desktop/src/renderer/src/libs/storage/index.ts b/desktop/src/renderer/src/libs/storage/index.ts
index 0024a9d..a91a0bb 100644
--- a/desktop/src/renderer/src/libs/storage/index.ts
+++ b/desktop/src/renderer/src/libs/storage/index.ts
@@ -5,6 +5,7 @@ import { getWithExpiry, setWithExpiry } from './expiry'
 const LANGUAGE_KEY = 'nanokvm-usb-language'
 const VIDEO_DEVICE_ID_KEY = 'nanokvm-usb-video-device-id'
 const VIDEO_RESOLUTION_KEY = 'nanokvm-usb-video-resolution'
+const VIDEO_SCALE_KEY = 'nanokvm-usb-video-scale'
 const CUSTOM_RESOLUTION_KEY = 'nanokvm-usb-custom-resolution'
 const SERIAL_PORT_KEY = 'nanokvm-serial-port'
 const IS_MENU_OPEN_KEY = 'nanokvm-is-menu-open'
@@ -63,6 +64,18 @@ export function removeCustomResolutions(): void {
   localStorage.removeItem(CUSTOM_RESOLUTION_KEY)
 }
 
+export function getVideoScale(): number | null {
+  const scale = localStorage.getItem(VIDEO_SCALE_KEY)
+  if (scale && Number(scale)) {
+    return Number(scale)
+  }
+  return null
+}
+
+export function setVideoScale(scale: number): void {
+  localStorage.setItem(VIDEO_SCALE_KEY, String(scale))
+}
+
 export function getSerialPort(): string | null {
   return localStorage.getItem(SERIAL_PORT_KEY)
 }